From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1n89DO-0005Ko-JB for mharc-grub-devel@gnu.org; Thu, 13 Jan 2022 18:09:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n89DL-0005KK-Df for grub-devel@gnu.org; Thu, 13 Jan 2022 18:09:04 -0500 Received: from [2a00:1450:4864:20::32a] (port=52047 helo=mail-wm1-x32a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n89DI-00034Z-UL for grub-devel@gnu.org; Thu, 13 Jan 2022 18:09:03 -0500 Received: by mail-wm1-x32a.google.com with SMTP id e5so4947464wmq.1 for ; Thu, 13 Jan 2022 15:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2O2b2SjmSjpXEMfu2UnjgAeB09w28wpY0eWYtsLFgRc=; b=a0GlnFvKE3ZGC0gt4g8ChtOyaTtSEbwjYZiv9SGqvr3S85+7GHMqNFPpJMA9BwHDUi HCGk+YBH2nlW/AwWSZ91OFyokibXQkIlRuI6V6z/2cPxNWi95Hyl4FdrBM22Q4AUXq2p +gcLT7U698eYNXzYf+gZIaHYutaZEoQDm0z37VLj6Ypnju75AgtniZdqjzpVrDCQkA2r FIdmwTEoqd9y8zrfvhSWIgKcdGQ3zgiX6iR9NhwfOk0WEjriq9BTFKi6nfbaY0kDT7BC JJG7Jz1DQdYQzEc2+Oeg6Cz2nfcmKD1/rbDYOAQ6PMEggNev7kUXwgo5R5fhOMuMuYGe UGEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2O2b2SjmSjpXEMfu2UnjgAeB09w28wpY0eWYtsLFgRc=; b=SAkohfR4+d0rovgM5YanZun2lsa1FqM8X9v7UDvMZ3EbUdkoesXf6GwamsP9E4AUAM hqo8UTSi9sC+62OX+ynhTuw3zIvdfmriNzrjRLGuptW2OyyjaI4g0h/7czDzvsBVBqXE adL/ybKBZ+1EDWaHVhn92Mt/4/Jyl1ex2o3csaprgnRm9cvEsxludBXQMQxhNMnh7l4+ ZLrUpaHauJroIrEZ5E+YtyF9Yzb0M2Mj4Tfru/SpGAt+/7bErbylymvUZ/6pnXsQjM9z CldiZd9MpzPc+SkcGXYN5dnHWv5SckNo++jXqVzy3Ux9r4BQ5nV/TITkWCZ0PvuCgFDK SpNg== X-Gm-Message-State: AOAM532A4yGndn5sCx6mXwTRHU3mBF14WSY4t2te30pnn7V3PorsMzKu sv42/EEBrYjYP75efjAgvBY= X-Google-Smtp-Source: ABdhPJw5/WAZkaZu2EO4JAaHtzRPu4nXrc7YaYKY2sJXhzmtYXxLryURYh2e/i4cOf/B02Sh4QOf0A== X-Received: by 2002:a1c:f70f:: with SMTP id v15mr5753212wmh.117.1642115337294; Thu, 13 Jan 2022 15:08:57 -0800 (PST) Received: from localhost.localdomain (17.red-81-39-144.dynamicip.rima-tde.net. [81.39.144.17]) by smtp.gmail.com with ESMTPSA id 185sm3752994wmc.38.2022.01.13.15.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 15:08:56 -0800 (PST) From: Jamo To: jamofer@gmail.com Cc: The development of GNU GRUB Subject: [PATCH] http module is not checking correctly HTTP headers Date: Fri, 14 Jan 2022 00:05:59 +0100 Message-Id: <20220113230556.162283-1-jamofer@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=jamofer@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 23:09:04 -0000 From: Javier Moragon I applied the last suggestion in this patch and I've finally realized how to use git send-email. I'm sorry for the unnecesary mails and I hope for next contributions I won't make the same mistakes, Thank you! --- grub-core/net/http.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/net/http.c b/grub-core/net/http.c index b616cf40b..7a56ec7ef 100644 --- a/grub-core/net/http.c +++ b/grub-core/net/http.c @@ -130,7 +130,7 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) data->first_line_recv = 1; return GRUB_ERR_NONE; } - if (grub_memcmp (ptr, "Content-Length: ", sizeof ("Content-Length: ") - 1) + if (grub_strncasecmp (ptr, "Content-Length: ", sizeof ("Content-Length: ") - 1) == 0 && !data->size_recv) { ptr += sizeof ("Content-Length: ") - 1; @@ -138,8 +138,8 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) data->size_recv = 1; return GRUB_ERR_NONE; } - if (grub_memcmp (ptr, "Transfer-Encoding: chunked", - sizeof ("Transfer-Encoding: chunked") - 1) == 0) + if (grub_strncasecmp (ptr, "Transfer-Encoding: chunked", + sizeof ("Transfer-Encoding: chunked") - 1) == 0) { data->chunked = 1; return GRUB_ERR_NONE; -- 2.32.0