Re: [PATCH v3 1/2] kernfs: use hashed mutex and spinlock in place of global ones.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

Hi Imran,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on a70bf4a85b43cb952bd39dd948b103b1b3eb2cf8]

url:    https://github.com/0day-ci/linux/commits/Imran-Khan/kernfs-use-hashed-mutex-and-spinlock-in-place-of-global-ones/20220113-184429
base:   a70bf4a85b43cb952bd39dd948b103b1b3eb2cf8
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220113/202201132349.uRCekZ3g-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/ee30c7abbab86fd9d653c0aefb8655500dc517d4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Imran-Khan/kernfs-use-hashed-mutex-and-spinlock-in-place-of-global-ones/20220113-184429
        git checkout ee30c7abbab86fd9d653c0aefb8655500dc517d4
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/kernfs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/kernfs/mount.c:390:13: warning: no previous prototype for 'kernfs_lock_init' [-Wmissing-prototypes]
     390 | void __init kernfs_lock_init(void)
         |             ^~~~~~~~~~~~~~~~


vim +/kernfs_lock_init +390 fs/kernfs/mount.c

   389	
 > 390	void __init kernfs_lock_init(void)
   391	{
   392		int count;
   393	
   394		for (count = 0; count < NR_KERNFS_LOCKS; count++) {
   395			spin_lock_init(&kernfs_global_locks.open_node_locks[count].lock);
   396			mutex_init(&kernfs_global_locks.open_file_mutex[count].lock);
   397		}
   398	}
   399	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org