From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA32C433F5 for ; Fri, 14 Jan 2022 06:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239410AbiANGoG (ORCPT ); Fri, 14 Jan 2022 01:44:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236406AbiANGoD (ORCPT ); Fri, 14 Jan 2022 01:44:03 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C4C1C061574 for ; Thu, 13 Jan 2022 22:44:03 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id c14-20020a17090a674e00b001b31e16749cso21084267pjm.4 for ; Thu, 13 Jan 2022 22:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=1Nv9cBoTms/HAwsSMh+lrTCJcZ3jwJC/miP/N5++3LM=; b=Tfs4fl6qHMuuHwQcDMVPYoDo86+b2M9lggqTgT/Et6qTm+mmefqpHC7XMjUueEuNDH ZLBIFPSx2EzW8aK666d+lPVK0uR19prsak1BPbGBey9A5JC0XfvWz2x8OC31GQGBwr4z CzUXU7C0fjAB7f6pO7P+N0N5eFVlUGAlAW7EzgikuU5+Lfz1oxYdUcJnXSSl8txpUD0W 6OuodjwilZlkM6F2QZXyMbWHQ5RukOV7UZhjKfly4mxv12egYIebWd4A6PXsQSgfNtQa 85YmtLFr6EfoUAjw44BzIqJ29pwgt4TNN2dcHG3xxXEcPVH5JPQDprnXMs4mrGUwq3Ld p3Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=1Nv9cBoTms/HAwsSMh+lrTCJcZ3jwJC/miP/N5++3LM=; b=RkcHhJZZ/kEpTnc1ERxaaeOaCA2bPUwZ3RoACbA/3rOjjlCZvltBYJTCzdrvbQn8vB 4GEPR/7MVxy8uERfGHcPLATvNjF/jaojgtIFJiWslfEz6zVvtQLKN66awnXhahCogVI2 DgG5EFUjPbgvkmlCz+Na2xu73E72MNL0Mo9/qJ0l1ynfbbGjo5mtxLmFz0jzpblvWlNr KQ29bqYe0z/pGPPqkhvGfDCOo7lm+hctqh8kfXmLCIPfIC7LAKqJfZfSTvQzcyzOxkNC Pa1Kxi8gn787FgcatCFmopqWVaDrDjWjBlowEbrq1boOTJ7SFv+A/HipylGPuXFRhxvZ 9wzg== X-Gm-Message-State: AOAM533+9WR8TUCNztzT4Bfxhi4zQQKEImOQlrj5z9f+pQUD0AKF/wul CuiCZq8raQ2yWiUXzpEr3KY= X-Google-Smtp-Source: ABdhPJyj9OUFs3Ifg7Q/foM4Lw4if60L1dh8TxGLGhtD4IOaR0ZdfzpiYGEpmw38sjPo4afyX6uhxA== X-Received: by 2002:a17:903:2311:b0:14a:8068:a6d with SMTP id d17-20020a170903231100b0014a80680a6dmr5337470plh.70.1642142643211; Thu, 13 Jan 2022 22:44:03 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id t3sm4821080pfj.137.2022.01.13.22.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 22:44:02 -0800 (PST) From: Miaoqian Lin To: Joel Stanley , Andrew Jeffery , "Chia-Wei, Wang" , Jae Hyun Yoo , Vernon Mauery , Miaoqian Lin , Dan Carpenter , Patrick Venture , Olof Johansson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq Date: Fri, 14 Jan 2022 06:43:55 +0000 Message-Id: <20220114064357.18562-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: 524feb799408 ("soc: add aspeed folder and misc drivers") Signed-off-by: Miaoqian Lin --- drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c index eceeaf8dfbeb..c4a03b3a5cf8 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) - return -ENODEV; + if (lpc_snoop->irq < 0) + return lpc_snoop->irq; rc = devm_request_irq(dev, lpc_snoop->irq, aspeed_lpc_snoop_irq, IRQF_SHARED, -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 728CDC433EF for ; Fri, 14 Jan 2022 06:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1fMJKeQ7kPOGDNzCI9/4fZB8wHvJnWnDjrRyfEO9NE8=; b=dH8OGxvR3joA2W GP1z8t2dXagQfNI0ovestdHyXdKpWB5Rfj1VGmVCjMCHAG59Cp79Z8Z/5ql7ivO2ZmpdyvuyHnDu+ O8OAXPD9ZKohSrDcZHCHXQsdvQx/BihAOJaCf8ACU6Er5BQjY6CbcKO1abObCqE+a+Rbg/HaROlMO 4ldgU1nJ4gJcXa/7OIMIbCRZhjfmgSXNwXh7I9/vadBBw+PPEg7Bh5cmNqQk7XwVq1MYMWos73ALi ZU1xL5N/nb6a74aiJRANY8tF2sKWgU/9THPxzAgCYFHtf7P4qZ7LTf4uEeQXGIqgladVQIcVG64zQ SZTWJrtzbOe/gBvlQezA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8GJj-007wuO-LU; Fri, 14 Jan 2022 06:44:07 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8GJg-007wtp-M6 for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 06:44:05 +0000 Received: by mail-pl1-x62d.google.com with SMTP id c3so12523752pls.5 for ; Thu, 13 Jan 2022 22:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=1Nv9cBoTms/HAwsSMh+lrTCJcZ3jwJC/miP/N5++3LM=; b=Tfs4fl6qHMuuHwQcDMVPYoDo86+b2M9lggqTgT/Et6qTm+mmefqpHC7XMjUueEuNDH ZLBIFPSx2EzW8aK666d+lPVK0uR19prsak1BPbGBey9A5JC0XfvWz2x8OC31GQGBwr4z CzUXU7C0fjAB7f6pO7P+N0N5eFVlUGAlAW7EzgikuU5+Lfz1oxYdUcJnXSSl8txpUD0W 6OuodjwilZlkM6F2QZXyMbWHQ5RukOV7UZhjKfly4mxv12egYIebWd4A6PXsQSgfNtQa 85YmtLFr6EfoUAjw44BzIqJ29pwgt4TNN2dcHG3xxXEcPVH5JPQDprnXMs4mrGUwq3Ld p3Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=1Nv9cBoTms/HAwsSMh+lrTCJcZ3jwJC/miP/N5++3LM=; b=4Dxx5BRheopXTfDa0nHamdmt8Ffj6mmePPydx6OPpn/Arflh/75aB7HHfF1NU75gAc J+oU2yvEXLJjKfJxBZ0HOS0ADJeUYnOU0puFNzHFU0QLdsw6zEelqVCMPsBGRQGS+MOj s4e6F2OThuP0V2RNBarFRzWUF1njSzpQAwMjM9ehGfIqSZ9lbzaU1ZxO8ZrNDrPSJ8n+ X2FjbmvdnhnTcnLSMw6FPrK6lJSkjVU2kU0B5QU/aixaqMo4yKz1Px0NuVTJDLHWqgkw mmAfdS5O12ioIKjMVO1CgA/5bB+lAAtsYw1RiTX5VQFY9ao5vSAJpPXNJsnxMcSLFYlV JI3Q== X-Gm-Message-State: AOAM532YKYhR8OKpLNN2/QLIGnCgVxGDEdCpnnKoVkEGzwyUSFi1Zh3U I4QTsRitHptqBrufsqYSvD8= X-Google-Smtp-Source: ABdhPJyj9OUFs3Ifg7Q/foM4Lw4if60L1dh8TxGLGhtD4IOaR0ZdfzpiYGEpmw38sjPo4afyX6uhxA== X-Received: by 2002:a17:903:2311:b0:14a:8068:a6d with SMTP id d17-20020a170903231100b0014a80680a6dmr5337470plh.70.1642142643211; Thu, 13 Jan 2022 22:44:03 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id t3sm4821080pfj.137.2022.01.13.22.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 22:44:02 -0800 (PST) From: Miaoqian Lin To: Joel Stanley , Andrew Jeffery , "Chia-Wei, Wang" , Jae Hyun Yoo , Vernon Mauery , Miaoqian Lin , Dan Carpenter , Patrick Venture , Olof Johansson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq Date: Fri, 14 Jan 2022 06:43:55 +0000 Message-Id: <20220114064357.18562-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_224404_751488_F2D4338B X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: 524feb799408 ("soc: add aspeed folder and misc drivers") Signed-off-by: Miaoqian Lin --- drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c index eceeaf8dfbeb..c4a03b3a5cf8 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) - return -ENODEV; + if (lpc_snoop->irq < 0) + return lpc_snoop->irq; rc = devm_request_irq(dev, lpc_snoop->irq, aspeed_lpc_snoop_irq, IRQF_SHARED, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel