From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6E1C433FE for ; Fri, 14 Jan 2022 16:23:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243316AbiANQXN (ORCPT ); Fri, 14 Jan 2022 11:23:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243235AbiANQXL (ORCPT ); Fri, 14 Jan 2022 11:23:11 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C8FC061574; Fri, 14 Jan 2022 08:23:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 22FAE61F87; Fri, 14 Jan 2022 16:23:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D75BDC36AE5; Fri, 14 Jan 2022 16:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642177390; bh=8EEtbq135Y0w2OjVUTuJBP80ewEFZkVxYRnAxWNG0eY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G+MoEykL1Bzcf4w4AmXD+dX82/JB8pi55zC1aY+51movMZJ+fQNkqDJiNVLBeqaXK 66h8mj10pJnEMsA6EcLsz7bK+9zrJr73Aknmr80Wk5g5sbyfRb+cbAIbZdEgLdqNWH 3sgBSDZteg/GXq5TSfGLXRb/cimeHMgq17JkgyCsrAGc/fW4IMm5IjXknUz97qp1K/ JQEW+Kpy21DFQOGvcGI7kypMT707B7HmAfLHT+lmSdicfoXklTmnuY2hgT+6OsaZOV bUZ69y/0FBYanLA3SOuetWFb6qZv7vva5S9whhT5I3vqFJheVnSKeItWWBiWkAE4WW BjIFhvUDzN1HQ== Date: Fri, 14 Jan 2022 08:23:08 -0800 From: Jakub Kicinski To: Kai-Heng Feng Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, "David S. Miller" , Maxime Coquelin , Andrew Lunn , Heiner Kallweit , Russell King , Marek =?UTF-8?B?QmVow7pu?= , Ivan Bornyakov , Pali =?UTF-8?B?Um9ow6Fy?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware Message-ID: <20220114082308.76a5cca5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: References: <20220114040755.1314349-1-kai.heng.feng@canonical.com> <20220114040755.1314349-2-kai.heng.feng@canonical.com> <20220113203523.310e13d3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jan 2022 14:47:47 +0800 Kai-Heng Feng wrote: > > Coincidentally the first Marvell flag appears dead, nobody sets it: > > > > $ git grep MARVELL_PHY_M1145_FLAGS_RESISTANCE > > drivers/net/phy/marvell.c: if (phydev->dev_flags & MARVELL_PHY_M1145_FLAGS_RESISTANCE) { > > include/linux/marvell_phy.h:#define MARVELL_PHY_M1145_FLAGS_RESISTANCE 0x00000001 > > $ > > > > unless it's read from DT under different name or something. > > It was introduced by 95d21ff4c645 without any user. Should we keep it? Not unless someone explains that it's actually used somehow. Please post a patch once net-next opens. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5589EC433EF for ; Fri, 14 Jan 2022 16:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g+t/k7CKzUrjKTpkdh19vgnrTsUjCFptoREilQasY28=; b=mxUoYwZB2U42qf of937viPqmunzI/ahmSkeGLpr9mTdRML2OYAPXHuCOlmlbblHHuBWuJFh7YPGWWaDHYSwQAQl15pP /QGB56PAwjKI9JljgjdTcXsyHudPVzTeWlEmnS8TX1rT2bEbWHKs8+2Akw7W5vu4MTy3I/2jm4O6a Qhyz17+L/zHkW1Ljm8HuaUsZk2MxnsEfFmsDOpIuA0gCcuo0QzwZPFiqlJwEXqWWeNxaTkbxMOA7j 32NM0N0eDBA60IbGZcEUBfJJltKE+DT0EqvboGb+7Mm+Y/6JQ3Voyk1sYhTmUtjZpCIB7nTxwl/jh xnjvzIxSIk9EHQ4XFb4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8PMB-009jZT-C7; Fri, 14 Jan 2022 16:23:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8PM7-009jYy-NW for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 16:23:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 183CF61F85; Fri, 14 Jan 2022 16:23:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D75BDC36AE5; Fri, 14 Jan 2022 16:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642177390; bh=8EEtbq135Y0w2OjVUTuJBP80ewEFZkVxYRnAxWNG0eY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G+MoEykL1Bzcf4w4AmXD+dX82/JB8pi55zC1aY+51movMZJ+fQNkqDJiNVLBeqaXK 66h8mj10pJnEMsA6EcLsz7bK+9zrJr73Aknmr80Wk5g5sbyfRb+cbAIbZdEgLdqNWH 3sgBSDZteg/GXq5TSfGLXRb/cimeHMgq17JkgyCsrAGc/fW4IMm5IjXknUz97qp1K/ JQEW+Kpy21DFQOGvcGI7kypMT707B7HmAfLHT+lmSdicfoXklTmnuY2hgT+6OsaZOV bUZ69y/0FBYanLA3SOuetWFb6qZv7vva5S9whhT5I3vqFJheVnSKeItWWBiWkAE4WW BjIFhvUDzN1HQ== Date: Fri, 14 Jan 2022 08:23:08 -0800 From: Jakub Kicinski To: Kai-Heng Feng Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, "David S. Miller" , Maxime Coquelin , Andrew Lunn , Heiner Kallweit , Russell King , Marek =?UTF-8?B?QmVow7pu?= , Ivan Bornyakov , Pali =?UTF-8?B?Um9ow6Fy?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware Message-ID: <20220114082308.76a5cca5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: References: <20220114040755.1314349-1-kai.heng.feng@canonical.com> <20220114040755.1314349-2-kai.heng.feng@canonical.com> <20220113203523.310e13d3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_082311_842434_55E8AAF9 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 14 Jan 2022 14:47:47 +0800 Kai-Heng Feng wrote: > > Coincidentally the first Marvell flag appears dead, nobody sets it: > > > > $ git grep MARVELL_PHY_M1145_FLAGS_RESISTANCE > > drivers/net/phy/marvell.c: if (phydev->dev_flags & MARVELL_PHY_M1145_FLAGS_RESISTANCE) { > > include/linux/marvell_phy.h:#define MARVELL_PHY_M1145_FLAGS_RESISTANCE 0x00000001 > > $ > > > > unless it's read from DT under different name or something. > > It was introduced by 95d21ff4c645 without any user. Should we keep it? Not unless someone explains that it's actually used somehow. Please post a patch once net-next opens. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel