From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAB2C433EF for ; Fri, 14 Jan 2022 10:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240574AbiANKvF (ORCPT ); Fri, 14 Jan 2022 05:51:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbiANKvE (ORCPT ); Fri, 14 Jan 2022 05:51:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BBBBC061574; Fri, 14 Jan 2022 02:51:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0555561EDC; Fri, 14 Jan 2022 10:51:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43D30C36AEA; Fri, 14 Jan 2022 10:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642157463; bh=bwrKb5nAY1yxA7hO1VfpRRfXBzaaN35Y7HZsuMZ/sQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AroH/H9LPZJM5aRxed34qf1Wxr4EkTk9guDLhEoBlZWeTLfpwb4Vbw266zUyaf1UG iAaAgZU01LvZnWwimunky3+Z2UFB1OiVtLkrTW9pJiDC7F/eMJXZCPz210Q55U+ftv qLwPa6zLtdy+67nABXZ631xy0e8itMSmn2/nW9toG7FSDsuGSaE3q7frpa8Vt5xg9z BATbOHb+iSz08HU3nySD8uw6HxURgTAoJU5n3ucfTOASa0PdlJXd/qSyrK5CE/cks1 WWN6AOP4Xy+XHBLUsyCAtBLknQ8BaLBd77/43tQmniFddyyJNXITf+uhiX2bt5dVXw KVJppvIThR4wQ== Received: by pali.im (Postfix) id DF3EC7D1; Fri, 14 Jan 2022 11:51:00 +0100 (CET) Date: Fri, 14 Jan 2022 11:51:00 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stephen Boyd Cc: Gregory CLEMENT , Michael Turquette , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?B?QmVow7pu?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 0/6] serial: mvebu-uart: Support for higher baudrates Message-ID: <20220114105100.im6gmkt6fjl2aiwl@pali> References: <20210930095838.28145-1-pali@kernel.org> <20211103214209.azo2z3z4gy7aj5hu@pali> <87ee6bm9hn.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ee6bm9hn.fsf@BL-laptop> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stephen! On Friday 17 December 2021 18:23:00 Gregory CLEMENT wrote: > Hello Pali, > > > On Thursday 30 September 2021 11:58:32 Pali Rohár wrote: > >> This patch series add support for baudrates higher than 230400 on > >> Marvell Armada 37xx boards. > > > > Stephen, Gregory, are there any issues with this patch series? > > I am not found of these changes but let's apply it as I didn't take time > to do a better review. > > However I can't apply the dt part if the driver is not merged. Stephen, are there any issues with driver (non-DT) part changes in this patch series? If not, could you please merge them? This patch series is here on the list since September without any request for change... We would really like to see support for higher baudrates for Armada 3720 platforms in mainline kernel. > Gregory > > > If not, could you take them? > > > >> Changes in v7: > >> * fixed lint errors in yaml binding file > >> > >> Changes in v6: > >> * fixed yaml binding file and dts files > >> > >> Changes in v5: > >> * fixed yaml binding file > >> > >> Changes in v4: > >> * converted armada3700-uart-clock documentation to YAML > >> * split documentation changes into two commits: > >> - first which adds clock documentation > >> - second which updates UART documentation > >> > >> Changes in v3: > >> v3 is rebased on top of Linus master branch and all already applied patches > >> were dropped. There are no changes in patches itself since v2. > >> > >> Pali Rohár (6): > >> math64: New DIV_U64_ROUND_CLOSEST helper > >> serial: mvebu-uart: implement UART clock driver for configuring UART > >> base clock > >> dt-bindings: mvebu-uart: document DT bindings for > >> marvell,armada-3700-uart-clock > >> dt-bindings: mvebu-uart: update information about UART clock > >> arm64: dts: marvell: armada-37xx: add device node for UART clock and > >> use it > >> serial: mvebu-uart: implement support for baudrates higher than 230400 > >> > >> .../clock/marvell,armada-3700-uart-clock.yaml | 59 ++ > >> .../devicetree/bindings/serial/mvebu-uart.txt | 9 +- > >> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 14 +- > >> drivers/tty/serial/Kconfig | 1 + > >> drivers/tty/serial/mvebu-uart.c | 592 +++++++++++++++++- > >> include/linux/math64.h | 13 + > >> 6 files changed, 667 insertions(+), 21 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml > >> > >> -- > >> 2.20.1 > >> > > -- > Gregory Clement, Bootlin > Embedded Linux and Kernel engineering > http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E681AC433F5 for ; Fri, 14 Jan 2022 10:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5SXS4CNBDFRb74urDHSHBk+4wavu9Tj3wZAfjYPj3cA=; b=uTdgd9LvzBu5zk 9UamQg+hua23Wa7t2iuwd+syYMpuf2Hjh+gw9jrP661qqlnGoC+uFbhEojHXNBTRIkdNQez2sVFyA yAGStyQxoetf9jNCIMITi67DnbOfMETdqKKwLmYSsJUIUSttTuZFXNgO47o1No3/BS1AEPUR7prQQ EP5peR4p1uY9kCFuWyrmaFdnFRR+DHrfhR9Lzq0IbM3HcSFFDisBWJF7cC5/tzChv+rcMzJadk3Dn 1kTwcJ5WecLGhRKUgebhXrz2Qkv5Xm1XR68Weg6Wlujf1HW5DSTOHVeFu9SrdS6oIqi7IIywICqvQ mw+knM2Nx8z8NFR0Vxeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8KAp-008mc0-SS; Fri, 14 Jan 2022 10:51:12 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8KAl-008maH-GI for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 10:51:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5BEAB82595; Fri, 14 Jan 2022 10:51:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43D30C36AEA; Fri, 14 Jan 2022 10:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642157463; bh=bwrKb5nAY1yxA7hO1VfpRRfXBzaaN35Y7HZsuMZ/sQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AroH/H9LPZJM5aRxed34qf1Wxr4EkTk9guDLhEoBlZWeTLfpwb4Vbw266zUyaf1UG iAaAgZU01LvZnWwimunky3+Z2UFB1OiVtLkrTW9pJiDC7F/eMJXZCPz210Q55U+ftv qLwPa6zLtdy+67nABXZ631xy0e8itMSmn2/nW9toG7FSDsuGSaE3q7frpa8Vt5xg9z BATbOHb+iSz08HU3nySD8uw6HxURgTAoJU5n3ucfTOASa0PdlJXd/qSyrK5CE/cks1 WWN6AOP4Xy+XHBLUsyCAtBLknQ8BaLBd77/43tQmniFddyyJNXITf+uhiX2bt5dVXw KVJppvIThR4wQ== Received: by pali.im (Postfix) id DF3EC7D1; Fri, 14 Jan 2022 11:51:00 +0100 (CET) Date: Fri, 14 Jan 2022 11:51:00 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stephen Boyd Cc: Gregory CLEMENT , Michael Turquette , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?B?QmVow7pu?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 0/6] serial: mvebu-uart: Support for higher baudrates Message-ID: <20220114105100.im6gmkt6fjl2aiwl@pali> References: <20210930095838.28145-1-pali@kernel.org> <20211103214209.azo2z3z4gy7aj5hu@pali> <87ee6bm9hn.fsf@BL-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87ee6bm9hn.fsf@BL-laptop> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_025107_871086_01B4BB69 X-CRM114-Status: GOOD ( 28.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gU3RlcGhlbiEKCk9uIEZyaWRheSAxNyBEZWNlbWJlciAyMDIxIDE4OjIzOjAwIEdyZWdv cnkgQ0xFTUVOVCB3cm90ZToKPiBIZWxsbyBQYWxpLAo+IAo+ID4gT24gVGh1cnNkYXkgMzAgU2Vw dGVtYmVyIDIwMjEgMTE6NTg6MzIgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gPj4gVGhpcyBwYXRjaCBz ZXJpZXMgYWRkIHN1cHBvcnQgZm9yIGJhdWRyYXRlcyBoaWdoZXIgdGhhbiAyMzA0MDAgb24KPiA+ PiBNYXJ2ZWxsIEFybWFkYSAzN3h4IGJvYXJkcy4KPiA+Cj4gPiBTdGVwaGVuLCBHcmVnb3J5LCBh cmUgdGhlcmUgYW55IGlzc3VlcyB3aXRoIHRoaXMgcGF0Y2ggc2VyaWVzPwo+IAo+IEkgYW0gbm90 IGZvdW5kIG9mIHRoZXNlIGNoYW5nZXMgYnV0IGxldCdzIGFwcGx5IGl0IGFzIEkgZGlkbid0IHRh a2UgdGltZQo+IHRvIGRvIGEgYmV0dGVyIHJldmlldy4KPiAKPiBIb3dldmVyIEkgY2FuJ3QgYXBw bHkgdGhlIGR0IHBhcnQgaWYgdGhlIGRyaXZlciBpcyBub3QgbWVyZ2VkLgoKU3RlcGhlbiwgYXJl IHRoZXJlIGFueSBpc3N1ZXMgd2l0aCBkcml2ZXIgKG5vbi1EVCkgcGFydCBjaGFuZ2VzIGluIHRo aXMKcGF0Y2ggc2VyaWVzPyBJZiBub3QsIGNvdWxkIHlvdSBwbGVhc2UgbWVyZ2UgdGhlbT8gVGhp cyBwYXRjaCBzZXJpZXMgaXMKaGVyZSBvbiB0aGUgbGlzdCBzaW5jZSBTZXB0ZW1iZXIgd2l0aG91 dCBhbnkgcmVxdWVzdCBmb3IgY2hhbmdlLi4uCgpXZSB3b3VsZCByZWFsbHkgbGlrZSB0byBzZWUg c3VwcG9ydCBmb3IgaGlnaGVyIGJhdWRyYXRlcyBmb3IgQXJtYWRhIDM3MjAKcGxhdGZvcm1zIGlu IG1haW5saW5lIGtlcm5lbC4KCj4gR3JlZ29yeQo+IAo+ID4gSWYgbm90LCBjb3VsZCB5b3UgdGFr ZSB0aGVtPwo+ID4KPiA+PiBDaGFuZ2VzIGluIHY3Ogo+ID4+ICogZml4ZWQgbGludCBlcnJvcnMg aW4geWFtbCBiaW5kaW5nIGZpbGUKPiA+PiAKPiA+PiBDaGFuZ2VzIGluIHY2Ogo+ID4+ICogZml4 ZWQgeWFtbCBiaW5kaW5nIGZpbGUgYW5kIGR0cyBmaWxlcwo+ID4+IAo+ID4+IENoYW5nZXMgaW4g djU6Cj4gPj4gKiBmaXhlZCB5YW1sIGJpbmRpbmcgZmlsZQo+ID4+IAo+ID4+IENoYW5nZXMgaW4g djQ6Cj4gPj4gKiBjb252ZXJ0ZWQgYXJtYWRhMzcwMC11YXJ0LWNsb2NrIGRvY3VtZW50YXRpb24g dG8gWUFNTAo+ID4+ICogc3BsaXQgZG9jdW1lbnRhdGlvbiBjaGFuZ2VzIGludG8gdHdvIGNvbW1p dHM6Cj4gPj4gICAtIGZpcnN0IHdoaWNoIGFkZHMgY2xvY2sgZG9jdW1lbnRhdGlvbgo+ID4+ICAg LSBzZWNvbmQgd2hpY2ggdXBkYXRlcyBVQVJUIGRvY3VtZW50YXRpb24KPiA+PiAKPiA+PiBDaGFu Z2VzIGluIHYzOgo+ID4+IHYzIGlzIHJlYmFzZWQgb24gdG9wIG9mIExpbnVzIG1hc3RlciBicmFu Y2ggYW5kIGFsbCBhbHJlYWR5IGFwcGxpZWQgcGF0Y2hlcwo+ID4+IHdlcmUgZHJvcHBlZC4gVGhl cmUgYXJlIG5vIGNoYW5nZXMgaW4gcGF0Y2hlcyBpdHNlbGYgc2luY2UgdjIuCj4gPj4gCj4gPj4g UGFsaSBSb2jDoXIgKDYpOgo+ID4+ICAgbWF0aDY0OiBOZXcgRElWX1U2NF9ST1VORF9DTE9TRVNU IGhlbHBlcgo+ID4+ICAgc2VyaWFsOiBtdmVidS11YXJ0OiBpbXBsZW1lbnQgVUFSVCBjbG9jayBk cml2ZXIgZm9yIGNvbmZpZ3VyaW5nIFVBUlQKPiA+PiAgICAgYmFzZSBjbG9jawo+ID4+ICAgZHQt YmluZGluZ3M6IG12ZWJ1LXVhcnQ6IGRvY3VtZW50IERUIGJpbmRpbmdzIGZvcgo+ID4+ICAgICBt YXJ2ZWxsLGFybWFkYS0zNzAwLXVhcnQtY2xvY2sKPiA+PiAgIGR0LWJpbmRpbmdzOiBtdmVidS11 YXJ0OiB1cGRhdGUgaW5mb3JtYXRpb24gYWJvdXQgVUFSVCBjbG9jawo+ID4+ICAgYXJtNjQ6IGR0 czogbWFydmVsbDogYXJtYWRhLTM3eHg6IGFkZCBkZXZpY2Ugbm9kZSBmb3IgVUFSVCBjbG9jayBh bmQKPiA+PiAgICAgdXNlIGl0Cj4gPj4gICBzZXJpYWw6IG12ZWJ1LXVhcnQ6IGltcGxlbWVudCBz dXBwb3J0IGZvciBiYXVkcmF0ZXMgaGlnaGVyIHRoYW4gMjMwNDAwCj4gPj4gCj4gPj4gIC4uLi9j bG9jay9tYXJ2ZWxsLGFybWFkYS0zNzAwLXVhcnQtY2xvY2sueWFtbCB8ICA1OSArKwo+ID4+ICAu Li4vZGV2aWNldHJlZS9iaW5kaW5ncy9zZXJpYWwvbXZlYnUtdWFydC50eHQgfCAgIDkgKy0KPiA+ PiAgYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kgIHwgIDE0ICst Cj4gPj4gIGRyaXZlcnMvdHR5L3NlcmlhbC9LY29uZmlnICAgICAgICAgICAgICAgICAgICB8ICAg MSArCj4gPj4gIGRyaXZlcnMvdHR5L3NlcmlhbC9tdmVidS11YXJ0LmMgICAgICAgICAgICAgICB8 IDU5MiArKysrKysrKysrKysrKysrKy0KPiA+PiAgaW5jbHVkZS9saW51eC9tYXRoNjQuaCAgICAg ICAgICAgICAgICAgICAgICAgIHwgIDEzICsKPiA+PiAgNiBmaWxlcyBjaGFuZ2VkLCA2NjcgaW5z ZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4gPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svbWFydmVsbCxhcm1hZGEtMzcwMC11 YXJ0LWNsb2NrLnlhbWwKPiA+PiAKPiA+PiAtLSAKPiA+PiAyLjIwLjEKPiA+PiAKPiAKPiAtLSAK PiBHcmVnb3J5IENsZW1lbnQsIEJvb3RsaW4KPiBFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVu Z2luZWVyaW5nCj4gaHR0cDovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==