From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v7 05/25] trace-cmd library: Add internal helper function for writing headers before file sections
Date: Sat, 15 Jan 2022 07:58:56 -0500 [thread overview]
Message-ID: <20220115075856.7c5f325d@rorschach.local.home> (raw)
In-Reply-To: <20211210105448.97850-6-tz.stoyanov@gmail.com>
On Fri, 10 Dec 2021 12:54:28 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> Introduce headers before each file section, in trace file version 7. The
> section header has the following format:
> <2 bytes>, header ID
> <4 bytes>, offset within the strings section, where the section
> description string is located.
> <2 bytes>, section flags:
> 1: the section is compressed
Would in make more sense to have the ID and flags together, followed by
the string? That way you could use a normal structure to represent it.
struct {
unsigned short id;
unsigned short flags;
unsigned int string_offset;
unsigned long long size;
};
Otherwise, all tools to read it will be forced to read each part
individually. I can imaging that being annoying in the future.
-- Steve
> <8 bytes>, size of the section
>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
> ---
next prev parent reply other threads:[~2022-01-15 12:59 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 10:54 [PATCH v7 00/25] Trace file version 7 - sections Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 01/25] trace-cmd library: Define trace file version 7 Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 02/25] trace-cmd library: Add cache functionality to network message handler Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 03/25] trace-cmd library: New APIs to get and set version of output handler Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 04/25] trace-cmd library: Add strings section in trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-15 12:53 ` Steven Rostedt
2022-01-17 9:32 ` Tzvetomir Stoyanov
2022-01-17 14:40 ` Steven Rostedt
2022-01-17 14:44 ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 05/25] trace-cmd library: Add internal helper function for writing headers before file sections Tzvetomir Stoyanov (VMware)
2022-01-15 12:58 ` Steven Rostedt [this message]
2022-01-17 10:08 ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 06/25] trace-cmd library: Write header " Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 07/25] trace-cmd library: Add multiple options sections in trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-15 14:57 ` Steven Rostedt
2022-01-17 17:12 ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 08/25] trace-cmd library: Do not write CPU count section in trace files " Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 09/25] trace-cmd library: Move CPU flyrecord trace metadata into the buffer option, for trace file " Tzvetomir Stoyanov (VMware)
2022-01-15 15:12 ` Steven Rostedt
2022-01-17 13:43 ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 10/25] trace-cmd library: Add section header before flyrecord trace data Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 11/25] trace-cmd library: Fit CPU latency trace data in the new trace file version 7 format Tzvetomir Stoyanov (VMware)
2022-01-15 15:20 ` Steven Rostedt
2022-01-17 14:11 ` Tzvetomir Stoyanov
2021-12-10 10:54 ` [PATCH v7 12/25] trace-cmd library: Add macro to check file state on reading Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 13/25] trace-cmd library: Introduce sections in trace file reading logic Tzvetomir Stoyanov (VMware)
2022-01-15 15:27 ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 14/25] trace-cmd library: Initialize internal sections database on file read Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 15/25] trace-cmd library: Use sections database when reading parts of the trace file Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 16/25] trace-cmd library: Read headers from trace file version 7 Tzvetomir Stoyanov (VMware)
2022-01-15 15:59 ` Steven Rostedt
2022-01-17 15:47 ` Tzvetomir Stoyanov
2022-01-17 16:17 ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 17/25] trace-cmd library: Read strings sections on file load Tzvetomir Stoyanov (VMware)
2022-01-15 16:04 ` Steven Rostedt
2022-01-17 16:11 ` Tzvetomir Stoyanov
2022-01-17 16:18 ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 18/25] trace-cmd library: Read extended BUFFER option Tzvetomir Stoyanov (VMware)
2022-01-15 16:10 ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 19/25] trace-cmd library: Handle the extended DONE option Tzvetomir Stoyanov (VMware)
2022-01-15 16:12 ` Steven Rostedt
2021-12-10 10:54 ` [PATCH v7 20/25] trace-cmd library: Initialize CPU data for reading from version 7 trace files Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 21/25] trace-cmd library: Handle latency trace in version 7 files Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 22/25] trace-cmd library: Handle buffer trace data init for " Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 23/25] trace-cmd report: Use the new latency API to read data Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 24/25] trace-cmd: Write buffers metadata in trace files version 6 Tzvetomir Stoyanov (VMware)
2021-12-10 10:54 ` [PATCH v7 25/25] trace-cmd report: Add new parameter for trace file version Tzvetomir Stoyanov (VMware)
2022-01-15 16:20 ` Steven Rostedt
2022-01-15 16:21 ` [PATCH v7 00/25] Trace file version 7 - sections Steven Rostedt
2022-01-17 9:03 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115075856.7c5f325d@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.