From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E5D0C433EF for ; Sat, 15 Jan 2022 12:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230422AbiAOM0Z (ORCPT ); Sat, 15 Jan 2022 07:26:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiAOM0Y (ORCPT ); Sat, 15 Jan 2022 07:26:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDFA6C061574; Sat, 15 Jan 2022 04:26:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B0036B801C1; Sat, 15 Jan 2022 12:26:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C935C36AE3; Sat, 15 Jan 2022 12:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642249581; bh=kIRhRIhmHyuVtgrFBJFVRrB2x5jOVI1sMyRQaoKjuHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oHy6IDmtSBRLvfge/vX9jilP//1kEu+ZdhBSP01xtYy42Yk7lNr3bj13r5ua3Sfe9 vOCmFkfoB2z/qmZH0Pj3lf77sBOblIzSBaFIAag/A+XTYKLp+jwdT/QC3Xz3aV7rTy 75NLTwEf79Wzt7g/l3L1dcgC/ulGPjj3jDZVqBGRMFkzkGDo2XYrZixaJSOHwFYdXU AEuqH2J6bNZhHpsVu1kBKJpfqNVpBX6H6g0r5Y5sk4P4WsM3uTsgivye3POwKTnxge 2K7CeyJGwToomw9BUhxeHZJ6hsOV8dsmBJ5ZSxTgCyhZh7O2koBvjaivFGRI7xzKiz QDgSDTkj2Vxpg== Received: by pali.im (Postfix) id 85C1486D; Sat, 15 Jan 2022 13:26:18 +0100 (CET) Date: Sat, 15 Jan 2022 13:26:18 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Rob Herring , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Message-ID: <20220115122618.plhiqnjh2755bv5h@pali> References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-4-pali@kernel.org> <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com> <20211015090937.gnt66hgugrhwnkei@pali> <20211015093701.pfvkighxsndj4ujg@pali> <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> <20211016064210.7ahqfqcvf66wtt66@pali> <20220115080213.0CCAFC36AE3@smtp.kernel.org> <20220115115018.he4hnnhlvrb6kann@pali> <20220115130509.4a240730@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220115130509.4a240730@thinkpad> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 15 January 2022 13:05:09 Marek Behún wrote: > On Sat, 15 Jan 2022 12:50:18 +0100 > Pali Rohár wrote: > > > On Saturday 15 January 2022 00:02:11 Stephen Boyd wrote: > > > Quoting Pali Rohár (2021-10-15 23:42:10) > > > > > > > > If I was designing this driver and DTS bindings I would have choose > > > > something like this: > > > > > > > > uart@0x12000 { > > > > > > Drop the 0x > > > > > > > reg = <0x12000 0x18>, <0x12200 0x30>; > > > > clock-controller { > > > > ... > > > > }; > > > > > > Drop this node and put whatever properties are inside into the parent > > > node. > > > > > > > serial1 { > > > > ... > > > > status = "disabled"; > > > > }; > > > > serial2 { > > > > ... > > > > status = "disabled"; > > > > }; > > > > }; > > > > > > > > Meaning that 0x12000 node would be 3 subnodes and all registers would be > > > > defined in top level nodes and would be handled by one driver. > > > > > > > > This is really how hardware block looks like. But it is not backward > > > > compatible... > > > > > > Sounds good to me. I presume we need the serial child nodes so we can > > > reference them from the stdout-path? > > > > Yes, exactly, separate nodes for serial1 and serial2 are still required. > > > > But dropping clock controller is not possible as for higher baudrates we > > need to use and configure uart clock controller. Without it we just get > > comparable feature support which is already present in driver. > > What Stephen means is making clock controller out of the uart node > directly. No need to add separate subnode just for clock controller. This is already implemented in v7 patch series. Clock controller is already outside of uart nodes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86F27C433F5 for ; Sat, 15 Jan 2022 12:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y6DSWF77qE5Ki3il5kpqYNud9wP828a6pORwcu+aNVk=; b=xsTOYa6YlBEO3h zx8sbjxK5duAH3so2KQ0RQByno9VHSC02ym9xjM30KKap76tox7gDw4O9IInxTXekbQXcS76cNRMt W725OnIWNm4K4nuzQElN/6iW+ssQEgqB7cXGwEZcFIXnyoJxfc2qmqfZmqOZLgPuMbZSZXVWB/cO8 Js2Fgu/4tkuwgZpng3FR0NWFVObgm2MLLmJoIrqSNvXm5bDLud6qFuIzw3CJwRc3mJuNsbLDyq9Rq wGnH5cYmIIMrUdFMCtWf1QnAyeCZ5mRyqyAsbAVkZOpfr5Xjnv8wNQJDteiwQiePc8im9xr2ECm+y VYkOYENZ0sCQSk5AoSig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8i8Z-00B29X-Hq; Sat, 15 Jan 2022 12:26:27 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8i8V-00B299-TG for linux-arm-kernel@lists.infradead.org; Sat, 15 Jan 2022 12:26:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81E59B80122; Sat, 15 Jan 2022 12:26:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C935C36AE3; Sat, 15 Jan 2022 12:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642249581; bh=kIRhRIhmHyuVtgrFBJFVRrB2x5jOVI1sMyRQaoKjuHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oHy6IDmtSBRLvfge/vX9jilP//1kEu+ZdhBSP01xtYy42Yk7lNr3bj13r5ua3Sfe9 vOCmFkfoB2z/qmZH0Pj3lf77sBOblIzSBaFIAag/A+XTYKLp+jwdT/QC3Xz3aV7rTy 75NLTwEf79Wzt7g/l3L1dcgC/ulGPjj3jDZVqBGRMFkzkGDo2XYrZixaJSOHwFYdXU AEuqH2J6bNZhHpsVu1kBKJpfqNVpBX6H6g0r5Y5sk4P4WsM3uTsgivye3POwKTnxge 2K7CeyJGwToomw9BUhxeHZJ6hsOV8dsmBJ5ZSxTgCyhZh7O2koBvjaivFGRI7xzKiz QDgSDTkj2Vxpg== Received: by pali.im (Postfix) id 85C1486D; Sat, 15 Jan 2022 13:26:18 +0100 (CET) Date: Sat, 15 Jan 2022 13:26:18 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Rob Herring , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Message-ID: <20220115122618.plhiqnjh2755bv5h@pali> References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-4-pali@kernel.org> <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com> <20211015090937.gnt66hgugrhwnkei@pali> <20211015093701.pfvkighxsndj4ujg@pali> <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> <20211016064210.7ahqfqcvf66wtt66@pali> <20220115080213.0CCAFC36AE3@smtp.kernel.org> <20220115115018.he4hnnhlvrb6kann@pali> <20220115130509.4a240730@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220115130509.4a240730@thinkpad> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220115_042624_261342_B5A0631B X-CRM114-Status: GOOD ( 25.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0dXJkYXkgMTUgSmFudWFyeSAyMDIyIDEzOjA1OjA5IE1hcmVrIEJlaMO6biB3cm90ZToK PiBPbiBTYXQsIDE1IEphbiAyMDIyIDEyOjUwOjE4ICswMTAwCj4gUGFsaSBSb2jDoXIgPHBhbGlA a2VybmVsLm9yZz4gd3JvdGU6Cj4gCj4gPiBPbiBTYXR1cmRheSAxNSBKYW51YXJ5IDIwMjIgMDA6 MDI6MTEgU3RlcGhlbiBCb3lkIHdyb3RlOgo+ID4gPiBRdW90aW5nIFBhbGkgUm9ow6FyICgyMDIx LTEwLTE1IDIzOjQyOjEwKSAgCj4gPiA+ID4gCj4gPiA+ID4gSWYgSSB3YXMgZGVzaWduaW5nIHRo aXMgZHJpdmVyIGFuZCBEVFMgYmluZGluZ3MgSSB3b3VsZCBoYXZlIGNob29zZQo+ID4gPiA+IHNv bWV0aGluZyBsaWtlIHRoaXM6Cj4gPiA+ID4gCj4gPiA+ID4gdWFydEAweDEyMDAwIHsgIAo+ID4g PiAKPiA+ID4gRHJvcCB0aGUgMHgKPiA+ID4gICAKPiA+ID4gPiAgICAgcmVnID0gPDB4MTIwMDAg MHgxOD4sIDwweDEyMjAwIDB4MzA+Owo+ID4gPiA+ICAgICBjbG9jay1jb250cm9sbGVyIHsKPiA+ ID4gPiAgICAgICAgIC4uLgo+ID4gPiA+ICAgICB9OyAgCj4gPiA+IAo+ID4gPiBEcm9wIHRoaXMg bm9kZSBhbmQgcHV0IHdoYXRldmVyIHByb3BlcnRpZXMgYXJlIGluc2lkZSBpbnRvIHRoZSBwYXJl bnQKPiA+ID4gbm9kZS4KPiA+ID4gICAKPiA+ID4gPiAgICAgc2VyaWFsMSB7Cj4gPiA+ID4gICAg ICAgICAuLi4KPiA+ID4gPiAgICAgICAgIHN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gPiA+ID4gICAg IH07Cj4gPiA+ID4gICAgIHNlcmlhbDIgewo+ID4gPiA+ICAgICAgICAgLi4uCj4gPiA+ID4gICAg ICAgICBzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ID4gPiA+ICAgICB9Owo+ID4gPiA+IH07Cj4gPiA+ ID4gCj4gPiA+ID4gTWVhbmluZyB0aGF0IDB4MTIwMDAgbm9kZSB3b3VsZCBiZSAzIHN1Ym5vZGVz IGFuZCBhbGwgcmVnaXN0ZXJzIHdvdWxkIGJlCj4gPiA+ID4gZGVmaW5lZCBpbiB0b3AgbGV2ZWwg bm9kZXMgYW5kIHdvdWxkIGJlIGhhbmRsZWQgYnkgb25lIGRyaXZlci4KPiA+ID4gPiAKPiA+ID4g PiBUaGlzIGlzIHJlYWxseSBob3cgaGFyZHdhcmUgYmxvY2sgbG9va3MgbGlrZS4gQnV0IGl0IGlz IG5vdCBiYWNrd2FyZAo+ID4gPiA+IGNvbXBhdGlibGUuLi4gIAo+ID4gPiAKPiA+ID4gU291bmRz IGdvb2QgdG8gbWUuIEkgcHJlc3VtZSB3ZSBuZWVkIHRoZSBzZXJpYWwgY2hpbGQgbm9kZXMgc28g d2UgY2FuCj4gPiA+IHJlZmVyZW5jZSB0aGVtIGZyb20gdGhlIHN0ZG91dC1wYXRoPyAgCj4gPiAK PiA+IFllcywgZXhhY3RseSwgc2VwYXJhdGUgbm9kZXMgZm9yIHNlcmlhbDEgYW5kIHNlcmlhbDIg YXJlIHN0aWxsIHJlcXVpcmVkLgo+ID4gCj4gPiBCdXQgZHJvcHBpbmcgY2xvY2sgY29udHJvbGxl ciBpcyBub3QgcG9zc2libGUgYXMgZm9yIGhpZ2hlciBiYXVkcmF0ZXMgd2UKPiA+IG5lZWQgdG8g dXNlIGFuZCBjb25maWd1cmUgdWFydCBjbG9jayBjb250cm9sbGVyLiBXaXRob3V0IGl0IHdlIGp1 c3QgZ2V0Cj4gPiBjb21wYXJhYmxlIGZlYXR1cmUgc3VwcG9ydCB3aGljaCBpcyBhbHJlYWR5IHBy ZXNlbnQgaW4gZHJpdmVyLgo+IAo+IFdoYXQgU3RlcGhlbiBtZWFucyBpcyBtYWtpbmcgY2xvY2sg Y29udHJvbGxlciBvdXQgb2YgdGhlIHVhcnQgbm9kZQo+IGRpcmVjdGx5LiBObyBuZWVkIHRvIGFk ZCBzZXBhcmF0ZSBzdWJub2RlIGp1c3QgZm9yIGNsb2NrIGNvbnRyb2xsZXIuCgpUaGlzIGlzIGFs cmVhZHkgaW1wbGVtZW50ZWQgaW4gdjcgcGF0Y2ggc2VyaWVzLiBDbG9jayBjb250cm9sbGVyIGlz CmFscmVhZHkgb3V0c2lkZSBvZiB1YXJ0IG5vZGVzLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=