From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D42AC433FE for ; Sat, 15 Jan 2022 12:05:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbiAOMFV (ORCPT ); Sat, 15 Jan 2022 07:05:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiAOMFU (ORCPT ); Sat, 15 Jan 2022 07:05:20 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930CFC061574; Sat, 15 Jan 2022 04:05:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 33257B800E2; Sat, 15 Jan 2022 12:05:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B253C36AE3; Sat, 15 Jan 2022 12:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642248317; bh=2IT+FQbGuQK8tZVADwQ/U1hJPKJDewZokL/75ySxy4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nJmsxeN7eNg6Ht9L7sZ3312fAX5DCZ1KMwL3ZBGk8jEx8f/Ja8iNyqGLzj5MRf5am 4eZT/c4qBEzaHmM1uPQKbhOcBwubWTMbGp4O60vgXW9PG/zhEclq23u8s71gW5aeMU KS1pFEWbuY6KJr4qcrf/vixin9sTripjkHQfSuDJcj8vSb6iAsE2WttJ8k2xLhlbwv n3ToJD949Y3oFqtC0hmVzm6CMqNcq+U45mED9RwDJa1xQg1mnj3fogFxeKjX+vsGfP JOAn2JbFDwMw9lom5c8EpxT/Bh7MlGRnAyCD8QLqpgRqMSat12f/62FVUbt01+A144 AcpmpKHl+p3Ug== Date: Sat, 15 Jan 2022 13:05:09 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Rob Herring , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Message-ID: <20220115130509.4a240730@thinkpad> In-Reply-To: <20220115115018.he4hnnhlvrb6kann@pali> References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-4-pali@kernel.org> <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com> <20211015090937.gnt66hgugrhwnkei@pali> <20211015093701.pfvkighxsndj4ujg@pali> <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> <20211016064210.7ahqfqcvf66wtt66@pali> <20220115080213.0CCAFC36AE3@smtp.kernel.org> <20220115115018.he4hnnhlvrb6kann@pali> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 15 Jan 2022 12:50:18 +0100 Pali Roh=C3=A1r wrote: > On Saturday 15 January 2022 00:02:11 Stephen Boyd wrote: > > Quoting Pali Roh=C3=A1r (2021-10-15 23:42:10) =20 > > >=20 > > > If I was designing this driver and DTS bindings I would have choose > > > something like this: > > >=20 > > > uart@0x12000 { =20 > >=20 > > Drop the 0x > > =20 > > > reg =3D <0x12000 0x18>, <0x12200 0x30>; > > > clock-controller { > > > ... > > > }; =20 > >=20 > > Drop this node and put whatever properties are inside into the parent > > node. > > =20 > > > serial1 { > > > ... > > > status =3D "disabled"; > > > }; > > > serial2 { > > > ... > > > status =3D "disabled"; > > > }; > > > }; > > >=20 > > > Meaning that 0x12000 node would be 3 subnodes and all registers would= be > > > defined in top level nodes and would be handled by one driver. > > >=20 > > > This is really how hardware block looks like. But it is not backward > > > compatible... =20 > >=20 > > Sounds good to me. I presume we need the serial child nodes so we can > > reference them from the stdout-path? =20 >=20 > Yes, exactly, separate nodes for serial1 and serial2 are still required. >=20 > But dropping clock controller is not possible as for higher baudrates we > need to use and configure uart clock controller. Without it we just get > comparable feature support which is already present in driver. What Stephen means is making clock controller out of the uart node directly. No need to add separate subnode just for clock controller. Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BD47C433EF for ; Sat, 15 Jan 2022 12:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kR4sQhzJJtWSZsnr0VvpIFxPgbd65hRKGLbivbj/3vw=; b=JMzH3JIetreP/0 iKkeVE3TibIftdN8Dx4cZQxq+5ZTu3USw3to/YEYysSiuGuIXo67vsHaOY/Yrf2ePIvQy/xhT4myc 601sUt0ljc7xLJ5FbLNLVmKN8itYGTImOXUtG1+d0yEX17yTZRuE/St3FhC5tIB7ZkktZT5Yp741I XIY9Yf4ftOd2bsJTD40uSkrZY70Wmx79A4CzNizNVkH7WNmiAnz1qtGCE6hzXUO5+Cy3Dx/aBNWC7 cRDzrFIR8aSNAABn0rtomOFBj9fz7KJllM64TGREGkPML02txCiwRWUUInK+bQiSvoYdzo0SlRA58 D5YLtwDnxmgW8nseQxGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8hoA-00B0ty-TT; Sat, 15 Jan 2022 12:05:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8ho6-00B0te-OH for linux-arm-kernel@lists.infradead.org; Sat, 15 Jan 2022 12:05:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E42960C5B; Sat, 15 Jan 2022 12:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B253C36AE3; Sat, 15 Jan 2022 12:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642248317; bh=2IT+FQbGuQK8tZVADwQ/U1hJPKJDewZokL/75ySxy4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nJmsxeN7eNg6Ht9L7sZ3312fAX5DCZ1KMwL3ZBGk8jEx8f/Ja8iNyqGLzj5MRf5am 4eZT/c4qBEzaHmM1uPQKbhOcBwubWTMbGp4O60vgXW9PG/zhEclq23u8s71gW5aeMU KS1pFEWbuY6KJr4qcrf/vixin9sTripjkHQfSuDJcj8vSb6iAsE2WttJ8k2xLhlbwv n3ToJD949Y3oFqtC0hmVzm6CMqNcq+U45mED9RwDJa1xQg1mnj3fogFxeKjX+vsGfP JOAn2JbFDwMw9lom5c8EpxT/Bh7MlGRnAyCD8QLqpgRqMSat12f/62FVUbt01+A144 AcpmpKHl+p3Ug== Date: Sat, 15 Jan 2022 13:05:09 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Rob Herring , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Message-ID: <20220115130509.4a240730@thinkpad> In-Reply-To: <20220115115018.he4hnnhlvrb6kann@pali> References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-4-pali@kernel.org> <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com> <20211015090937.gnt66hgugrhwnkei@pali> <20211015093701.pfvkighxsndj4ujg@pali> <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> <20211016064210.7ahqfqcvf66wtt66@pali> <20220115080213.0CCAFC36AE3@smtp.kernel.org> <20220115115018.he4hnnhlvrb6kann@pali> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220115_040518_916295_650939A0 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAxNSBKYW4gMjAyMiAxMjo1MDoxOCArMDEwMApQYWxpIFJvaMOhciA8cGFsaUBrZXJu ZWwub3JnPiB3cm90ZToKCj4gT24gU2F0dXJkYXkgMTUgSmFudWFyeSAyMDIyIDAwOjAyOjExIFN0 ZXBoZW4gQm95ZCB3cm90ZToKPiA+IFF1b3RpbmcgUGFsaSBSb2jDoXIgKDIwMjEtMTAtMTUgMjM6 NDI6MTApICAKPiA+ID4gCj4gPiA+IElmIEkgd2FzIGRlc2lnbmluZyB0aGlzIGRyaXZlciBhbmQg RFRTIGJpbmRpbmdzIEkgd291bGQgaGF2ZSBjaG9vc2UKPiA+ID4gc29tZXRoaW5nIGxpa2UgdGhp czoKPiA+ID4gCj4gPiA+IHVhcnRAMHgxMjAwMCB7ICAKPiA+IAo+ID4gRHJvcCB0aGUgMHgKPiA+ ICAgCj4gPiA+ICAgICByZWcgPSA8MHgxMjAwMCAweDE4PiwgPDB4MTIyMDAgMHgzMD47Cj4gPiA+ ICAgICBjbG9jay1jb250cm9sbGVyIHsKPiA+ID4gICAgICAgICAuLi4KPiA+ID4gICAgIH07ICAK PiA+IAo+ID4gRHJvcCB0aGlzIG5vZGUgYW5kIHB1dCB3aGF0ZXZlciBwcm9wZXJ0aWVzIGFyZSBp bnNpZGUgaW50byB0aGUgcGFyZW50Cj4gPiBub2RlLgo+ID4gICAKPiA+ID4gICAgIHNlcmlhbDEg ewo+ID4gPiAgICAgICAgIC4uLgo+ID4gPiAgICAgICAgIHN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4g PiA+ICAgICB9Owo+ID4gPiAgICAgc2VyaWFsMiB7Cj4gPiA+ICAgICAgICAgLi4uCj4gPiA+ICAg ICAgICAgc3RhdHVzID0gImRpc2FibGVkIjsKPiA+ID4gICAgIH07Cj4gPiA+IH07Cj4gPiA+IAo+ ID4gPiBNZWFuaW5nIHRoYXQgMHgxMjAwMCBub2RlIHdvdWxkIGJlIDMgc3Vibm9kZXMgYW5kIGFs bCByZWdpc3RlcnMgd291bGQgYmUKPiA+ID4gZGVmaW5lZCBpbiB0b3AgbGV2ZWwgbm9kZXMgYW5k IHdvdWxkIGJlIGhhbmRsZWQgYnkgb25lIGRyaXZlci4KPiA+ID4gCj4gPiA+IFRoaXMgaXMgcmVh bGx5IGhvdyBoYXJkd2FyZSBibG9jayBsb29rcyBsaWtlLiBCdXQgaXQgaXMgbm90IGJhY2t3YXJk Cj4gPiA+IGNvbXBhdGlibGUuLi4gIAo+ID4gCj4gPiBTb3VuZHMgZ29vZCB0byBtZS4gSSBwcmVz dW1lIHdlIG5lZWQgdGhlIHNlcmlhbCBjaGlsZCBub2RlcyBzbyB3ZSBjYW4KPiA+IHJlZmVyZW5j ZSB0aGVtIGZyb20gdGhlIHN0ZG91dC1wYXRoPyAgCj4gCj4gWWVzLCBleGFjdGx5LCBzZXBhcmF0 ZSBub2RlcyBmb3Igc2VyaWFsMSBhbmQgc2VyaWFsMiBhcmUgc3RpbGwgcmVxdWlyZWQuCj4gCj4g QnV0IGRyb3BwaW5nIGNsb2NrIGNvbnRyb2xsZXIgaXMgbm90IHBvc3NpYmxlIGFzIGZvciBoaWdo ZXIgYmF1ZHJhdGVzIHdlCj4gbmVlZCB0byB1c2UgYW5kIGNvbmZpZ3VyZSB1YXJ0IGNsb2NrIGNv bnRyb2xsZXIuIFdpdGhvdXQgaXQgd2UganVzdCBnZXQKPiBjb21wYXJhYmxlIGZlYXR1cmUgc3Vw cG9ydCB3aGljaCBpcyBhbHJlYWR5IHByZXNlbnQgaW4gZHJpdmVyLgoKV2hhdCBTdGVwaGVuIG1l YW5zIGlzIG1ha2luZyBjbG9jayBjb250cm9sbGVyIG91dCBvZiB0aGUgdWFydCBub2RlCmRpcmVj dGx5LiBObyBuZWVkIHRvIGFkZCBzZXBhcmF0ZSBzdWJub2RlIGp1c3QgZm9yIGNsb2NrIGNvbnRy b2xsZXIuCgpNYXJlawoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=