From: Shakeel Butt <shakeelb@google.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Shakeel Butt <shakeelb@google.com>
Subject: [PATCH] mpage: remove ineffective __GFP_HIGH flag
Date: Sat, 15 Jan 2022 06:41:50 -0800 [thread overview]
Message-ID: <20220115144150.1195590-1-shakeelb@google.com> (raw)
Since the commit 8a5c743e308dd ("mm, memcg: use consistent gfp flags
during readahead") mpage_alloc is clearing all the flag bits other than
bits in GFP_KERNEL internally. Simply remove __GFP_HIGH from the call to
mpage_alloc as it is cleared by it.
Signed-off-by: Shakeel Butt <shakeelb@google.com>
---
fs/mpage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/mpage.c b/fs/mpage.c
index 87f5cfef6caa..477ccc3f3ac3 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -609,7 +609,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
goto out;
}
bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9),
- BIO_MAX_VECS, GFP_NOFS|__GFP_HIGH);
+ BIO_MAX_VECS, GFP_NOFS);
if (bio == NULL)
goto confused;
--
2.34.1.703.g22d0c6ccf7-goog
next reply other threads:[~2022-01-15 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 14:41 Shakeel Butt [this message]
2022-01-17 7:14 ` [PATCH] mpage: remove ineffective __GFP_HIGH flag Christoph Hellwig
2022-01-17 18:09 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115144150.1195590-1-shakeelb@google.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.