* [PATCH] selftests: cpufreq: Write test output to stdout as well
@ 2022-01-14 23:21 Nícolas F. R. A. Prado
2022-01-17 6:41 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-01-14 23:21 UTC (permalink / raw)
To: Shuah Khan
Cc: Rafael J. Wysocki, Viresh Kumar, linux-pm, linux-kselftest,
linux-kernel, kernel, Nícolas F. R. A. Prado
Use 'tee' to send the test output to stdout in addition to the current
output file. This makes the output easier to handle in automated test
systems and is superior to only later dumping the output file contents
to stdout, since this way the test output can be interleaved with other
log messages, like from the kernel, so that chronology is preserved,
making it easier to detect issues.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
tools/testing/selftests/cpufreq/main.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh
index 31f8c9a76c5f..60ce18ed0666 100755
--- a/tools/testing/selftests/cpufreq/main.sh
+++ b/tools/testing/selftests/cpufreq/main.sh
@@ -194,5 +194,5 @@ prerequisite
# Run requested functions
clear_dumps $OUTFILE
-do_test >> $OUTFILE.txt
+do_test | tee -a $OUTFILE.txt
dmesg_dumps $OUTFILE
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: cpufreq: Write test output to stdout as well
2022-01-14 23:21 [PATCH] selftests: cpufreq: Write test output to stdout as well Nícolas F. R. A. Prado
@ 2022-01-17 6:41 ` Viresh Kumar
2022-01-25 20:51 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2022-01-17 6:41 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: Shuah Khan, Rafael J. Wysocki, linux-pm, linux-kselftest,
linux-kernel, kernel
On 14-01-22, 18:21, Nícolas F. R. A. Prado wrote:
> Use 'tee' to send the test output to stdout in addition to the current
> output file. This makes the output easier to handle in automated test
> systems and is superior to only later dumping the output file contents
> to stdout, since this way the test output can be interleaved with other
> log messages, like from the kernel, so that chronology is preserved,
> making it easier to detect issues.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> tools/testing/selftests/cpufreq/main.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh
> index 31f8c9a76c5f..60ce18ed0666 100755
> --- a/tools/testing/selftests/cpufreq/main.sh
> +++ b/tools/testing/selftests/cpufreq/main.sh
> @@ -194,5 +194,5 @@ prerequisite
>
> # Run requested functions
> clear_dumps $OUTFILE
> -do_test >> $OUTFILE.txt
> +do_test | tee -a $OUTFILE.txt
> dmesg_dumps $OUTFILE
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: cpufreq: Write test output to stdout as well
2022-01-17 6:41 ` Viresh Kumar
@ 2022-01-25 20:51 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2022-01-25 20:51 UTC (permalink / raw)
To: Viresh Kumar, Nícolas F. R. A. Prado
Cc: Shuah Khan, Rafael J. Wysocki, linux-pm, linux-kselftest,
linux-kernel, kernel, Shuah Khan
On 1/16/22 11:41 PM, Viresh Kumar wrote:
> On 14-01-22, 18:21, Nícolas F. R. A. Prado wrote:
>> Use 'tee' to send the test output to stdout in addition to the current
>> output file. This makes the output easier to handle in automated test
>> systems and is superior to only later dumping the output file contents
>> to stdout, since this way the test output can be interleaved with other
>> log messages, like from the kernel, so that chronology is preserved,
>> making it easier to detect issues.
>>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>> ---
>> tools/testing/selftests/cpufreq/main.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh
>> index 31f8c9a76c5f..60ce18ed0666 100755
>> --- a/tools/testing/selftests/cpufreq/main.sh
>> +++ b/tools/testing/selftests/cpufreq/main.sh
>> @@ -194,5 +194,5 @@ prerequisite
>>
>> # Run requested functions
>> clear_dumps $OUTFILE
>> -do_test >> $OUTFILE.txt
>> +do_test | tee -a $OUTFILE.txt
>> dmesg_dumps $OUTFILE
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Thank you. Applied to linux-kselftest fixes for rc2/3
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-25 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 23:21 [PATCH] selftests: cpufreq: Write test output to stdout as well Nícolas F. R. A. Prado
2022-01-17 6:41 ` Viresh Kumar
2022-01-25 20:51 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.