From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31EC9C433FE for ; Mon, 17 Jan 2022 10:02:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23DEE82FD5; Mon, 17 Jan 2022 11:02:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="g129oixd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 915558197F; Mon, 17 Jan 2022 11:02:46 +0100 (CET) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ADE6481F0B for ; Mon, 17 Jan 2022 11:02:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x531.google.com with SMTP id g2so10420087pgo.9 for ; Mon, 17 Jan 2022 02:02:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=rxsuRF6T6nOmw/dX9LIkUGWAlOt+W+AcCOH0BQfzGC4=; b=g129oixd+4KMJrzCAmrZBeqtj7Fr8c6KXrewuPRRS+umBfE3fJhnnG/AqiFMg3vByE /lHlSPH17PYRSWspV02UqlTe5RjKrt+YuSl9lCuyv16dvYDADfbVXe7nKnUKdHjxqyD+ K8MS189VxJl4MQcg+bTTBPgrgRdeLXts4lrBFQVc1TobvOLjy1x5lyVM7qf79FwxIK2L 0WTcPqDJXE+yJqD3tL1uEGjbVb3tZKXskceXr3kHKIcRhoSXlBpm+Bg5F74yFMfZ+85y Zdf33GPSfTY6lUfq1VDks6OhcmSO7Fb1+UbAWlFBLfm2cCYjUdAPySdZ1PjMBKwbkkzS 4i8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=rxsuRF6T6nOmw/dX9LIkUGWAlOt+W+AcCOH0BQfzGC4=; b=lUlYuHYx263GQVZtJvfmYJtGUQ7c3CwiHMjIYcNoefkftUFgI5SXvXSUyVIFxhhVw6 U1RBOkXa0upxPznjuEHinhuZZQ6Y7hUb/Ucw+BPS1TczFYy2IYydOZ88rwu4R3DbKr21 sgTNDhDfdBbeNWLBoW7QezMFLnWZ1ZZliWyLIZZzFJbBCy+uPaagdw7uTXTND3HZ0Iid 97C6pA5u166ezqQF0m6Tbq73jS6DlH/6mDm9QBuMkG7rWFFDSSX33XM3tN6FibjR6ytX Kkvqm4Eq5NuzrtKGJQFxEigUTXl8kXibvPKXTQyA0+Wjvzh1Hxy1tyWPmrk1IIeuR6EA Wjlw== X-Gm-Message-State: AOAM531p3M71WQnUOCaY7lzwOFatt8Q9bVV6bRVaFxSdmvHhiHmCxQ2x qKxNrBhgjH6XW3/TCz3FhoP3Sg== X-Google-Smtp-Source: ABdhPJwB+RG20izyuBc+6AcQPKqVS51JzCQooPVoG6MTGJQ1ihhekRAmFAgmAdCU30JZm0ZVM8EPLA== X-Received: by 2002:a65:610b:: with SMTP id z11mr7983981pgu.205.1642413760976; Mon, 17 Jan 2022 02:02:40 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:d862:4b52:199a:dd27]) by smtp.gmail.com with ESMTPSA id q11sm13853929pfk.212.2022.01.17.02.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 02:02:40 -0800 (PST) Date: Mon, 17 Jan 2022 19:02:36 +0900 From: AKASHI Takahiro To: Peter Robinson Cc: Joe Hershberger , Wolfgang Denk , u-boot@lists.denx.de Subject: Re: [PATCH] env: fat: Add new lines at the end of print statements Message-ID: <20220117100236.GB32171@laputa> Mail-Followup-To: AKASHI Takahiro , Peter Robinson , Joe Hershberger , Wolfgang Denk , u-boot@lists.denx.de References: <20220102113835.1046267-1-pbrobinson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220102113835.1046267-1-pbrobinson@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Jan 02, 2022 at 11:38:35AM +0000, Peter Robinson wrote: > Add some new line feeds at the end of print messages to make things > easier to read on the console. The other env options do this so > this is just an omission for FAT env. > > Signed-off-by: Peter Robinson > --- > env/fat.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/env/fat.c b/env/fat.c > index 9d37d26f9e..fdccd6cd2a 100644 > --- a/env/fat.c > +++ b/env/fat.c > @@ -77,7 +77,7 @@ static int env_fat_save(void) > * This printf is embedded in the messages from env_save that > * will calling it. The missing \n is intentional. > */ It would be better to remove the comment above as well. -Takahiro Akashi > - printf("Unable to use %s %d:%d... ", > + printf("Unable to use %s %d:%d... \n", > CONFIG_ENV_FAT_INTERFACE, dev, part); > return 1; > } > @@ -93,7 +93,7 @@ static int env_fat_save(void) > * This printf is embedded in the messages from env_save that > * will calling it. The missing \n is intentional. > */ > - printf("Unable to write \"%s\" from %s%d:%d... ", > + printf("Unable to write \"%s\" from %s%d:%d... \n", > file, CONFIG_ENV_FAT_INTERFACE, dev, part); > return 1; > } > @@ -135,7 +135,7 @@ static int env_fat_load(void) > * This printf is embedded in the messages from env_save that > * will calling it. The missing \n is intentional. > */ > - printf("Unable to use %s %d:%d... ", > + printf("Unable to use %s %d:%d... \n", > CONFIG_ENV_FAT_INTERFACE, dev, part); > goto err_env_relocate; > } > @@ -153,7 +153,7 @@ static int env_fat_load(void) > * This printf is embedded in the messages from env_save that > * will calling it. The missing \n is intentional. > */ > - printf("Unable to read \"%s\" from %s%d:%d... ", > + printf("Unable to read \"%s\" from %s%d:%d... \n", > CONFIG_ENV_FAT_FILE, CONFIG_ENV_FAT_INTERFACE, dev, part); > goto err_env_relocate; > } > -- > 2.33.1 >