From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58FE9C433FE for ; Mon, 17 Jan 2022 12:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239939AbiAQMkk (ORCPT ); Mon, 17 Jan 2022 07:40:40 -0500 Received: from foss.arm.com ([217.140.110.172]:57746 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237036AbiAQMkj (ORCPT ); Mon, 17 Jan 2022 07:40:39 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B12086D; Mon, 17 Jan 2022 04:40:38 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C63473F73D; Mon, 17 Jan 2022 04:40:36 -0800 (PST) Date: Mon, 17 Jan 2022 12:40:30 +0000 From: Cristian Marussi To: Sudeep Holla Cc: Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, Michael Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH v8 11/11] clk: scmi: Support atomic clock enable/disable API Message-ID: <20220117124029.GD6113@e120937-lin> References: <20211220195646.44498-1-cristian.marussi@arm.com> <20211220195646.44498-12-cristian.marussi@arm.com> <20220114230839.ABD63C36AE9@smtp.kernel.org> <20220117103100.c6ltxnz4iqmbc4b5@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220117103100.c6ltxnz4iqmbc4b5@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 17, 2022 at 10:31:00AM +0000, Sudeep Holla wrote: > On Fri, Jan 14, 2022 at 03:08:37PM -0800, Stephen Boyd wrote: > > Quoting Cristian Marussi (2021-12-20 11:56:46) > > > Support also atomic enable/disable clk_ops beside the bare non-atomic one > > > (prepare/unprepare) when the underlying SCMI transport is configured to > > > support atomic transactions for synchronous commands. > > > Hi, > > > Cc: Michael Turquette > > > Cc: Stephen Boyd > > > Cc: linux-clk@vger.kernel.org > > > Signed-off-by: Cristian Marussi > > > --- > > > NOTE THAT STILL THERE'S NO FINE GRAIN CONTROL OVER SELECTION > > > OF WHICH CLOCK DEVICES CAN SUPPORT ATOMIC AND WHICH SHOULD NOT > > > BASED ON CLOCK DEVICES ENABLE LATENCY. > > > THIS HAS STILL TO BE ADDED IN SCMI PROTOCOL SPEC. > > > > Why are you yelling on the internet? :-) I guess I need to ack this. > > > Sorry I did not mean to yell really, just to warn partners using this. > It is for the partners who request such changes. We are trying to prototype > and share the code and ask for feedback before we finalise the specification. > > In fact it is other way around for you 😁. Not to ack as it is not yet final > 😉. At least I need to wait until the spec contents are finalised before I > can merge with your ack 😁. But I agree RFC would have indicated that along > with the above background instead of *yelling*. Cristian assumed everyone > is aware of the content as quite a few are involved in offline discussions. > > > Acked-by: Stephen Boyd > > Thanks anyways, will use it if nothing changes. > As Sudeep said, V8 it is indeed not the final version which is going to be posted soon after the merge-windows (without yelling :D) and which it will be indeed still marked as RFC since it does include a new protocol feature which is still under review and not published. Sorry for the noise. Thanks, Cristian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A32F2C433EF for ; Mon, 17 Jan 2022 12:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mgwa7BncObczJ6vqNuInY3jCeHh2KhUZFslH02PYBeU=; b=gBq89ipdm08OxW Vjz5nKwIrBE+Bt0UTmkfo3ycq4rA7AUxUS6P4ZRQoYaF0Tk213ba90si7EDztgiSwGr2tRkI5c+cU jJRV6r0jzp4AG3UWxr48rE6m1JiGcq77u9EtYZb9JDnof7eM9SzGkFAi4qcPmTyjA0fkwFF2OYLfh 1PkeShpvj/LowYd24rea9Y35spFrNxkXMKSxRAX3NUQx2mgRUxY15fnasTIwFYUyVo97L+pvnMXnQ Lkhr+YJaPTnkpDzyZKyETiaZPfdxyGWu8sk5Meh+t9W8/AwymYaynCYUw413f2yHiItS8bg5zcH8v nHdArBQh80nyhK7TCu1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9RJV-00EvY5-VP; Mon, 17 Jan 2022 12:40:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9RJS-00EvX3-CQ for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 12:40:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B12086D; Mon, 17 Jan 2022 04:40:38 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C63473F73D; Mon, 17 Jan 2022 04:40:36 -0800 (PST) Date: Mon, 17 Jan 2022 12:40:30 +0000 From: Cristian Marussi To: Sudeep Holla Cc: Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, Michael Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH v8 11/11] clk: scmi: Support atomic clock enable/disable API Message-ID: <20220117124029.GD6113@e120937-lin> References: <20211220195646.44498-1-cristian.marussi@arm.com> <20211220195646.44498-12-cristian.marussi@arm.com> <20220114230839.ABD63C36AE9@smtp.kernel.org> <20220117103100.c6ltxnz4iqmbc4b5@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220117103100.c6ltxnz4iqmbc4b5@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_044042_513274_7F01EC2B X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMTcsIDIwMjIgYXQgMTA6MzE6MDBBTSArMDAwMCwgU3VkZWVwIEhvbGxhIHdy b3RlOgo+IE9uIEZyaSwgSmFuIDE0LCAyMDIyIGF0IDAzOjA4OjM3UE0gLTA4MDAsIFN0ZXBoZW4g Qm95ZCB3cm90ZToKPiA+IFF1b3RpbmcgQ3Jpc3RpYW4gTWFydXNzaSAoMjAyMS0xMi0yMCAxMTo1 Njo0NikKPiA+ID4gU3VwcG9ydCBhbHNvIGF0b21pYyBlbmFibGUvZGlzYWJsZSBjbGtfb3BzIGJl c2lkZSB0aGUgYmFyZSBub24tYXRvbWljIG9uZQo+ID4gPiAocHJlcGFyZS91bnByZXBhcmUpIHdo ZW4gdGhlIHVuZGVybHlpbmcgU0NNSSB0cmFuc3BvcnQgaXMgY29uZmlndXJlZCB0bwo+ID4gPiBz dXBwb3J0IGF0b21pYyB0cmFuc2FjdGlvbnMgZm9yIHN5bmNocm9ub3VzIGNvbW1hbmRzLgo+ID4g PiAKCkhpLAoKPiA+ID4gQ2M6IE1pY2hhZWwgVHVycXVldHRlIDxtdHVycXVldHRlQGJheWxpYnJl LmNvbT4KPiA+ID4gQ2M6IFN0ZXBoZW4gQm95ZCA8c2JveWRAa2VybmVsLm9yZz4KPiA+ID4gQ2M6 IGxpbnV4LWNsa0B2Z2VyLmtlcm5lbC5vcmcKPiA+ID4gU2lnbmVkLW9mZi1ieTogQ3Jpc3RpYW4g TWFydXNzaSA8Y3Jpc3RpYW4ubWFydXNzaUBhcm0uY29tPgo+ID4gPiAtLS0KPiA+ID4gTk9URSBU SEFUIFNUSUxMIFRIRVJFJ1MgTk8gRklORSBHUkFJTiBDT05UUk9MIE9WRVIgU0VMRUNUSU9OCj4g PiA+IE9GIFdISUNIIENMT0NLIERFVklDRVMgQ0FOIFNVUFBPUlQgQVRPTUlDIEFORCBXSElDSCBT SE9VTEQgTk9UCj4gPiA+IEJBU0VEIE9OIENMT0NLIERFVklDRVMgRU5BQkxFIExBVEVOQ1kuCj4g PiA+IFRISVMgSEFTIFNUSUxMIFRPIEJFIEFEREVEIElOIFNDTUkgUFJPVE9DT0wgU1BFQy4KPiA+ IAo+ID4gV2h5IGFyZSB5b3UgeWVsbGluZyBvbiB0aGUgaW50ZXJuZXQ/IDotKSBJIGd1ZXNzIEkg bmVlZCB0byBhY2sgdGhpcy4KPiA+Cj4gCgpTb3JyeSBJIGRpZCBub3QgbWVhbiB0byB5ZWxsIHJl YWxseSwganVzdCB0byB3YXJuIHBhcnRuZXJzIHVzaW5nIHRoaXMuCgo+IEl0IGlzIGZvciB0aGUg cGFydG5lcnMgd2hvIHJlcXVlc3Qgc3VjaCBjaGFuZ2VzLiBXZSBhcmUgdHJ5aW5nIHRvIHByb3Rv dHlwZQo+IGFuZCBzaGFyZSB0aGUgY29kZSBhbmQgYXNrIGZvciBmZWVkYmFjayBiZWZvcmUgd2Ug ZmluYWxpc2UgdGhlIHNwZWNpZmljYXRpb24uCj4gCj4gSW4gZmFjdCBpdCBpcyBvdGhlciB3YXkg YXJvdW5kIGZvciB5b3Ug8J+YgS4gTm90IHRvIGFjayBhcyBpdCBpcyBub3QgeWV0IGZpbmFsCj4g 8J+YiS4gQXQgbGVhc3QgSSBuZWVkIHRvIHdhaXQgdW50aWwgdGhlIHNwZWMgY29udGVudHMgYXJl IGZpbmFsaXNlZCBiZWZvcmUgSQo+IGNhbiBtZXJnZSB3aXRoIHlvdXIgYWNrIPCfmIEuIEJ1dCBJ IGFncmVlIFJGQyB3b3VsZCBoYXZlIGluZGljYXRlZCB0aGF0IGFsb25nCj4gd2l0aCB0aGUgYWJv dmUgYmFja2dyb3VuZCBpbnN0ZWFkIG9mICp5ZWxsaW5nKi4gQ3Jpc3RpYW4gYXNzdW1lZCBldmVy eW9uZQo+IGlzIGF3YXJlIG9mIHRoZSBjb250ZW50IGFzIHF1aXRlIGEgZmV3IGFyZSBpbnZvbHZl ZCBpbiBvZmZsaW5lIGRpc2N1c3Npb25zLgo+IAo+ID4gQWNrZWQtYnk6IFN0ZXBoZW4gQm95ZCA8 c2JveWRAa2VybmVsLm9yZz4KPiAKPiBUaGFua3MgYW55d2F5cywgd2lsbCB1c2UgaXQgaWYgbm90 aGluZyBjaGFuZ2VzLgo+IAoKQXMgU3VkZWVwIHNhaWQsIFY4IGl0IGlzIGluZGVlZCBub3QgdGhl IGZpbmFsIHZlcnNpb24gd2hpY2ggaXMgZ29pbmcgdG8KYmUgcG9zdGVkIHNvb24gYWZ0ZXIgdGhl IG1lcmdlLXdpbmRvd3MgKHdpdGhvdXQgeWVsbGluZyA6RCkgYW5kIHdoaWNoIGl0CndpbGwgYmUg aW5kZWVkIHN0aWxsIG1hcmtlZCBhcyBSRkMgc2luY2UgaXQgZG9lcyBpbmNsdWRlIGEgbmV3IHBy b3RvY29sCmZlYXR1cmUgd2hpY2ggaXMgc3RpbGwgdW5kZXIgcmV2aWV3IGFuZCBub3QgcHVibGlz aGVkLgoKU29ycnkgZm9yIHRoZSBub2lzZS4KClRoYW5rcywKQ3Jpc3RpYW4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK