From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71BF2C433F5 for ; Mon, 17 Jan 2022 19:47:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BF6AE832DB; Mon, 17 Jan 2022 20:47:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Kkir2jL/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C360B834A0; Mon, 17 Jan 2022 20:47:20 +0100 (CET) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4CDDD82A71 for ; Mon, 17 Jan 2022 20:47:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id j85so20645261qke.2 for ; Mon, 17 Jan 2022 11:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dcIY+Y+EFJ2rmCe39hDMLGrtHMZZIdRweIzwZ+KgkYg=; b=Kkir2jL/g4d7XnQMI6pNMkghSLRp2ELqyRdoq8KIJGhXNv3p0vNj1X9CIF2hDZU/GZ rkcVZDL/9yYnGSL8w7c7UpUNPRCUbCvwMRPe6JfL4FdrPTzMGEJccZnF1pS3SLiFOQ/e hIkCxt0X0JLHhmf8UKUTKW1VUVpMaD8xZNzJ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dcIY+Y+EFJ2rmCe39hDMLGrtHMZZIdRweIzwZ+KgkYg=; b=37L6aRqt+P9IDAz+pjtgJ4UsSbvz4JjSB2EqSr6SkYY4s+lNsd5CNYQaKloNlANHt8 lAB8awZlp6Ludn+zUCusR9056mr3/kzETYOsnjSh0PiIg7PEvbaG5kG2G2OZF0hlDOYD IcdMf9JnZEdi7+tfGqMNggyXdILhr41KNhlRcMWmsGKekQTy01yT4uy0H+BTC/1JnFDd +blwnzAnO5DdTBlqxPxQe1LB3wS471QSMdMG82dM/yZEm50iSyYa2hoTPqEOA9TowxEo rDnyYOUNOQh+LugWZoUmook05zSWXL8x83Ije4WStY7qbKLzfEHJB+7Py8O4zH3G+F91 QiVA== X-Gm-Message-State: AOAM533bijceUDbg4mb5wUCJYAhtfuI8jEy+6SHoPLCpGi3WAz0BccX6 9VuCh7HJM7ERI0jxFeP2U5ytBA== X-Google-Smtp-Source: ABdhPJzJfwo+7FwHZaq0ErM4lZiFFNxe3+nKP5z6NVqfAuugJetxfvjNwABU5eOABtP8EIsiajh8pw== X-Received: by 2002:a37:6c6:: with SMTP id 189mr11611519qkg.641.1642448836178; Mon, 17 Jan 2022 11:47:16 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-8dc3-db57-8e4a-695a.res6.spectrum.com. [2603:6081:7b01:cbda:8dc3:db57:8e4a:695a]) by smtp.gmail.com with ESMTPSA id y17sm1612467qtw.0.2022.01.17.11.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 11:47:15 -0800 (PST) Date: Mon, 17 Jan 2022 14:47:08 -0500 From: Tom Rini To: Artem Lapkin Cc: sjg@chromium.org, narmstrong@baylibre.com, twarren@nvidia.com, andre.przywara@arm.com, u-boot@lists.denx.de, u-boot-amlogic@groups.io, christianshewitt@gmail.com, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: Re: [PATCH v2] image-board: fix wrong implementation ram disk address setup from cmdline Message-ID: <20220117194708.GA2657591@bill-the-cat> References: <20211125030859.2896352-1-art@khadas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <20211125030859.2896352-1-art@khadas.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 25, 2021 at 11:08:59AM +0800, Artem Lapkin wrote: > Problem >=20 > Wrong implementation logic: ramdisk cmdline image address always ignored! > Next block { rd_addr =3D hextoul(select, NULL) } unusable for raw initrd. >=20 > We have unbootable raw initrd images because, select_ramdisk for raw > initrd images ignore submited select addr and setup rd_datap value to 0 >=20 > Signed-off-by: Artem Lapkin > Reviewed-by: Simon Glass > --- > V2 changes > _ rebase to master > _ from https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.41= 57293-1-art@khadas.com/ > --- > boot/image-board.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/boot/image-board.c b/boot/image-board.c > index bf8817165c..87a8f07432 100644 > --- a/boot/image-board.c > +++ b/boot/image-board.c > @@ -334,7 +334,7 @@ static int select_ramdisk(bootm_headers_t *images, co= nst char *select, u8 arch, > =20 > if (select) { > ulong default_addr; > - bool done =3D true; > + bool done =3D false; > =20 > if (CONFIG_IS_ENABLED(FIT)) { > /* > @@ -352,13 +352,13 @@ static int select_ramdisk(bootm_headers_t *images, = const char *select, u8 arch, > &fit_uname_config)) { > debug("* ramdisk: config '%s' from image at 0x%08lx\n", > fit_uname_config, rd_addr); > + done =3D true; > } else if (fit_parse_subimage(select, default_addr, > &rd_addr, > &fit_uname_ramdisk)) { > debug("* ramdisk: subimage '%s' from image at 0x%08lx\n", > fit_uname_ramdisk, rd_addr); > - } else { > - done =3D false; > + done =3D true; > } > } > if (!done) { I think we still need this? Can you please confirm and if so rebase to master again, sorry, thanks! --=20 Tom --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHlx7wACgkQFHw5/5Y0 tyyC4gv9H7DTQqc4LPhzol5ZoNL9yrkbA2wG7G1Gv6CcU2r7Kd7O8/O7oKYCvrV9 M4pEl7GRDf67kdaQVREunvxsQVEj6hgxhWdMpx5e+ZCeqpBAKtMKy2Ay97CTdQjT XxfMx/ubuMO+HA+QLjOdcCbqAc6c01rnLeh66lZkZhEXemLheTWXgT4TwHp7ADS3 reiGtuEPQR5I92B2fq31EGdMZbX/in8R0/VantSBd2raHjE2oU397F8DAUOL15cR iVBC7mU/NFFnfhwaP4oHQStFlISkzhZNFhwOGw5zVVroEBTasx62vslmj5iOfOgC vBC9c4zQ0cmqeCb1n1pIbn9u5AqJ7hVWJg8+cA1eun+2A64D9EfXhlitaLHL1w4Q ohn0yAv9sUFR+hALZAVYvhA3nKbP7f/+sI44+3GkQzsq0N23LL4C86Wr2n3re/0S k5nq3l2HZtDUXgKqXXc2pV5vIOYxGHVT/Y8o+Z5QWXHEVuYlrM1Hc19kTkOLnSju kwO9CX7q =Vy6u -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--