All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com
Subject: Re: [PATCH] drm/virtio: Ensure that objs is not NULL in virtio_gpu_array_put_free()
Date: Tue, 18 Jan 2022 07:56:24 +0100	[thread overview]
Message-ID: <20220118065624.uw76mxi2ij3ho4r4@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211213183122.838119-1-roberto.sassu@huawei.com>

On Mon, Dec 13, 2021 at 07:31:22PM +0100, Roberto Sassu wrote:
> If virtio_gpu_object_shmem_init() fails (e.g. due to fault injection, as it
> happened in the bug report by syzbot), virtio_gpu_array_put_free() could be
> called with objs equal to NULL.
> 
> Ensure that objs is not NULL in virtio_gpu_array_put_free(), or otherwise
> return from the function.
> 
> Cc: stable@vger.kernel.org # 5.13.x
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Reported-by: syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com
> Fixes: 377f8331d0565 ("drm/virtio: fix possible leak/unlock virtio_gpu_object_array")

Pushed to drm-misc-next.

thanks,
  Gerd


WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com,
	airlied@linux.ie, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	dri-devel@lists.freedesktop.org, daniel@ffwll.ch
Subject: Re: [PATCH] drm/virtio: Ensure that objs is not NULL in virtio_gpu_array_put_free()
Date: Tue, 18 Jan 2022 07:56:24 +0100	[thread overview]
Message-ID: <20220118065624.uw76mxi2ij3ho4r4@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211213183122.838119-1-roberto.sassu@huawei.com>

On Mon, Dec 13, 2021 at 07:31:22PM +0100, Roberto Sassu wrote:
> If virtio_gpu_object_shmem_init() fails (e.g. due to fault injection, as it
> happened in the bug report by syzbot), virtio_gpu_array_put_free() could be
> called with objs equal to NULL.
> 
> Ensure that objs is not NULL in virtio_gpu_array_put_free(), or otherwise
> return from the function.
> 
> Cc: stable@vger.kernel.org # 5.13.x
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Reported-by: syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com
> Fixes: 377f8331d0565 ("drm/virtio: fix possible leak/unlock virtio_gpu_object_array")

Pushed to drm-misc-next.

thanks,
  Gerd

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com,
	airlied@linux.ie, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/virtio: Ensure that objs is not NULL in virtio_gpu_array_put_free()
Date: Tue, 18 Jan 2022 07:56:24 +0100	[thread overview]
Message-ID: <20220118065624.uw76mxi2ij3ho4r4@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211213183122.838119-1-roberto.sassu@huawei.com>

On Mon, Dec 13, 2021 at 07:31:22PM +0100, Roberto Sassu wrote:
> If virtio_gpu_object_shmem_init() fails (e.g. due to fault injection, as it
> happened in the bug report by syzbot), virtio_gpu_array_put_free() could be
> called with objs equal to NULL.
> 
> Ensure that objs is not NULL in virtio_gpu_array_put_free(), or otherwise
> return from the function.
> 
> Cc: stable@vger.kernel.org # 5.13.x
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Reported-by: syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com
> Fixes: 377f8331d0565 ("drm/virtio: fix possible leak/unlock virtio_gpu_object_array")

Pushed to drm-misc-next.

thanks,
  Gerd


  parent reply	other threads:[~2022-01-18  6:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 18:31 [PATCH] drm/virtio: Ensure that objs is not NULL in virtio_gpu_array_put_free() Roberto Sassu
2021-12-13 18:31 ` Roberto Sassu
2021-12-16 15:12 ` Roberto Sassu
2021-12-16 15:12   ` Roberto Sassu
2022-01-18  6:56 ` Gerd Hoffmann [this message]
2022-01-18  6:56   ` Gerd Hoffmann
2022-01-18  6:56   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118065624.uw76mxi2ij3ho4r4@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roberto.sassu@huawei.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+e9072e90624a31dfa85f@syzkaller.appspotmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.