All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: xhci: how to recover from stop endpoint timeout?
@ 2022-01-18 10:46 Martin Kepplinger
  0 siblings, 0 replies; only message in thread
From: Martin Kepplinger @ 2022-01-18 10:46 UTC (permalink / raw)
  To: mathias.nyman, gregkh, linux-usb, sarah.a.sharp, stern, andiry.xu
  Cc: Martin Kepplinger

I haven't done anything in the usb host controller drivers yet, so here's
my question: I sometimes see
"xHCI host not responding to stop endpoint command." which is obviously
followed by "xhci died" and nothing works anymore.

I see it after "Port resume timed out, port 1-1: 0xfe3" so resuming somehow
fails.

How would I distinguish between ETIMEDOUT and other paths
when we're in xhci_stop_endpoint_command_watchdog() before calling
xhci_hc_died()?

How would a "host controller reset" look like, when I'd want to test?
Something similar to suspend and resume, or something even simpler?

I'd be very happy about some hints from usb developers as a first
step here.

thank you all a lot!

                                  martin
---
 drivers/usb/host/xhci-ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index a0623b2b4dd6..d5c0e119e1da 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1293,7 +1293,7 @@ void xhci_stop_endpoint_command_watchdog(struct timer_list *t)
 
 	/*
 	 * handle a stop endpoint cmd timeout as if host died (-ENODEV).
-	 * In the future we could distinguish between -ENODEV and -ETIMEDOUT
+	 * TODO In the future we could distinguish between -ENODEV and -ETIMEDOUT
 	 * and try to recover a -ETIMEDOUT with a host controller reset
 	 */
 	xhci_hc_died(xhci);
-- 
2.30.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-18 10:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 10:46 [PATCH] usb: xhci: how to recover from stop endpoint timeout? Martin Kepplinger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.