From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CDAC433FE for ; Tue, 18 Jan 2022 18:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348186AbiARSla (ORCPT ); Tue, 18 Jan 2022 13:41:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348212AbiARSl2 (ORCPT ); Tue, 18 Jan 2022 13:41:28 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CECFC061746 for ; Tue, 18 Jan 2022 10:41:28 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id w12-20020a17090a528c00b001b276aa3aabso3549007pjh.0 for ; Tue, 18 Jan 2022 10:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ay3fyST/TB94sONxHR7b5By4j2QtODR7DIN157vfh2M=; b=TXlXir0BydZWbO6nWqig4vnOEv/uUHMdfltWYngoqHR49H2kUqpAWq1g8yvAxGHLZc OZPVjLuLcUPW8n3IYZbq5qOEqs1geZz9C7N4pDT2nvo3gh6vjJJGPFKHuQpI/GJ62FSO fcmOyj4fJN37FZCfIbVQZeJpRVp6ISit2Eds2UfQQw7ICgmHbLUQXYPDmQUJI5rQGzJ7 0OpMLelp7bgpVmrvl9Scx39HvwgCgmnA5E1A/uCZI8uDmjtx2huFBMZlIad8DK574dph dYI6lZxwlh0oRw+Jq+gwPUggdcIRpRR1Q/NyuqlmqKQSnRMphhb3RWwjzQ4mOR4pbf5P V9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ay3fyST/TB94sONxHR7b5By4j2QtODR7DIN157vfh2M=; b=QvY4BQQw9IRHCHYD4108Q76+6vsv9f/HxjSvROUq8Ik7wxIJBhXPPrPhCzBiD67hcP yBHUg0GZlgC3d4LQSzqv7IbZJw4JUHNoK97YLQqXt+0Bqf03DOoibylYx2loZTxtaYck FiPsPrEk1mJ3gCZluSWU5v4uKlmAYdgAtc4C4DLo7tyGSQVqnQRMAIfFFRAFrheUeU15 Qpl9WACCzMzbiYxHdYiU0/MpiConM7PSO2J9w9opC+5hNP/+3KD6AVeed6bAQ5le3JzW 1NIffiMRDLkT+DHTLJ+7i0bPckCBpKF9cOXhlUSQEIlw/l+LvlIGpBui1UWmYG7+UPcP fD2w== X-Gm-Message-State: AOAM533w+AalNx8052hPnKY7mOSAXbYFXlb8DA90Bi5MAtk3yA2w6hfs ebx5wKAdBZIJMIq2aKuARKE3dQ== X-Google-Smtp-Source: ABdhPJzSd7ETEMlNr+rW4yuEu4Kx+V2y2FMIlXPfLonnXz+cw5D5VuJApAptMjw1XJDzduHRJa+Inw== X-Received: by 2002:a17:903:2287:b0:149:fa57:ea87 with SMTP id b7-20020a170903228700b00149fa57ea87mr28483960plh.94.1642531287656; Tue, 18 Jan 2022 10:41:27 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id s24sm17192814pfm.100.2022.01.18.10.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 10:41:26 -0800 (PST) Date: Tue, 18 Jan 2022 11:41:23 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/9] dt-bindings: remoteproc: imx_rproc: support i.MX8QXP Message-ID: <20220118184123.GD1119324@p14s> References: <20220111033333.403448-1-peng.fan@oss.nxp.com> <20220111033333.403448-4-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111033333.403448-4-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jan 11, 2022 at 11:33:25AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX8QXP compatible > > Add a new property rsrc-id for SoC which supports SCFW. This rsrc-id You are introducing an acronym that doesn't have a definition - I have to grep the kernel tree to have an idea of what SCFW is. That consumes time that I don't have to review your code or someone else's. > is used to check whether remote process is under control of Linux or s/process/processor > not. > > To i.MX8QM/QXP, when M4 is in the same hardware partition with Cortex-A > cores, need power up M4 through SCFW, then M4 could start. So introduce > power-domains property > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > index fc16d903353e..ed1bcb3046a9 100644 > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > @@ -19,6 +19,7 @@ properties: > - fsl,imx8mm-cm4 > - fsl,imx8mn-cm7 > - fsl,imx8mp-cm7 > + - fsl,imx8qxp-cm4 > - fsl,imx8ulp-cm33 > - fsl,imx7d-cm4 > - fsl,imx7ulp-cm4 > @@ -59,6 +60,15 @@ properties: > Indicate whether need to load the default firmware and start the remote > processor automatically. > > + power-domains: > + maxItems: 8 > + > + rsrc-id: > + description: > + This property is to specify the resource id of the remote processor in SoC > + which supports SCFW > + maxItems: 1 > + > required: > - compatible > > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F213C433F5 for ; Tue, 18 Jan 2022 18:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Gk04u4QhVyXhWrO82n8IdbWjPfHcIHdY1XlYEvcqwo=; b=zzYrrZApNgJjQ2 19RmdlfoXUXTf64Ye8Vg8l5tYMMF0Q7u/isDRnR19z88BusX1s2GMYCuYk1WwMANasHGng6tWgRwq k1Kk01nP3c4Q0gd+0bEIDByTMf3ZWtcvx5mY4LY8ocL0SA1q5yGl6AwMFfaNQh/eY0C1eYl+pG3l1 XMDE0TPxVNNSYwoFyTKm+q+dRB+35zk1loNEiVoS8l1MK+L6JPmuVbgTteQ4gBjVsIHDzkhGpH6iH NGrnkt/2FvA0UuTbpegK5c+HBKup6d+vJJnf3LTHhro8asmWShiA3YwefKrndDz7QcWFlK5b8Ndu6 hBwWGzWumDIMz1VenQZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9tQF-002bbT-RA; Tue, 18 Jan 2022 18:41:36 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9tQ9-002ba2-Em for linux-arm-kernel@lists.infradead.org; Tue, 18 Jan 2022 18:41:30 +0000 Received: by mail-pj1-x1029.google.com with SMTP id o64so151060pjo.2 for ; Tue, 18 Jan 2022 10:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ay3fyST/TB94sONxHR7b5By4j2QtODR7DIN157vfh2M=; b=TXlXir0BydZWbO6nWqig4vnOEv/uUHMdfltWYngoqHR49H2kUqpAWq1g8yvAxGHLZc OZPVjLuLcUPW8n3IYZbq5qOEqs1geZz9C7N4pDT2nvo3gh6vjJJGPFKHuQpI/GJ62FSO fcmOyj4fJN37FZCfIbVQZeJpRVp6ISit2Eds2UfQQw7ICgmHbLUQXYPDmQUJI5rQGzJ7 0OpMLelp7bgpVmrvl9Scx39HvwgCgmnA5E1A/uCZI8uDmjtx2huFBMZlIad8DK574dph dYI6lZxwlh0oRw+Jq+gwPUggdcIRpRR1Q/NyuqlmqKQSnRMphhb3RWwjzQ4mOR4pbf5P V9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ay3fyST/TB94sONxHR7b5By4j2QtODR7DIN157vfh2M=; b=clofGQSHeILopFScQLMPhCLfpzz+/EqKNT/h12yy5thm1flARDppJuRAJdrxoPnxfE sB67CTFxFHm5SpTa1XcThy8SkLQNMaKI0owaWMzk9xDKxEKyCQ6ApGc97I+oIaKPwvTC 7j1O1g1cpDBUA85MENPJRizJJFI9Tq+fbPfHv1hqja1WSaQWvkPHHq/JzUTHBx5J1okf E5lq78ShtLG3EWEYD0cHYsxVybBQi+3N8schw5z3SaRDf/CSpKhvYzHPdGy99i4dDFpz JGRs50uV14N6hIr0EWMFAb1YTJK6kkXJv94UZG317SrmPjR3DRUd1qfbO7XDxKU7VGNL S5Lw== X-Gm-Message-State: AOAM532cqeqEIIz16ROZS/cblhuXxur6XTFr3lQbJq4JrIZlVP+hpDwI M2Vuduq2uIGmwX9EliF7Uiw9rQ== X-Google-Smtp-Source: ABdhPJzSd7ETEMlNr+rW4yuEu4Kx+V2y2FMIlXPfLonnXz+cw5D5VuJApAptMjw1XJDzduHRJa+Inw== X-Received: by 2002:a17:903:2287:b0:149:fa57:ea87 with SMTP id b7-20020a170903228700b00149fa57ea87mr28483960plh.94.1642531287656; Tue, 18 Jan 2022 10:41:27 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id s24sm17192814pfm.100.2022.01.18.10.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 10:41:26 -0800 (PST) Date: Tue, 18 Jan 2022 11:41:23 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/9] dt-bindings: remoteproc: imx_rproc: support i.MX8QXP Message-ID: <20220118184123.GD1119324@p14s> References: <20220111033333.403448-1-peng.fan@oss.nxp.com> <20220111033333.403448-4-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220111033333.403448-4-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_104129_567416_D3E93162 X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 11, 2022 at 11:33:25AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX8QXP compatible > > Add a new property rsrc-id for SoC which supports SCFW. This rsrc-id You are introducing an acronym that doesn't have a definition - I have to grep the kernel tree to have an idea of what SCFW is. That consumes time that I don't have to review your code or someone else's. > is used to check whether remote process is under control of Linux or s/process/processor > not. > > To i.MX8QM/QXP, when M4 is in the same hardware partition with Cortex-A > cores, need power up M4 through SCFW, then M4 could start. So introduce > power-domains property > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > index fc16d903353e..ed1bcb3046a9 100644 > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > @@ -19,6 +19,7 @@ properties: > - fsl,imx8mm-cm4 > - fsl,imx8mn-cm7 > - fsl,imx8mp-cm7 > + - fsl,imx8qxp-cm4 > - fsl,imx8ulp-cm33 > - fsl,imx7d-cm4 > - fsl,imx7ulp-cm4 > @@ -59,6 +60,15 @@ properties: > Indicate whether need to load the default firmware and start the remote > processor automatically. > > + power-domains: > + maxItems: 8 > + > + rsrc-id: > + description: > + This property is to specify the resource id of the remote processor in SoC > + which supports SCFW > + maxItems: 1 > + > required: > - compatible > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel