All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org,
	david@gibson.dropbear.id.au
Subject: [PATCH v2 01/14] target/ppc: 405: Rename MSR_POW to MSR_WE
Date: Tue, 18 Jan 2022 15:44:35 -0300	[thread overview]
Message-ID: <20220118184448.852996-2-farosas@linux.ibm.com> (raw)
In-Reply-To: <20220118184448.852996-1-farosas@linux.ibm.com>

Bit 13 is the Wait State Enable bit. Give it its proper name.

As far as I can see we don't do anything with MSR_POW for the 405, so
this change has no effect.

Suggested-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
 target/ppc/cpu.h      | 1 +
 target/ppc/cpu_init.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index 2560b70c5f..66e13075c3 100644
--- a/target/ppc/cpu.h
+++ b/target/ppc/cpu.h
@@ -327,6 +327,7 @@ typedef enum {
 #define MSR_S    22 /* Secure state                                          */
 #define MSR_KEY  19 /* key bit on 603e                                       */
 #define MSR_POW  18 /* Power management                                      */
+#define MSR_WE   18 /* Wait State Enable on 405                              */
 #define MSR_TGPR 17 /* TGPR usage on 602/603                        x        */
 #define MSR_CE   17 /* Critical interrupt enable on embedded PowerPC x       */
 #define MSR_ILE  16 /* Interrupt little-endian mode                          */
diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index e30e86fe9d..e63705b1c6 100644
--- a/target/ppc/cpu_init.c
+++ b/target/ppc/cpu_init.c
@@ -2535,7 +2535,7 @@ POWERPC_FAMILY(405)(ObjectClass *oc, void *data)
                        PPC_MEM_SYNC | PPC_MEM_EIEIO |
                        PPC_40x_TLB | PPC_MEM_TLBIA | PPC_MEM_TLBSYNC |
                        PPC_4xx_COMMON | PPC_405_MAC | PPC_40x_EXCP;
-    pcc->msr_mask = (1ull << MSR_POW) |
+    pcc->msr_mask = (1ull << MSR_WE) |
                     (1ull << MSR_CE) |
                     (1ull << MSR_EE) |
                     (1ull << MSR_PR) |
-- 
2.33.1



  reply	other threads:[~2022-01-18 19:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 18:44 [PATCH v2 00/14] target/ppc: powerpc_excp improvements [40x] (3/n) Fabiano Rosas
2022-01-18 18:44 ` Fabiano Rosas [this message]
2022-01-19 11:27   ` [PATCH v2 01/14] target/ppc: 405: Rename MSR_POW to MSR_WE Cédric Le Goater
2022-01-18 18:44 ` [PATCH v2 02/14] target/ppc: 405: Add missing MSR_ME bit Fabiano Rosas
2022-01-19 11:26   ` Cédric Le Goater
2022-01-18 18:44 ` [PATCH v2 03/14] target/ppc: Introduce powerpc_excp_40x Fabiano Rosas
2022-01-19 11:28   ` Cédric Le Goater
2022-01-26 21:58   ` Richard Henderson
2022-01-18 18:44 ` [PATCH v2 04/14] target/ppc: Simplify powerpc_excp_40x Fabiano Rosas
2022-01-19  6:04   ` David Gibson
2022-01-18 18:44 ` [PATCH v2 05/14] target/ppc: 405: Critical exceptions cleanup Fabiano Rosas
2022-01-26 21:58   ` Richard Henderson
2022-01-18 18:44 ` [PATCH v2 06/14] target/ppc: 405: Machine check exception cleanup Fabiano Rosas
2022-01-19  6:06   ` David Gibson
2022-01-19 11:21     ` Cédric Le Goater
2022-01-18 18:44 ` [PATCH v2 07/14] target/ppc: 405: External " Fabiano Rosas
2022-01-26 22:02   ` Richard Henderson
2022-01-26 22:20     ` Fabiano Rosas
2022-01-18 18:44 ` [PATCH v2 08/14] target/ppc: 405: System call " Fabiano Rosas
2022-01-19  6:09   ` David Gibson
2022-01-25  8:18     ` Cédric Le Goater
2022-01-25 11:27       ` Cédric Le Goater
2022-01-25 12:49       ` BALATON Zoltan
2022-01-26 22:02   ` Richard Henderson
2022-01-18 18:44 ` [PATCH v2 09/14] target/ppc: 405: Alignment " Fabiano Rosas
2022-01-19  6:11   ` David Gibson
2022-01-18 18:44 ` [PATCH v2 10/14] target/ppc: 405: Debug " Fabiano Rosas
2022-01-19  6:12   ` David Gibson
2022-01-18 18:44 ` [PATCH v2 11/14] target/ppc: 405: Data Storage " Fabiano Rosas
2022-01-19  6:13   ` David Gibson
2022-01-19 11:25     ` Cédric Le Goater
2022-01-25  7:23     ` Cédric Le Goater
2022-01-25  7:29       ` Cédric Le Goater
2022-01-18 18:44 ` [PATCH v2 12/14] target/ppc: 405: Instruction storage interrupt cleanup Fabiano Rosas
2022-01-20 22:17   ` Cédric Le Goater
2022-01-25  7:24   ` Cédric Le Goater
2022-01-18 18:44 ` [PATCH v2 13/14] target/ppc: 405: Program exception cleanup Fabiano Rosas
2022-01-19  6:15   ` David Gibson
2022-01-19 12:54     ` Fabiano Rosas
2022-01-20 16:23       ` Cédric Le Goater
2022-01-25  7:25   ` Cédric Le Goater
2022-01-18 18:44 ` [PATCH v2 14/14] target/ppc: 405: Watchdog timer " Fabiano Rosas
2022-01-25  7:26   ` Cédric Le Goater
2022-01-20  9:33 ` [PATCH v2 00/14] target/ppc: powerpc_excp improvements [40x] (3/n) Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118184448.852996-2-farosas@linux.ibm.com \
    --to=farosas@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.