From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117B8C433EF for ; Wed, 19 Jan 2022 09:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352780AbiASJYq (ORCPT ); Wed, 19 Jan 2022 04:24:46 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:40658 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1352766AbiASJYo (ORCPT ); Wed, 19 Jan 2022 04:24:44 -0500 X-UUID: 1ac59f4b3b1f4caa826e0ff51a75370e-20220119 X-UUID: 1ac59f4b3b1f4caa826e0ff51a75370e-20220119 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1307031794; Wed, 19 Jan 2022 17:24:41 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:24:40 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:24:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Jan 2022 17:24:40 +0800 From: Miles Chen To: CC: , , , , , , , , , Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure Date: Wed, 19 Jan 2022 17:24:40 +0800 Message-ID: <20220119092440.4045-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org hi, >Thanks for the patch. Could you let me know which architecture and >compiler this was broken on? If I had to guess, I'd wager arm32, and >you hit this by enabling optimized blake2s? Actually, I am merging android-common tree and test our device. I use arm64 and clang-r437112b. I'm not sure which option is the right one, grep 'BLAKE' .config shows: CONFIG_CRYPTO_BLAKE2B=y # CONFIG_CRYPTO_BLAKE2S is not set # CONFIG_CRYPTO_LIB_BLAKE2S_GENERIC=y and... I found that my patch breaks arm32 build, sorry for that. >If so, I'm not sure the problem is with weak symbols. Why should CFI >break weak symbols? Rather, perhaps the issue is that the function is >defined in blake2s-core.S? Are there some CFI macros we need for that >definition? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32E41C433F5 for ; Wed, 19 Jan 2022 09:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AwwZaYZAccqMxBjHWRYqBRCR9MxydnEf7pV68UMLxjw=; b=o5cMS497Q2Re8Y aYx7a7xxzoi9/kDRs1eYLExlHuc3QJ9LJoWrQCtgAfn8lay9KnlyHG1qUZ3kv6HSNNmIVZxjguZ84 A65smugnk24eL/E5IopgO0StRoNCEEgo4G70/Y7DiXjEhSoE4oNsFXlLp/m6H11ZKGAgsUcoTxISM /Zk76hYmfX3XhLco5zJRzExsW/lZs1dgNfPD1QP3qcc42faRxc5y+qZLzDgiMj+a44aNCuaxUIhbd EQVCciY0laiLpFPUtGWOwvdbPm8FEKb9APvXQ1dW2cscrDWBMSE4gEjYTm7u/pZCwIA6ilbJIk+ld iGQcJPIUJfbJ4gwXc1Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7Md-004bxx-9y; Wed, 19 Jan 2022 09:34:47 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7Ly-004bZH-4s; Wed, 19 Jan 2022 09:34:07 +0000 X-UUID: cd3b69d70fb145daa2071b6aab1253b9-20220119 X-UUID: cd3b69d70fb145daa2071b6aab1253b9-20220119 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 748684259; Wed, 19 Jan 2022 02:33:57 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 01:24:47 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:24:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Jan 2022 17:24:40 +0800 From: Miles Chen To: CC: , , , , , , , , , Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure Date: Wed, 19 Jan 2022 17:24:40 +0800 Message-ID: <20220119092440.4045-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_013406_238654_CF719F5E X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org hi, >Thanks for the patch. Could you let me know which architecture and >compiler this was broken on? If I had to guess, I'd wager arm32, and >you hit this by enabling optimized blake2s? Actually, I am merging android-common tree and test our device. I use arm64 and clang-r437112b. I'm not sure which option is the right one, grep 'BLAKE' .config shows: CONFIG_CRYPTO_BLAKE2B=y # CONFIG_CRYPTO_BLAKE2S is not set # CONFIG_CRYPTO_LIB_BLAKE2S_GENERIC=y and... I found that my patch breaks arm32 build, sorry for that. >If so, I'm not sure the problem is with weak symbols. Why should CFI >break weak symbols? Rather, perhaps the issue is that the function is >defined in blake2s-core.S? Are there some CFI macros we need for that >definition? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 144D8C433F5 for ; Wed, 19 Jan 2022 09:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PrVE+xUBQgBhA46nfkjIPSq03iBfZ1oJs/JU7rygGzc=; b=O2tR/rEjJyWUZj pTuzQmdu2Jxf3HALY8LFCCGTvz4uf4Ttfcjajp/8V0yBQRr1E9hdXej4yJ5hL4IqTPNMSbGSGVca7 qrY1jBjLnDQOWKZ3MpbUdd3Xq5DYMFFouIojv9DRI4KUgLNFlz0Q9sTbbK1+RagJ1hmwPRmbWjxVs Gnkh9ceVAiuL3LnbQ2JAhOSZq6zLzX8udDPprXOBOQG363o3GSggCCZALQbvr9/27uIUsWQ1SKx5L Ca6iBjUY9VMuM7OuLaoMCgydttHbfn4UyjTQZqppLbg58BHnM1vqA1t8KI6BGhmtpdbe5LWyxf/VA HnejTmhD2vifLdbnrM9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7Mg-004bzB-TD; Wed, 19 Jan 2022 09:34:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7Ly-004bZH-4s; Wed, 19 Jan 2022 09:34:07 +0000 X-UUID: cd3b69d70fb145daa2071b6aab1253b9-20220119 X-UUID: cd3b69d70fb145daa2071b6aab1253b9-20220119 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 748684259; Wed, 19 Jan 2022 02:33:57 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 01:24:47 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:24:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Jan 2022 17:24:40 +0800 From: Miles Chen To: CC: , , , , , , , , , Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure Date: Wed, 19 Jan 2022 17:24:40 +0800 Message-ID: <20220119092440.4045-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_013406_238654_CF719F5E X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org hi, >Thanks for the patch. Could you let me know which architecture and >compiler this was broken on? If I had to guess, I'd wager arm32, and >you hit this by enabling optimized blake2s? Actually, I am merging android-common tree and test our device. I use arm64 and clang-r437112b. I'm not sure which option is the right one, grep 'BLAKE' .config shows: CONFIG_CRYPTO_BLAKE2B=y # CONFIG_CRYPTO_BLAKE2S is not set # CONFIG_CRYPTO_LIB_BLAKE2S_GENERIC=y and... I found that my patch breaks arm32 build, sorry for that. >If so, I'm not sure the problem is with weak symbols. Why should CFI >break weak symbols? Rather, perhaps the issue is that the function is >defined in blake2s-core.S? Are there some CFI macros we need for that >definition? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel