From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC4BC433F5 for ; Wed, 19 Jan 2022 09:27:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353065AbiASJ1M (ORCPT ); Wed, 19 Jan 2022 04:27:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352766AbiASJ1I (ORCPT ); Wed, 19 Jan 2022 04:27:08 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17650C061574 for ; Wed, 19 Jan 2022 01:27:08 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id p27so6935198lfa.1 for ; Wed, 19 Jan 2022 01:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:user-agent:references :mime-version:content-disposition:in-reply-to; bh=u5lDwO+2XRK8rlP7NLgszztTGNGruOFaEDeVGg6XhHY=; b=lwP3af+Iz6VPA9+Q2nCdQo1sMq9nVMIsjYYH4vvuH5N01oYYSSdphao4uxw8RYQnsi 0hfm7MEWrM3oNZw0xonaYTn+eTKdb0Z2e5yfNPreuU/YRUlzSwl/FQSv2r3d2MFuZnts SZIsamz3rJXmVJ5JHA/Ah4veRyDq2lcG0APCU2wz03RazM8dIvvZctP2h8cxw1/17qTT HDEZZCVWi/6HLw2k3Yqu1Wp88d4xsx/+Hxe5P4EQhz+znbzVWhOvnSF3h7WhqMnrqe3k c+kGEWLNwxr45+Uv5pmhvDN25jmmKjelXCK3PS7bkEjziE2nSk2YWnPUU72/UdtRXfUx 8tKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :references:mime-version:content-disposition:in-reply-to; bh=u5lDwO+2XRK8rlP7NLgszztTGNGruOFaEDeVGg6XhHY=; b=zj6cwQTs9QoG9UqnEIWqn4FaB6alCqvHiDWv8xsOEkxEdAzVofP4xwpQThhsY55tlh t49vNQVgjwvbIETAJlVRdXzy3D8mZDug9K1jVBPRuIaNNEuz8fISS/GrIcpSDGdIOUdE lygeLlNMwxZXt5/yDlGOoqXue2Tod0ijEqwKvu06yc67swGtS5hvoJaAbeKsDnpRqi1E +XRjFj8m7u0HY8yWBo64CwZl385boJImFhxcJQYkuFTmHH4zlC/E8ZQb+CVy2m4agB7h UWxUZghPb25isRb6Ssp7vmdnEM2OdQXvtQenpFWFlxrlUYz9GmoKmbhXZy26QeEunxtf /vig== X-Gm-Message-State: AOAM5313VDUtHlPZNO4CiuzigZE6yU4GBejciIk7t3wQklrRDEQPBrFO lLv6m/dbmzTzsz79dyI64xM= X-Google-Smtp-Source: ABdhPJz6Y+KMD8wRBih5hOfbEX+rU5U9DrLD6Xu27YqUTuDMS2DMFoUWtMgNqemZSVK2kbNlM6559w== X-Received: by 2002:a05:651c:10bb:: with SMTP id k27mr13004663ljn.310.1642584426348; Wed, 19 Jan 2022 01:27:06 -0800 (PST) Received: from localhost.localdomain (broadband-95-84-228-163.ip.moscow.rt.ru. [95.84.228.163]) by smtp.gmail.com with ESMTPSA id d5sm1230305lfs.26.2022.01.19.01.27.05 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 19 Jan 2022 01:27:05 -0800 (PST) Date: Wed, 19 Jan 2022 12:32:49 +0300 From: Alexander Sergeyev To: Takashi Iwai Cc: Jeremy Szu , tiwai@suse.com, "moderated list:SOUND" , Kailang Yang , open list , Huacai Chen , Jian-Hong Pan , Hui Wang , PeiSen Hou Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 Message-ID: <20220119093249.eaxem33bjqjxcher@localhost.localdomain> User-Agent: mtt References: <20220112104827.4aymoth7ua65nwge@localhost.localdomain> <20220112201824.qmphnz2hx4frda6e@localhost.localdomain> <20220113183141.kla37mbqmo4x6wxp@localhost.localdomain> <20220114183720.n46wealclg6spxkp@localhost.localdomain> <20220115152215.kprws5nja2i43qax@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 19, 2022 at 10:12:43AM +0100, Takashi Iwai wrote: > > Actually, the timing issues are present here as well. Sometimes unbind & > > bind works fine. But fails on the second round. > > Here "fails" means the kernel Oops / crash? If yes, the back trace > would be helpful. No, I mean "IO_PAGE_FAULT" and "out of range cmd" don't appear on every unbind & bind. Sometimes it works cleanly. Backtraces for the source of "out of range cmd" messages: --- a/sound/hda/hdac_device.c +++ b/sound/hda/hdac_device.c @@ -231,6 +231,7 @@ static unsigned int snd_hdac_make_cmd(struct hdac_device *codec, hda_nid_t nid, (verb & ~0xfff) || (parm & ~0xffff)) { dev_err(&codec->dev, "out of range cmd %x:%x:%x:%x\n", addr, nid, verb, parm); + dump_stack(); return -1; } give me the following: snd_hda_codec_realtek hdaudioC1D0: out of range cmd 0:20:400:90170118 Workqueue: events set_brightness_delayed Call Trace: dump_stack_lvl+0x34/0x4c snd_hdac_make_cmd.cold+0x17/0x2c snd_hdac_codec_write+0x16/0x60 coef_mute_led_set+0x3a/0x60 set_brightness_delayed+0x6f/0xb0 process_one_work+0x1e1/0x380 worker_thread+0x4e/0x3b0 ? rescuer_thread+0x370/0x370 kthread+0x145/0x170 ? set_kthread_struct+0x50/0x50 ret_from_fork+0x22/0x30 I'll have more time to look into this deeper later this week. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27D64C433F5 for ; Wed, 19 Jan 2022 09:28:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E2BF231FC; Wed, 19 Jan 2022 10:27:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E2BF231FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642584484; bh=CGaAV2JYA4Ns06hxLDnLwCjDah1MIoDtM58y2fcCdvA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CAGUovkxlzgIxq2qPREjjIIFubTO+jj+WJVbYo9jits6eeXANBV3euWE03Nwi743O Qa8hiwSbzWOJ1oW1Gy/iqg5FCenMpk6uCfxj1i2bpuexEohA4zGZCDK1BUrSYDt118 h9am2tWiFCeW4I8+TX2sf1Ng9iU14tnMQfblnAVo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6A230F80162; Wed, 19 Jan 2022 10:27:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30661F801F7; Wed, 19 Jan 2022 10:27:12 +0100 (CET) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 500D6F80128 for ; Wed, 19 Jan 2022 10:27:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 500D6F80128 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lwP3af+I" Received: by mail-lf1-x132.google.com with SMTP id s30so6825396lfo.7 for ; Wed, 19 Jan 2022 01:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:user-agent:references :mime-version:content-disposition:in-reply-to; bh=u5lDwO+2XRK8rlP7NLgszztTGNGruOFaEDeVGg6XhHY=; b=lwP3af+Iz6VPA9+Q2nCdQo1sMq9nVMIsjYYH4vvuH5N01oYYSSdphao4uxw8RYQnsi 0hfm7MEWrM3oNZw0xonaYTn+eTKdb0Z2e5yfNPreuU/YRUlzSwl/FQSv2r3d2MFuZnts SZIsamz3rJXmVJ5JHA/Ah4veRyDq2lcG0APCU2wz03RazM8dIvvZctP2h8cxw1/17qTT HDEZZCVWi/6HLw2k3Yqu1Wp88d4xsx/+Hxe5P4EQhz+znbzVWhOvnSF3h7WhqMnrqe3k c+kGEWLNwxr45+Uv5pmhvDN25jmmKjelXCK3PS7bkEjziE2nSk2YWnPUU72/UdtRXfUx 8tKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :references:mime-version:content-disposition:in-reply-to; bh=u5lDwO+2XRK8rlP7NLgszztTGNGruOFaEDeVGg6XhHY=; b=xKSZID8sUd+GoPxDG9l50j+RXe7fiU9wzZO3+Y/NtOtHShACqWFaK+B6agfbez3wiB GpheH5vdhw9izbyMK5M9CXi1xfureDpM81MiBnH2h+Mdd84Sf1S1xToNxOfuPuMiAzX5 aBeTd3r/0+ytGYTXUwlacDP8QszmCfUFYOzj9twuE+t7joJDnf9Jm/d1l3aAC8nSVaAZ uP/HoSGYsIpnUXUx3YTBQCePZSAH3sMo7Q+P+SCfvFdLVbnLZEXMr9WwbtRb0xTDvsDm TfQWgOeLxCceBTD3SbwdJOTVM4TgpxcVVBMM8a5P8hVhVsiuR2KcA/onmH/voBwwuUNg 6MeQ== X-Gm-Message-State: AOAM531sTyBbC5w4EfkjZXEfupl7X0XppECNquSFxyynkv90L+QA8I5B BYmV8OdRzd/xZRFlwPS+/yvQhFK76vY= X-Google-Smtp-Source: ABdhPJz6Y+KMD8wRBih5hOfbEX+rU5U9DrLD6Xu27YqUTuDMS2DMFoUWtMgNqemZSVK2kbNlM6559w== X-Received: by 2002:a05:651c:10bb:: with SMTP id k27mr13004663ljn.310.1642584426348; Wed, 19 Jan 2022 01:27:06 -0800 (PST) Received: from localhost.localdomain (broadband-95-84-228-163.ip.moscow.rt.ru. [95.84.228.163]) by smtp.gmail.com with ESMTPSA id d5sm1230305lfs.26.2022.01.19.01.27.05 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 19 Jan 2022 01:27:05 -0800 (PST) Date: Wed, 19 Jan 2022 12:32:49 +0300 From: Alexander Sergeyev To: Takashi Iwai Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 Message-ID: <20220119093249.eaxem33bjqjxcher@localhost.localdomain> User-Agent: mtt References: <20220112104827.4aymoth7ua65nwge@localhost.localdomain> <20220112201824.qmphnz2hx4frda6e@localhost.localdomain> <20220113183141.kla37mbqmo4x6wxp@localhost.localdomain> <20220114183720.n46wealclg6spxkp@localhost.localdomain> <20220115152215.kprws5nja2i43qax@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "moderated list:SOUND" , Kailang Yang , Jeremy Szu , Huacai Chen , open list , tiwai@suse.com, Hui Wang , PeiSen Hou , Jian-Hong Pan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Jan 19, 2022 at 10:12:43AM +0100, Takashi Iwai wrote: > > Actually, the timing issues are present here as well. Sometimes unbind & > > bind works fine. But fails on the second round. > > Here "fails" means the kernel Oops / crash? If yes, the back trace > would be helpful. No, I mean "IO_PAGE_FAULT" and "out of range cmd" don't appear on every unbind & bind. Sometimes it works cleanly. Backtraces for the source of "out of range cmd" messages: --- a/sound/hda/hdac_device.c +++ b/sound/hda/hdac_device.c @@ -231,6 +231,7 @@ static unsigned int snd_hdac_make_cmd(struct hdac_device *codec, hda_nid_t nid, (verb & ~0xfff) || (parm & ~0xffff)) { dev_err(&codec->dev, "out of range cmd %x:%x:%x:%x\n", addr, nid, verb, parm); + dump_stack(); return -1; } give me the following: snd_hda_codec_realtek hdaudioC1D0: out of range cmd 0:20:400:90170118 Workqueue: events set_brightness_delayed Call Trace: dump_stack_lvl+0x34/0x4c snd_hdac_make_cmd.cold+0x17/0x2c snd_hdac_codec_write+0x16/0x60 coef_mute_led_set+0x3a/0x60 set_brightness_delayed+0x6f/0xb0 process_one_work+0x1e1/0x380 worker_thread+0x4e/0x3b0 ? rescuer_thread+0x370/0x370 kthread+0x145/0x170 ? set_kthread_struct+0x50/0x50 ret_from_fork+0x22/0x30 I'll have more time to look into this deeper later this week.