From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E86C433FE for ; Wed, 19 Jan 2022 09:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353133AbiASJo1 (ORCPT ); Wed, 19 Jan 2022 04:44:27 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:41914 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1353210AbiASJnq (ORCPT ); Wed, 19 Jan 2022 04:43:46 -0500 X-UUID: 7c2429a6521c484594ae70b615a45057-20220119 X-UUID: 7c2429a6521c484594ae70b615a45057-20220119 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1035585861; Wed, 19 Jan 2022 17:43:43 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:43:42 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Jan 2022 17:43:42 +0800 From: Miles Chen To: CC: , , , , , , , , , , , Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure Date: Wed, 19 Jan 2022 17:43:42 +0800 Message-ID: <20220119094342.4515-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org >Ehm, maybe not. As Jason points out, the typedef does not have quite >the right type, so that is most likely the culprit, and this >workaround would trigger CFI in exactly the same way. > >Interestingly, the compiler does not seem to mind, right? Or are you >seeing any build time warnings on the reference to blake2s_compress in >the call to __blake2s_update() ? No, no warnings as the -Wcast-function-type is globally enabled. I cleaned some cast-function-type errors but no warnings in __blake2s_update. Miles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFEDFC433F5 for ; Wed, 19 Jan 2022 09:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gVn/QQtEr5Sg0Bz+3OL/iqO/cDtA8lqR3ITEzgsJU30=; b=P2wSZJj+DM6w+o 6jwaDoUK2uh2+h2QlOZAYbJujJ4QH0CfPJSAqRSpFOV9PeuP7YIA+tDSH5Y6/01qBa/cQYkzLWU5j Eh2GwTDa5yrV4hreopA50vOGhZ7C2Xn9Fd19mFsc7Ssr18CDSUnNipCOoaY0/SvmwdOWTNLUCQkJw S4fE9DaR47R1PEq10dHZCHdPTn9T+lRO7YwTrarftmEEV6wrVcS/UaZDZESHBA6B9/FWzxzSp6nIH uyixYCFB2SUtk6+AYh5PZrvAPOcIhQaLXYD+D7YaWr4f3x4kD6q9UNug5tRzAp3xXOCMR03bRFLAd SpyjQJVf0FtB7mjMUDlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7VS-004gGr-KI; Wed, 19 Jan 2022 09:43:54 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7VP-004gEM-Kd; Wed, 19 Jan 2022 09:43:53 +0000 X-UUID: 38fd6cd4979e4902b4a8e9616c2a518f-20220119 X-UUID: 38fd6cd4979e4902b4a8e9616c2a518f-20220119 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 764617408; Wed, 19 Jan 2022 02:43:45 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 01:43:43 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:43:42 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Jan 2022 17:43:42 +0800 From: Miles Chen To: CC: , , , , , , , , , , , Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure Date: Wed, 19 Jan 2022 17:43:42 +0800 Message-ID: <20220119094342.4515-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_014351_727784_7C935D10 X-CRM114-Status: UNSURE ( 6.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org >Ehm, maybe not. As Jason points out, the typedef does not have quite >the right type, so that is most likely the culprit, and this >workaround would trigger CFI in exactly the same way. > >Interestingly, the compiler does not seem to mind, right? Or are you >seeing any build time warnings on the reference to blake2s_compress in >the call to __blake2s_update() ? No, no warnings as the -Wcast-function-type is globally enabled. I cleaned some cast-function-type errors but no warnings in __blake2s_update. Miles _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C5C8C433EF for ; Wed, 19 Jan 2022 09:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v1HIdHR6TzJfreFiS2CAxchCjk/c44P7AM7x0tbK1dU=; b=wWpoIafgBCpfNV gStp4tUghfDC4IFzCYOWFBX7Mi4mFko0ES11nHrB4s9Unz2q1cR4eA9IlVuu1jidhGwfhBYMEMIpg jOIkDCwugQKTlbPAnvAi++NspY4GZCaCdoJgQLbaTZ533ZsZutgEVXnFzjYMG7hos3PP4d+V7h25T B/r9bdBZymBU8PRGq+qojSMnx01gUFwLjZnTkMFIqB8OW8QG7mZg+1jhmYHT+vWFCbfPOIlA1hSFy FPYrPcaM+osSQ7A3Wr/Td8S+Mfi4mPRaQsr5srZK1pSpF+aoJI2bgFljmU24CmjHT9omUjRKfJamB ck2iRoNQZZAl3sfCnWLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7VV-004gHB-SN; Wed, 19 Jan 2022 09:43:58 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA7VP-004gEM-Kd; Wed, 19 Jan 2022 09:43:53 +0000 X-UUID: 38fd6cd4979e4902b4a8e9616c2a518f-20220119 X-UUID: 38fd6cd4979e4902b4a8e9616c2a518f-20220119 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 764617408; Wed, 19 Jan 2022 02:43:45 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 01:43:43 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Jan 2022 17:43:42 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Jan 2022 17:43:42 +0800 From: Miles Chen To: CC: , , , , , , , , , , , Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure Date: Wed, 19 Jan 2022 17:43:42 +0800 Message-ID: <20220119094342.4515-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_014351_727784_7C935D10 X-CRM114-Status: UNSURE ( 6.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >Ehm, maybe not. As Jason points out, the typedef does not have quite >the right type, so that is most likely the culprit, and this >workaround would trigger CFI in exactly the same way. > >Interestingly, the compiler does not seem to mind, right? Or are you >seeing any build time warnings on the reference to blake2s_compress in >the call to __blake2s_update() ? No, no warnings as the -Wcast-function-type is globally enabled. I cleaned some cast-function-type errors but no warnings in __blake2s_update. Miles _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel