From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04993C433F5 for ; Wed, 19 Jan 2022 16:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237515AbiASQyC (ORCPT ); Wed, 19 Jan 2022 11:54:02 -0500 Received: from mga17.intel.com ([192.55.52.151]:27172 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243524AbiASQyA (ORCPT ); Wed, 19 Jan 2022 11:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642611240; x=1674147240; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8pZSvEi9rquxwXrszIRf2gCK/ow/gOe+bkO+nvMwHiQ=; b=UnPNVfbUfcvyO0jjAqFjMiXhOFtlDYFBJK12m+i7/ex6e5enVto/VoU6 s74uiKR5N3MHsS7OmMiA8G1f3yW10iCoGPNInAO5wZMks7TFwB+7S4LSy 60QM8n0l8h5+iq012WNogOEqAEPIkjuiGJ6x9cGrXSR/s8kOmxxGKTikJ +4CRfjX+BY/ndIbNc5u9ol831wywT+P2mn5hdiY+t0dFJ+Dw7lZHClNLC qQPgtyuM1ESTLDMC2QsVgT1+e9I5agopRLUMO/KDgmhKV3LGl1nxjMuEI u/Fsye207JUmQArYmNKeepr1+Ai4z3FT1KkRo35xrcyiFXRTKG9Bnm6Tc Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225784298" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="225784298" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:53:57 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="693843934" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:53:56 -0800 Date: Wed, 19 Jan 2022 08:53:56 -0800 From: Ira Weiny To: David Airlie , Daniel Vetter , Patrik Jakobsson , Rob Clark , Sean Paul Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions Message-ID: <20220119165356.GD209936@iweiny-DESK2.sc.intel.com> References: <20211210232404.4098157-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211210232404.4098157-1-ira.weiny@intel.com> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > This series starts by converting the last easy kmap() uses to > kmap_local_page(). > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > ttm_bo_kmap_ttm() is called in a number of different ways including some which > are not thread local. I have a patch to convert that call. However, it is not > straight forward so it is not included in this series. > > The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() > conversion. Gentile ping on this series? Will it make this merge window? Thanks, Ira > > > Ira Weiny (7): > drm/i915: Replace kmap() with kmap_local_page() > drm/amd: Replace kmap() with kmap_local_page() > drm/gma: Remove calls to kmap() > drm/radeon: Replace kmap() with kmap_local_page() > drm/msm: Alter comment to use kmap_local_page() > drm/amdgpu: Ensure kunmap is called on error > drm/radeon: Ensure kunmap is called on error > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + > drivers/gpu/drm/gma500/gma_display.c | 6 ++---- > drivers/gpu/drm/gma500/mmu.c | 8 ++++---- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- > drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- > drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_uvd.c | 1 + > 13 files changed, 32 insertions(+), 32 deletions(-) > > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6468AC433F5 for ; Wed, 19 Jan 2022 16:54:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E82FF10E1ED; Wed, 19 Jan 2022 16:53:58 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40FC010E1B6; Wed, 19 Jan 2022 16:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642611237; x=1674147237; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8pZSvEi9rquxwXrszIRf2gCK/ow/gOe+bkO+nvMwHiQ=; b=Ed9xYb2/luyBV/U4ptc4l4+1FUjiGgUOG1kuB1gQIsxnm9HSxaEacOwa bsmvxCxIHyjY2VWw8wlkKkTktq28vBJ5ODgImrpS0IHWqtt5sMd558Wws B7KdS8hiTuRot8M4xC3Wnss43LSzrPUdQW/DXkzV1HQdn15c3OJOoUzLJ 3er2bvgfAm1tpZVDsGmKMbCO3Jb4FljJ9Ii8aQjIK9LohQLY1Ml4WE5aC faigV9v0qosB5Vzrfn5eykeOy1MLepKFtthv6oSXysLIhOa1UmZWVOVmK EYYDtjF4+2IA8pdeeohktC5Rz0rUd5yidRSnv3iBcd3E1cYhp89Gx1FTh g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="308450492" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="308450492" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:53:56 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="693843934" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:53:56 -0800 Date: Wed, 19 Jan 2022 08:53:56 -0800 From: Ira Weiny To: David Airlie , Daniel Vetter , Patrik Jakobsson , Rob Clark , Sean Paul Subject: Re: [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions Message-ID: <20220119165356.GD209936@iweiny-DESK2.sc.intel.com> References: <20211210232404.4098157-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211210232404.4098157-1-ira.weiny@intel.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > This series starts by converting the last easy kmap() uses to > kmap_local_page(). > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > ttm_bo_kmap_ttm() is called in a number of different ways including some which > are not thread local. I have a patch to convert that call. However, it is not > straight forward so it is not included in this series. > > The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() > conversion. Gentile ping on this series? Will it make this merge window? Thanks, Ira > > > Ira Weiny (7): > drm/i915: Replace kmap() with kmap_local_page() > drm/amd: Replace kmap() with kmap_local_page() > drm/gma: Remove calls to kmap() > drm/radeon: Replace kmap() with kmap_local_page() > drm/msm: Alter comment to use kmap_local_page() > drm/amdgpu: Ensure kunmap is called on error > drm/radeon: Ensure kunmap is called on error > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + > drivers/gpu/drm/gma500/gma_display.c | 6 ++---- > drivers/gpu/drm/gma500/mmu.c | 8 ++++---- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- > drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- > drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_uvd.c | 1 + > 13 files changed, 32 insertions(+), 32 deletions(-) > > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE81BC433F5 for ; Wed, 19 Jan 2022 16:53:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AF8810E1B6; Wed, 19 Jan 2022 16:53:58 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40FC010E1B6; Wed, 19 Jan 2022 16:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642611237; x=1674147237; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8pZSvEi9rquxwXrszIRf2gCK/ow/gOe+bkO+nvMwHiQ=; b=Ed9xYb2/luyBV/U4ptc4l4+1FUjiGgUOG1kuB1gQIsxnm9HSxaEacOwa bsmvxCxIHyjY2VWw8wlkKkTktq28vBJ5ODgImrpS0IHWqtt5sMd558Wws B7KdS8hiTuRot8M4xC3Wnss43LSzrPUdQW/DXkzV1HQdn15c3OJOoUzLJ 3er2bvgfAm1tpZVDsGmKMbCO3Jb4FljJ9Ii8aQjIK9LohQLY1Ml4WE5aC faigV9v0qosB5Vzrfn5eykeOy1MLepKFtthv6oSXysLIhOa1UmZWVOVmK EYYDtjF4+2IA8pdeeohktC5Rz0rUd5yidRSnv3iBcd3E1cYhp89Gx1FTh g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="308450492" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="308450492" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:53:56 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="693843934" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 08:53:56 -0800 Date: Wed, 19 Jan 2022 08:53:56 -0800 From: Ira Weiny To: David Airlie , Daniel Vetter , Patrik Jakobsson , Rob Clark , Sean Paul Message-ID: <20220119165356.GD209936@iweiny-DESK2.sc.intel.com> References: <20211210232404.4098157-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211210232404.4098157-1-ira.weiny@intel.com> User-Agent: Mutt/1.11.1 (2018-12-01) Subject: Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > This series starts by converting the last easy kmap() uses to > kmap_local_page(). > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > ttm_bo_kmap_ttm() is called in a number of different ways including some which > are not thread local. I have a patch to convert that call. However, it is not > straight forward so it is not included in this series. > > The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() > conversion. Gentile ping on this series? Will it make this merge window? Thanks, Ira > > > Ira Weiny (7): > drm/i915: Replace kmap() with kmap_local_page() > drm/amd: Replace kmap() with kmap_local_page() > drm/gma: Remove calls to kmap() > drm/radeon: Replace kmap() with kmap_local_page() > drm/msm: Alter comment to use kmap_local_page() > drm/amdgpu: Ensure kunmap is called on error > drm/radeon: Ensure kunmap is called on error > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + > drivers/gpu/drm/gma500/gma_display.c | 6 ++---- > drivers/gpu/drm/gma500/mmu.c | 8 ++++---- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- > drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- > drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_uvd.c | 1 + > 13 files changed, 32 insertions(+), 32 deletions(-) > > -- > 2.31.1 >