All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	arnd@arndb.de, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lkdtm/bugs: Check for the NULL pointer after calling kmalloc
Date: Thu, 20 Jan 2022 06:55:43 +0300	[thread overview]
Message-ID: <20220120035542.GC1978@kadam> (raw)
In-Reply-To: <202201191044.69872866B@keescook>

On Wed, Jan 19, 2022 at 10:45:33AM -0800, Kees Cook wrote:
> > diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
> > index f4cb94a9aa9c..c35ea54824ac 100644
> > --- a/drivers/misc/lkdtm/bugs.c
> > +++ b/drivers/misc/lkdtm/bugs.c
> > @@ -325,6 +325,11 @@ void lkdtm_ARRAY_BOUNDS(void)
> >  
> >  	not_checked = kmalloc(sizeof(*not_checked) * 2, GFP_KERNEL);
> >  	checked = kmalloc(sizeof(*checked) * 2, GFP_KERNEL);
> > +	if (!not_checked || !checked) {
> > +		kfree(not_checked);
> > +		kfree(checked);
> > +		return;
> > +	}
> 
> This should explicitly yell about the memory failure. See the other
> error cases for examples. I'd expect something like this before the
> return:
> 
> 		pr_err("FAIL: could not allocate required buffers\n");

Adding error messages for kmalloc failures is a checkpatch violation.

Those allocations will never fail.  There is already a warning message
and stack trace built into kmalloc().  It's just a waste of resources to
add the warning message.

regards,
dan carpenter


      reply	other threads:[~2022-01-20  3:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 12:20 [PATCH v2] lkdtm/bugs: Check for the NULL pointer after calling kmalloc Jiasheng Jiang
2022-01-19 18:45 ` Kees Cook
2022-01-20  3:55   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220120035542.GC1978@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiasheng@iscas.ac.cn \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.