From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1542207188290715372==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] power: supply: goldfish: fix platform_get_irq.cocci warnings Date: Thu, 20 Jan 2022 21:30:41 +0800 Message-ID: <20220120133041.GA32545@f71a04655d0e> In-Reply-To: <202201202131.9jS9BoFn-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1542207188290715372== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Roman Kiryanov CC: Sebastian Reichel CC: linux-pm(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/power/supply/goldfish_battery.c:225:2-9: line 225 is redundant beca= use platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq*() failures Generated by: scripts/coccinelle/api/platform_get_irq.cocci CC: Roman Kiryanov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: fa2e1ba3e9e39072fa7a6a9d11ac432c505b4ac7 commit: 570b7c0ea20c0156411394bc215114f7b1dc18ff power: supply: goldfish: R= emove the GOLDFISH dependency :::::: branch date: 5 hours ago :::::: commit date: 10 months ago Please take the patch only if it's a positive warning. Thanks! goldfish_battery.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/power/supply/goldfish_battery.c +++ b/drivers/power/supply/goldfish_battery.c @@ -222,7 +222,6 @@ static int goldfish_battery_probe(struct = data->irq =3D platform_get_irq(pdev, 0); if (data->irq < 0) { - dev_err(&pdev->dev, "platform_get_irq failed\n"); return -ENODEV; } =20 --===============1542207188290715372==--