From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E9B1C433EF for ; Thu, 20 Jan 2022 23:19:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 82C56838F9; Fri, 21 Jan 2022 00:19:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JfY5xzRE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2466B83900; Fri, 21 Jan 2022 00:19:52 +0100 (CET) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 696F9838F8 for ; Fri, 21 Jan 2022 00:19:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id h15so8219982qtx.0 for ; Thu, 20 Jan 2022 15:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g6cS+AUMTxfIzuTTfRWFpELLfrZAwGUwCKSdt1PYGec=; b=JfY5xzRE8R+HB6Bj7ikrPxDPSyRBQAB5MzyKbrc1DYKhEZ3U2/yRtFlpY2fxHHsCyy c44atxpvfT8CX8nY9JB76A8uZKMAE3N2p5/NHj39K8Syis5v/sKriGnF5qnVD67QuEJ6 I+Ia+7+OtbTuf4b3iKzYGgNFaoNyl91nhvQ6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g6cS+AUMTxfIzuTTfRWFpELLfrZAwGUwCKSdt1PYGec=; b=qz+hlhHwQ7PUChWzdBwvBAhlghPN+3C8xoUozJy+8az7n8nGHEAUgoBvnY9jI94vc3 kVkcAKhsZSLx6N9LdI5QB+bY/AokUK9DE1QJspR/Rf0SjyPBKyo47EagmPke9SG6bc55 UojscRqsJWjzQAZ1+glzneDZKuXfFXb68iAtG3Tt/eQvOdSjRP8Da2DROAQ9N9isTAwa 5QV/2h6/ioUY/rfbE33v+lr4W12wh1XGSHaeLisYPeWK15NRQVR1tIAHzqY7f3JCAfDJ Vk0RyiMjupkN0IwSq0DHaMA3RJj1g2EqV1Db7J5FdtvUf1dAEIE58zgOzWVt/tO2KUnh TYNQ== X-Gm-Message-State: AOAM530p0oPjBy9bhw8mfxbm8etPLvrmrlmstxqb5StxDfY6UNE2BTLs PJPJDYkCGV+di3O5OURr4WZOEQ== X-Google-Smtp-Source: ABdhPJwJYB2ctQNbJdg1AZdC9MHueW3xogAP+d6sGgS/+1XiFn5q1/tkkouJ7oA3vfKAiiCR3eJfSw== X-Received: by 2002:ac8:7112:: with SMTP id z18mr1286795qto.334.1642720788168; Thu, 20 Jan 2022 15:19:48 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id 22sm2145964qtw.95.2022.01.20.15.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 15:19:47 -0800 (PST) Date: Thu, 20 Jan 2022 18:19:45 -0500 From: Tom Rini To: Ramon Fried Cc: Vignesh Raghavendra , Dave Gerlach , Joe Hershberger , U-Boot Mailing List , Grygorii Strashko Subject: Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode Message-ID: <20220120231945.GN7004@bill-the-cat> References: <20211224072536.270251-1-vigneshr@ti.com> <20211224072536.270251-3-vigneshr@ti.com> <20220117183701.GB2631111@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GU3/x65mZ6MFE8p3" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --GU3/x65mZ6MFE8p3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 21, 2022 at 01:13:54AM +0200, Ramon Fried wrote: > On Mon, Jan 17, 2022 at 8:37 PM Tom Rini wrote: > > > > On Fri, Dec 24, 2021 at 12:55:30PM +0530, Vignesh Raghavendra wrote: > > > > > On certain TI SoC, like AM64x there is a CPSW3G which supports 2 > > > external independent MAC ports for single CPSW instance. > > > It is not possible for Ethernet driver to register more than one port > > > for given instance. > > > > > > This patch modifies top level CPSW NUSS as UCLASS_MISC and binds > > > UCLASS_ETH to individual ports so as to support bring up more than one > > > Ethernet interface in U-Boot. > > > > > > Note that there is no isolation in the since, CPSW NUSS is in promisc > > > mode and forwards all packets to host. > > > > > > Since top level driver is now UCLASS_MISC, board files would need to > > > instantiate this driver explicitly. > > > > > > Signed-off-by: Vignesh Raghavendra > > > > Applied to u-boot/master, thanks! > why ? comments were not addressed. I missed that you had comments, sorry. Shall I revert this one for now? --=20 Tom --GU3/x65mZ6MFE8p3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHp7g4ACgkQFHw5/5Y0 tyyIXwv/ar7Adj+DiZ8/BOmeTWNq5kTRvx3r4Qkq7mNbp5ckk+cEi/S5agjsTfve ML5lerbip3nUtbyraVy0mZMAlvT1MITT1+1S0Oj+ja971G0IHcnxsrL/OgL623q8 h2RLIUQZ3TqVDFbVm2nSwiFro3k0aLExhiKy8VSYQIEbhO+jXcn8vMEBs9iutxw2 QGMlf6oUYIP+ElT4LRjNNmOPOj+OeUel6sO4dzNPjVkASG7vLxWKqV7R1fRcgOVw hgNkTmplzEk8UGhDHdoASlapNN/wei1uxVO5uQA3BPlp5FOD15pxGT5dzNVI+dlh tsAQ+fXIFIK8tC2AUqY9uinFGlwJwzZS9lJKbNImw9YvcrY1k8b7DI2Ze9DbqmvF uZXsm59Ly/tS7d85UdTPCuTvT4vhYbGOSwoVCea6ZlCYOdiEqx6lzVZri9U9v3TC JM1fgRG74lu239kw2udo/HnSxZpp4/abP5nW2yB+AipR0wvmRnltpO3dEZL1KuTZ 0Tu072pS =W0Ry -----END PGP SIGNATURE----- --GU3/x65mZ6MFE8p3--