Re: [PATCH] iwd: Fix station in scan callback

From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
	<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] iwd: Fix station in scan callback
Date: Fri, 21 Jan 2022 08:48:53 +0100	[thread overview]
Message-ID: <20220121074853.t3vugo7mtwtpwmcj@beryllium.lan> (raw)
In-Reply-To: <MRZP264MB1544DC10A3C17E1934D4CF0893589@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>

On Tue, Jan 18, 2022 at 10:39:34AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> The station shall be searched in stations table instead of networks.
> Fixes: 8371114aaef9 ("iwd: Hookup manual scan trigger")

Patch applied. Thanks!

> ---
>  plugins/iwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/plugins/iwd.c b/plugins/iwd.c
> index b0e17a4d6396..bb97262eff38 100644
> --- a/plugins/iwd.c
> +++ b/plugins/iwd.c
> @@ -555,7 +555,7 @@ static void cm_device_scan_cb(DBusMessage *message, void *user_data)
>  	const char *path = user_data;
>  	struct iwd_station *iwds;
>  
> -	iwds = g_hash_table_lookup(networks, path);
> +	iwds = g_hash_table_lookup(stations, path);
>  	if (!iwds)
>  		return;
>  
> -- 
> 2.25.1
> Hi Daniel,
> 
> I wish you a happy new year!

Thank you, same to you!

> It seems that I am still accountering the tabs -> spaces issue.
> I try to send the patch back in the message.

Ah, back to your MS setup, I see. Attaching the patches works. We don't
have that many patches so I can handle it.

Daniel