From: Jason Gunthorpe <jgg@nvidia.com>
To: "Li, Zhijian" <lizhijian@cn.fujitsu.com>
Cc: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"tom@talpey.com" <tom@talpey.com>,
"yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>,
"y-goto@fujitsu.com" <y-goto@fujitsu.com>,
"tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>
Subject: Re: [RFC PATCH v2 2/2] RDMA/rxe: Support RDMA Atomic Write operation
Date: Fri, 21 Jan 2022 08:58:37 -0400 [thread overview]
Message-ID: <20220121125837.GV84788@nvidia.com> (raw)
In-Reply-To: <022be340-a49a-1e94-5fb8-1c77f06fecc2@cn.fujitsu.com>
On Thu, Jan 20, 2022 at 08:07:36PM +0800, Li, Zhijian wrote:
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c
> b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 0621d387ccba..978fdd23665c 100644
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -260,7 +260,8 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64
> length, u64 iova,
> num_buf = 0;
> }
>
> - vaddr = page_address(sg_page_iter_page(&sg_iter));
> + // FIXME: don't forget to kunmap_local(vaddr)
> + vaddr = kmap_local_page(sg_page_iter_page(&sg_iter));
No, you can't leave the kmap open for a long time. The kmap has to
just be around the usage.
Jason
next prev parent reply other threads:[~2022-01-21 12:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 3:03 [RFC PATCH v2 0/2] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2022-01-13 3:03 ` [RFC PATCH v2 1/2] RDMA/rxe: Rename send_atomic_ack() and atomic member of struct resp_res Xiao Yang
2022-01-13 3:03 ` [RFC PATCH v2 2/2] RDMA/rxe: Support RDMA Atomic Write operation Xiao Yang
2022-01-13 11:35 ` kernel test robot
2022-01-13 12:16 ` kernel test robot
2022-01-13 12:16 ` kernel test robot
2022-01-17 13:16 ` Jason Gunthorpe
2022-01-18 8:01 ` yangx.jy
2022-01-18 12:35 ` Jason Gunthorpe
2022-01-19 1:54 ` lizhijian
2022-01-19 12:36 ` Jason Gunthorpe
2022-01-19 16:47 ` Ira Weiny
2022-01-20 12:07 ` Li, Zhijian
2022-01-21 12:58 ` Jason Gunthorpe [this message]
2022-01-21 16:06 ` Ira Weiny
2022-01-21 16:08 ` Ira Weiny
2022-01-24 3:47 ` lizhijian
2022-01-27 9:37 ` yangx.jy
2022-01-27 9:57 ` hch
2022-01-27 18:08 ` Ira Weiny
2022-01-28 6:16 ` hch
2022-01-28 19:15 ` Ira Weiny
2022-02-10 11:06 ` yangx.jy
2022-02-11 18:30 ` Ira Weiny
2022-01-18 8:02 ` yangx.jy
2022-01-18 8:04 ` yangx.jy
2022-01-18 9:03 ` yangx.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121125837.GV84788@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.