From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V2 00/13] block: don't drain file system I/O on del_gendisk
Date: Sat, 22 Jan 2022 19:10:41 +0800 [thread overview]
Message-ID: <20220122111054.1126146-1-ming.lei@redhat.com> (raw)
Hello,
Draining FS I/O on del_gendisk() is added for just avoiding to refer to
recently added q->disk in IO path, and it isn't actually reliable:
1) queue freezing can't drain FS I/O for bio based driver, so blk-cgroup
shutdown can't be moved into del_gendisk()
2) freezing queue can't drain in-progress IO issue/dispatch activities,
so elevator shutdown can't be moved into del_gendisk()
3) the added flag of GD_DEAD may not be observed reliably in
__bio_queue_enter() because queue freezing might not imply rcu grace
period.
4) passthrough IO accounting code can refer to q->disk after disk is
released
When releasing disk, all FS IOs are guaranteed to be done, so this
patchset tries to shutdown elevator/blk-cgroup/rq qos there, then
referring to q->disk can be avoided after disk is released.
Also add flag of BLK_MQ_REQ_USER_IO for accounting passthrough IO
only if the IO is from userspace, since disk is live for user
passthrough IO.
V2:
- take new approach to make current referring to q->disk reliable
Laibin Qiu (1):
block/wbt: fix negative inflight counter when remove scsi device
Ming Lei (12):
block: declare blkcg_[init|exit]_queue in private header
block: move initialization of q->blkg_list into blkcg_init_queue
block: move blkcg initialization/destroy into disk allocation/release
handler
block: only account passthrough IO from userspace
block: don't remove hctx debugfs dir from blk_mq_exit_queue
block: move q_usage_counter release into blk_queue_release
block: export __blk_mq_unfreeze_queue
scsi: force unfreezing queue into atomic mode
block: add helper of disk_release_queue for release queue data for
disk
block: move blk_exit_queue into disk_release
block: move rq_qos_exit() into disk_release()
block: don't drain file system I/O on del_gendisk
block/bfq-iosched.c | 2 +
block/blk-cgroup.c | 2 +
block/blk-core.c | 31 ++++----------
block/blk-mq.c | 27 ++++++++++--
block/blk-sysfs.c | 25 +-----------
block/blk.h | 10 ++++-
block/elevator.c | 2 -
block/genhd.c | 84 +++++++++++++++++++++++++++-----------
drivers/nvme/host/ioctl.c | 2 +-
drivers/scsi/scsi_ioctl.c | 3 +-
drivers/scsi/sd.c | 2 +-
include/linux/blk-cgroup.h | 4 --
include/linux/blk-mq.h | 3 ++
include/linux/genhd.h | 1 -
14 files changed, 114 insertions(+), 84 deletions(-)
--
2.31.1
next reply other threads:[~2022-01-22 11:11 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 11:10 Ming Lei [this message]
2022-01-22 11:10 ` [PATCH V2 01/13] block: declare blkcg_[init|exit]_queue in private header Ming Lei
2022-01-24 12:59 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 02/13] block: move initialization of q->blkg_list into blkcg_init_queue Ming Lei
2022-01-24 13:00 ` Christoph Hellwig
2022-01-24 18:32 ` Bart Van Assche
2022-01-22 11:10 ` [PATCH V2 03/13] block: move blkcg initialization/destroy into disk allocation/release handler Ming Lei
2022-01-24 13:02 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 04/13] block/wbt: fix negative inflight counter when remove scsi device Ming Lei
2022-02-17 7:45 ` Christoph Hellwig
2022-02-17 14:53 ` Jens Axboe
2022-01-22 11:10 ` [PATCH V2 05/13] block: only account passthrough IO from userspace Ming Lei
2022-01-24 13:05 ` Christoph Hellwig
2022-01-24 23:09 ` Ming Lei
2022-01-25 6:16 ` Christoph Hellwig
2022-01-25 7:19 ` Christoph Hellwig
2022-01-25 8:35 ` Ming Lei
2022-01-25 9:09 ` Ming Lei
2022-01-26 5:50 ` Christoph Hellwig
2022-01-26 7:21 ` Ming Lei
2022-01-26 8:10 ` Christoph Hellwig
2022-01-26 8:33 ` Ming Lei
2022-01-26 8:49 ` Christoph Hellwig
2022-01-26 9:59 ` Ming Lei
2022-01-26 16:37 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 06/13] block: don't remove hctx debugfs dir from blk_mq_exit_queue Ming Lei
2022-01-24 13:06 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 07/13] block: move q_usage_counter release into blk_queue_release Ming Lei
2022-01-24 13:09 ` Christoph Hellwig
2022-01-24 19:06 ` Bart Van Assche
2022-01-22 11:10 ` [PATCH V2 08/13] block: export __blk_mq_unfreeze_queue Ming Lei
2022-01-24 13:11 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 09/13] scsi: force unfreezing queue into atomic mode Ming Lei
2022-01-24 13:15 ` Christoph Hellwig
2022-01-24 23:21 ` Ming Lei
2022-01-25 7:27 ` Christoph Hellwig
2022-01-25 8:54 ` Ming Lei
2022-01-26 8:15 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 10/13] block: add helper of disk_release_queue for release queue data for disk Ming Lei
2022-01-24 13:16 ` Christoph Hellwig
2022-01-24 23:27 ` Ming Lei
2022-01-25 6:17 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 11/13] block: move blk_exit_queue into disk_release Ming Lei
2022-01-24 13:22 ` Christoph Hellwig
2022-01-24 23:38 ` Ming Lei
2022-01-22 11:10 ` [PATCH V2 12/13] block: move rq_qos_exit() into disk_release() Ming Lei
2022-01-24 13:28 ` Christoph Hellwig
2022-01-22 11:10 ` [PATCH V2 13/13] block: don't drain file system I/O on del_gendisk Ming Lei
2022-01-24 13:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122111054.1126146-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.