Re: [net RFC v1 1/1] page_pool: fix NULL dereference crash

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [net RFC v1 1/1] page_pool: fix NULL dereference crash
Date: Sat, 22 Jan 2022 11:15:50 +0800	[thread overview]
Message-ID: <202201221122.LOf7DZi6-lkp@intel.com> (raw)
In-Reply-To: <20220122005644.802352-2-colin.foster@in-advantage.com>

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

Hi Colin,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Colin-Foster/Fix-NULL-pointer-dereference-in-page_pool/20220122-085826
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 03c82e80ec283b115c56026ecdb95c901a57c51e
config: arc-randconfig-r043-20220122 (https://download.01.org/0day-ci/archive/20220122/202201221122.LOf7DZi6-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6b2d9e5c2901873c8bba988d4db6cd5bfbaaeec4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Colin-Foster/Fix-NULL-pointer-dereference-in-page_pool/20220122-085826
        git checkout 6b2d9e5c2901873c8bba988d4db6cd5bfbaaeec4
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/core/page_pool.c: In function 'page_pool_set_pp_info':
>> net/core/page_pool.c:216:13: error: used struct type value where scalar is required
     216 |         if (pool->p && pool->p.init_callback)
         |             ^~~~

vim +216 net/core/page_pool.c

   210	
   211	static void page_pool_set_pp_info(struct page_pool *pool,
   212					  struct page *page)
   213	{
   214		page->pp = pool;
   215		page->pp_magic |= PP_SIGNATURE;
 > 216		if (pool->p && pool->p.init_callback)
   217			pool->p.init_callback(page, pool->p.init_arg);
   218	}
   219	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org