From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script
Date: Sat, 22 Jan 2022 15:11:30 +0100 [thread overview]
Message-ID: <20220122151130.59ae7148@windsurf> (raw)
In-Reply-To: <20220117080616.10563-1-heiko.thiery@gmail.com>
On Mon, 17 Jan 2022 09:06:16 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> board/kontron/pitx-imx8m/boot.cmd | 8 --------
> board/kontron/pitx-imx8m/extlinux.conf | 4 ++++
> board/kontron/pitx-imx8m/genimage.cfg | 5 +++--
> board/kontron/pitx-imx8m/post-build.sh | 7 +++++--
> board/kontron/pitx-imx8m/post-image.sh | 2 +-
> configs/kontron_pitx_imx8m_defconfig | 3 +--
> 6 files changed, 14 insertions(+), 15 deletions(-)
> delete mode 100644 board/kontron/pitx-imx8m/boot.cmd
> create mode 100644 board/kontron/pitx-imx8m/extlinux.conf
I have applied, but I am a bit worried about things are going on with
this switch to extlinux.conf.
Indeed, we have:
* Platforms where the UUID is hardcoded into genimage.cfg and
extlinux.conf, such as board/beaglev/
* We have platforms where a "uuid" variable in filled in U-Boot before
triggering the extlinux.conf logic, and therefore extlinux.conf uses
root=PARTUUID=${uuid}. For example
board/freescale/imx7dsdb/rootfs_overlay/boot/extlinux/extlinux.conf,
board/orangepi/orangepi-zero/boot.cmd,
board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf,
board/technexion/imx6ulpico/rootfs_overlay/boot/extlinux/extlinux.conf,
and a few others.
* We now have platforms (kontron/smarc-sal28 and kontron/pitx-imx8m)
where a random UUID is generated in the post-build script, and used
in genimage and extlinux.conf.
I'm not sure where we want to go, and how much we want to enforce "best
practices" that are common on all platforms, or just let each platform
do its little business.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-22 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 8:06 [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script Heiko Thiery
2022-01-17 8:06 ` [Buildroot] [PATCH 2/2] configs/kontron_pitx_imx8m_defconfig: bump kernel to 5.16.1 Heiko Thiery
2022-01-22 14:11 ` Thomas Petazzoni
2022-01-22 14:11 ` Thomas Petazzoni [this message]
2022-01-22 15:59 ` [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script Heiko Thiery
2022-01-23 22:01 ` Giulio Benetti
2022-01-24 5:42 ` Sergey Kuzminov
2022-01-24 8:12 ` Giulio Benetti
2022-02-12 13:50 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122151130.59ae7148@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=heiko.thiery@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.