From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD97C433EF for ; Mon, 24 Jan 2022 10:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235859AbiAXKlx (ORCPT ); Mon, 24 Jan 2022 05:41:53 -0500 Received: from foss.arm.com ([217.140.110.172]:57228 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231843AbiAXKlx (ORCPT ); Mon, 24 Jan 2022 05:41:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDE606D; Mon, 24 Jan 2022 02:41:52 -0800 (PST) Received: from bogus (unknown [10.57.34.236]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E97D3F73B; Mon, 24 Jan 2022 02:41:48 -0800 (PST) Date: Mon, 24 Jan 2022 10:41:13 +0000 From: Sudeep Holla To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Sudeep Holla , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , "Rafael J. Wysocki" , Viresh Kumar , Cristian Marussi , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 16/54] cpufreq: replace cpumask_weight with cpumask_empty where appropriate Message-ID: <20220124104113.ccbcyipd5gtweulz@bogus> References: <20220123183925.1052919-1-yury.norov@gmail.com> <20220123183925.1052919-17-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220123183925.1052919-17-yury.norov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, Jan 23, 2022 at 10:38:47AM -0800, Yury Norov wrote: > drivers/cpufreq calls cpumask_weight() to check if any bit of a given > cpumask is set. We can do it more efficiently with cpumask_empty() because > cpumask_empty() stops traversing the cpumask as soon as it finds first set > bit, while cpumask_weight() counts all bits unconditionally. > Reviewed-by: Sudeep Holla (for SCMI cpufreq driver) -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E01FC433EF for ; Mon, 24 Jan 2022 10:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sfitjbhHiETmLcBzyXeZyudlICPuhCjZ8VDD3AHiDCI=; b=DB+96UQdLO4G2M w50MMetiVcOKKmYtgpUe7Uq1mN4bsARHN4seb1kxTBBU0kfcSIeyR+JhXJ/gO7aGy81pbg0+8owfc zvKbuHy9gT5UfN7A+DPedTMqP34u8NeiCcQBc87udlwcy4r5FmIRDaRNPeor05HsXD6H8Rkh3Lu37 BvWmHI1asYfhEaKlLBQNFk1JieAAof/cZFJKrlwV0F42a9Ew3Mk3dCb4ZRa8kfCF1kow+KmtYVVqB KnmeMlpDhNXv37VqoYe0NHGLd1xffMBWDKUr6LLdzaL4kShjQ95aps8HGH3Q280lIpudS/9En3fd1 9MJjxlsbtELboM8Cmm2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBwnV-0030HU-4Z; Mon, 24 Jan 2022 10:42:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBwnR-0030EQ-Qx for linux-arm-kernel@lists.infradead.org; Mon, 24 Jan 2022 10:42:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDE606D; Mon, 24 Jan 2022 02:41:52 -0800 (PST) Received: from bogus (unknown [10.57.34.236]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E97D3F73B; Mon, 24 Jan 2022 02:41:48 -0800 (PST) Date: Mon, 24 Jan 2022 10:41:13 +0000 From: Sudeep Holla To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Sudeep Holla , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , "Rafael J. Wysocki" , Viresh Kumar , Cristian Marussi , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 16/54] cpufreq: replace cpumask_weight with cpumask_empty where appropriate Message-ID: <20220124104113.ccbcyipd5gtweulz@bogus> References: <20220123183925.1052919-1-yury.norov@gmail.com> <20220123183925.1052919-17-yury.norov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220123183925.1052919-17-yury.norov@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_024201_945720_69CF4575 X-CRM114-Status: UNSURE ( 7.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 23, 2022 at 10:38:47AM -0800, Yury Norov wrote: > drivers/cpufreq calls cpumask_weight() to check if any bit of a given > cpumask is set. We can do it more efficiently with cpumask_empty() because > cpumask_empty() stops traversing the cpumask as soon as it finds first set > bit, while cpumask_weight() counts all bits unconditionally. > Reviewed-by: Sudeep Holla (for SCMI cpufreq driver) -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel