All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <liviu.dudau@foss.arm.com>,
	Simon Glass <sjg@chromium.org>, Marek Vasut <marex@denx.de>,
	Ross Burton <ross.burton@arm.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH] vexpress64: semi_defconfig: disable CRC32 support
Date: Mon, 24 Jan 2022 11:54:10 -0500	[thread overview]
Message-ID: <20220124165410.GF7515@bill-the-cat> (raw)
In-Reply-To: <20220121163604.2503548-1-andre.przywara@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

On Fri, Jan 21, 2022 at 04:36:04PM +0000, Andre Przywara wrote:

> Commit 270f8710f92f ("crc32: Add crc32 implementation using
> __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions
> by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A
> cores support the instructions, and they are mandatory starting with
> architecture revision v8.1, so realistically every known hardware
> implementation should support them.
> 
> The Arm Fastmodel however defaults to the bare minimum ARMv8 feature set
> by default, which means v8.0 without the CRC instructions, so U-Boot
> hangs very early at the moment, without any output (the boot-wrapper or
> TF-A printing the last visible lines).
> 
> Support for those instructions can be enabled on the model command line
> by either:
> -C cluster0.cpu0.enable_crc32=1		(for each core)
> or by using a higher architecture revision by default:
> -C cluster0.has_arm_v8-1=1		(for each cluster)
> Of course any arch revision higher than v8.1 would work as well.
> 
> But for the sake of a smooth out-of-the-box experience, let's just
> disable the usage of those instructions in the defconfig, to avoid
> random hangs without any clues.
> 
> Reported-by: Ross Burton <ross.burton@arm.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

      parent reply	other threads:[~2022-01-24 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21 16:36 [PATCH] vexpress64: semi_defconfig: disable CRC32 support Andre Przywara
2022-01-21 16:53 ` Marek Vasut
2022-01-24 16:54 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220124165410.GF7515@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=andre.przywara@arm.com \
    --cc=linus.walleij@linaro.org \
    --cc=liviu.dudau@foss.arm.com \
    --cc=marex@denx.de \
    --cc=ross.burton@arm.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.