From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13411C43217 for ; Mon, 24 Jan 2022 16:55:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243969AbiAXQzj (ORCPT ); Mon, 24 Jan 2022 11:55:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243970AbiAXQzi (ORCPT ); Mon, 24 Jan 2022 11:55:38 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79AA3C061401 for ; Mon, 24 Jan 2022 08:55:38 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id s5so23060697ejx.2 for ; Mon, 24 Jan 2022 08:55:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=udfeJeFdx79BvfFLrEjgmFb8M0Tn21AoYYUBDKALlWc=; b=UzcDcwTvS13I+piOHSwWQhmPbTITcxNsS5npXnenI8oDfSriT0Hw5m8qi9nxNStSsg 9ucHVE3dujYHwEVKbZ2ULnepfaP8IcqatFkS4NGisX5Uv1+s8eEjHp88HSGAcRdbeSG1 r3Pxz4uk8kpO8xdUlK3PZ7j2lL4lFeC9iTmmNkgdlSPY9HmFZqxe5oxzf+ZiJKxnMlgy fm/5RG7JyccAlZHfTooDE//2I66+s1pXU1YrBbCA9RveaDWAAIIw4mXQbRbzxQo4Xcyb GTmADfXLHNeWhbUbfJ30Z4oIKIubP68GA8+LTYxsng6FEc8reH3h2r0THb70Ec8tTwsT qvEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=udfeJeFdx79BvfFLrEjgmFb8M0Tn21AoYYUBDKALlWc=; b=cfXLyKHv7/WieKzP498uSvOqdhPVmQKcqvWti4GRmeI2SYpO1JerPJ3p46yucMyUbe gHxJ4yTy0gqj6OYexQvU65L3wCpZsUhGP29nG2NHOxHn38IU8ygPwog6as0T4VtgWv8+ s4SNjJM74BQJlEk/MMGk3SXWQSNFv46FW+QQPywRNnbsnA7G3gATAVSUXxJKKxOnj4vg L5tHU3ijSuKVb8Rk5glpHFDFPdiz30XRX4TRIvx5D+MKALC+m3Q8Ku93vngYqRp2FCMa 3tRsTrPRh3Ig7zgqBSLQS2LIUUNJ5A9B6bjatV6Jl6/U468W9aih8bTA47ZO/bBuCl30 7Dpg== X-Gm-Message-State: AOAM530uwZDRTW3x9FD0Pf6SPGg0XiXwAKoueGoJRZvLbG6q2wYxMdgO D2HqhHltHwxj2N+A0eebAJw= X-Google-Smtp-Source: ABdhPJyIgAt/nePvCd0KfJuDllTZ3BZE8cTr1h07QAQ/oXOtGcTUZl1OILI02qgMbLDsprSvKGteEA== X-Received: by 2002:a17:906:9b8e:: with SMTP id dd14mr1651283ejc.413.1643043337067; Mon, 24 Jan 2022 08:55:37 -0800 (PST) Received: from skbuf ([188.25.255.2]) by smtp.gmail.com with ESMTPSA id c22sm2061624eds.72.2022.01.24.08.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 08:55:36 -0800 (PST) Date: Mon, 24 Jan 2022 18:55:35 +0200 From: Vladimir Oltean To: Jakub Kicinski Cc: Luiz Angelo Daros de Luca , Andrew Lunn , Frank Wunderlich , Alvin =?utf-8?Q?=C5=A0ipraga?= , "netdev@vger.kernel.org" , "linus.walleij@linaro.org" , "vivien.didelot@gmail.com" , "f.fainelli@gmail.com" , "arinc.unal@arinc9.com" Subject: Re: [PATCH net-next v4 11/11] net: dsa: realtek: rtl8365mb: multiple cpu ports, non cpu extint Message-ID: <20220124165535.tksp4aayeaww7mbf@skbuf> References: <20220120151222.dirhmsfyoumykalk@skbuf> <20220121020627.spli3diixw7uxurr@skbuf> <20220121185009.pfkh5kbejhj5o5cs@skbuf> <20220121224949.xb3ra3qohlvoldol@skbuf> <20220124153147.agpxxune53crfawy@skbuf> <20220124084649.0918ba5c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124084649.0918ba5c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 24, 2022 at 08:46:49AM -0800, Jakub Kicinski wrote: > I thought for drivers setting the legacy NETIF_F_IP*_CSUM feature > it's driver's responsibility to validate the geometry of the packet > will work with the parser the device has. Or at least I think that's > what Tom was pushing for when he was cleaning up the checksumming last > (and wrote the long comment on the subject in skbuff.h). Sorry Jakub, I don't understand what you mean to say when applied to the context discussed here?