From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BA6C433F5 for ; Mon, 24 Jan 2022 17:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235398AbiAXRs3 (ORCPT ); Mon, 24 Jan 2022 12:48:29 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:43452 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241340AbiAXRs2 (ORCPT ); Mon, 24 Jan 2022 12:48:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E297C612FC for ; Mon, 24 Jan 2022 17:48:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E611C340EA; Mon, 24 Jan 2022 17:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643046507; bh=gslX7T5TrnrvLT9MZy1Flj2WrIS21TNN7skRYLf2cB4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u+a5guIYJlWG0aQFL6ayUD51PzanAJgDDgnDfW4LDhKjBHpJPfBnyNTp7CodzotYt j+43QO7ApP7aTNE0aGiO+yNDOjriTcSTJRFCIUtpCmhlk/TtQntCrhyjbqjAg59Cug 7J8VI7jGjsu+XOPtimzzNle0oJKjKJh54l0ScMqVCAPi6+35CL5ZTLUDzFpPMB7gA9 DGn/DBSfpm7LizBGy13UMCG3xBraowXXOdPZ4UtgnTt9WaO5Jhmn49a/3zhVcqymwO Au1LJImb7idCjPN8j2OomvVvJOJkll6BvUsbe3eR4BqKRWxiy4G62Rn3HtDTovwHmo l/1fyL2wNBLgA== From: Ard Biesheuvel To: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Cc: linux-hardening@vger.kernel.org, Ard Biesheuvel , Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , Tony Lindgren , Marc Zyngier , Vladimir Murzin , Jesse Taube Subject: [PATCH v5 10/32] ARM: entry: preserve thread_info pointer in switch_to Date: Mon, 24 Jan 2022 18:47:22 +0100 Message-Id: <20220124174744.1054712-11-ardb@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174744.1054712-1-ardb@kernel.org> References: <20220124174744.1054712-1-ardb@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2194; h=from:subject; bh=gslX7T5TrnrvLT9MZy1Flj2WrIS21TNN7skRYLf2cB4=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBh7uYViXFUcknkrsWItgSrA5jHKmMET02bvqQS6Nlf hymjRTOJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYe7mFQAKCRDDTyI5ktmPJDsfC/ 9zjEN2ZvHm9mEpB4TxzHpRwKwUGhOBMrdIKOLOP02+8pK9cgRhfsTFQ1xdecWiVUocIxcYbX8Va8ab bHudQRdStxiniZH5BCgDRQQSjvbpBkXYM6AMqMydSFebuOfjgGRYfPctGRv1J/w96+Fort9W3hL1vD AgiC2oTKLzFRru112J2nmm6gLsy6+qcPnCsy6VmfJI2gRXp6YZbduuw+V1K96HOK9B1xLmmeAfljR6 ZR79XLrUQm/VVkPf3AOsz9bzXpeVy7g6Tgl3dnK8HyrhcAHxBf8MCRV6KTEeKfBEaSGAP/U+N5cyc+ 4cLRgVCp9xNlqlriYw6jBoox09IWj043Kak4TimBXeoPtTPceF8uaJFXDkalB+nbstVZ1QxNFdt9jJ AjaN7h6ubhXSZShzzmqzMTKl0Kw6AE0Cx/Q9qunERV8XgBRbwsieOsbVCbFyr3Gf7Q9LnM5k/dCIt9 ptLw7MJhF148+gi9L3l0iten9uINUfYSu8MJnnIG6eOXw= X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Tweak the UP stack protector handling code so that the thread info pointer is preserved in R7 until set_current is called. This is needed for a subsequent patch that implements THREAD_INFO_IN_TASK and set_current for UP as well. This also means we will prefer the per-task protector on UP systems that implement the thread ID registers, so tweak the preprocessor conditionals to reflect this. Acked-by: Linus Walleij Acked-by: Nicolas Pitre Signed-off-by: Ard Biesheuvel Tested-by: Marc Zyngier Tested-by: Vladimir Murzin # ARMv7M --- arch/arm/kernel/entry-armv.S | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S index 9d9372781408..5e01a34369a0 100644 --- a/arch/arm/kernel/entry-armv.S +++ b/arch/arm/kernel/entry-armv.S @@ -744,16 +744,16 @@ ENTRY(__switch_to) ldr r6, [r2, #TI_CPU_DOMAIN] #endif switch_tls r1, r4, r5, r3, r7 -#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) - ldr r7, [r2, #TI_TASK] +#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) && \ + !defined(CONFIG_STACKPROTECTOR_PER_TASK) + ldr r9, [r2, #TI_TASK] ldr r8, =__stack_chk_guard .if (TSK_STACK_CANARY > IMM12_MASK) - add r7, r7, #TSK_STACK_CANARY & ~IMM12_MASK + add r9, r9, #TSK_STACK_CANARY & ~IMM12_MASK .endif - ldr r7, [r7, #TSK_STACK_CANARY & IMM12_MASK] -#elif defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) - mov r7, r2 @ Preserve 'next' + ldr r9, [r9, #TSK_STACK_CANARY & IMM12_MASK] #endif + mov r7, r2 @ Preserve 'next' #ifdef CONFIG_CPU_USE_DOMAINS mcr p15, 0, r6, c3, c0, 0 @ Set domain register #endif @@ -762,8 +762,9 @@ ENTRY(__switch_to) ldr r0, =thread_notify_head mov r1, #THREAD_NOTIFY_SWITCH bl atomic_notifier_call_chain -#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) - str r7, [r8] +#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) && \ + !defined(CONFIG_STACKPROTECTOR_PER_TASK) + str r9, [r8] #endif THUMB( mov ip, r4 ) mov r0, r5 -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EB4FC433F5 for ; Mon, 24 Jan 2022 17:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NUtmJ2GiMPr7Ehq3nTtbbuQ8Ju6SGwC3srA3UDjd73g=; b=UVZfh+N/2gD2zg epC2NR4AdxZOOhg/PfymFObmBJZlSWsbCcuXyPgV/K5KuR0egXeIReMdGsQh88g9H19xIvZlvFrYz JBWB/fEj6KFWLpZRbEsTo05KnOSXhaXho9v9xXpOy/jLughEdZq7EwsaWxFzbdZvpxpHvFwy3at8D ybYMlhJ/ZWf1p7SIM9Y3wREFsrjLpNpc7H1KKhkBXx6I2UIf5HTOzZMPRyBCco0SB2tCqmj6qw1h4 0kkO81Tu6oAp884teGrSphcXAwvM5GwzAv5qyPdwL1DpkS2kxSaIDm2sCwL/E3eQETrfb6xRQe6Jf BPKpFnZVz8cVfCUiYZWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC3Vj-004H2C-ST; Mon, 24 Jan 2022 17:52:12 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC3S9-004FHR-SX for linux-arm-kernel@lists.infradead.org; Mon, 24 Jan 2022 17:48:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9214EB811A5; Mon, 24 Jan 2022 17:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E611C340EA; Mon, 24 Jan 2022 17:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643046507; bh=gslX7T5TrnrvLT9MZy1Flj2WrIS21TNN7skRYLf2cB4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u+a5guIYJlWG0aQFL6ayUD51PzanAJgDDgnDfW4LDhKjBHpJPfBnyNTp7CodzotYt j+43QO7ApP7aTNE0aGiO+yNDOjriTcSTJRFCIUtpCmhlk/TtQntCrhyjbqjAg59Cug 7J8VI7jGjsu+XOPtimzzNle0oJKjKJh54l0ScMqVCAPi6+35CL5ZTLUDzFpPMB7gA9 DGn/DBSfpm7LizBGy13UMCG3xBraowXXOdPZ4UtgnTt9WaO5Jhmn49a/3zhVcqymwO Au1LJImb7idCjPN8j2OomvVvJOJkll6BvUsbe3eR4BqKRWxiy4G62Rn3HtDTovwHmo l/1fyL2wNBLgA== From: Ard Biesheuvel To: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Cc: linux-hardening@vger.kernel.org, Ard Biesheuvel , Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , Tony Lindgren , Marc Zyngier , Vladimir Murzin , Jesse Taube Subject: [PATCH v5 10/32] ARM: entry: preserve thread_info pointer in switch_to Date: Mon, 24 Jan 2022 18:47:22 +0100 Message-Id: <20220124174744.1054712-11-ardb@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174744.1054712-1-ardb@kernel.org> References: <20220124174744.1054712-1-ardb@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2194; h=from:subject; bh=gslX7T5TrnrvLT9MZy1Flj2WrIS21TNN7skRYLf2cB4=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBh7uYViXFUcknkrsWItgSrA5jHKmMET02bvqQS6Nlf hymjRTOJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYe7mFQAKCRDDTyI5ktmPJDsfC/ 9zjEN2ZvHm9mEpB4TxzHpRwKwUGhOBMrdIKOLOP02+8pK9cgRhfsTFQ1xdecWiVUocIxcYbX8Va8ab bHudQRdStxiniZH5BCgDRQQSjvbpBkXYM6AMqMydSFebuOfjgGRYfPctGRv1J/w96+Fort9W3hL1vD AgiC2oTKLzFRru112J2nmm6gLsy6+qcPnCsy6VmfJI2gRXp6YZbduuw+V1K96HOK9B1xLmmeAfljR6 ZR79XLrUQm/VVkPf3AOsz9bzXpeVy7g6Tgl3dnK8HyrhcAHxBf8MCRV6KTEeKfBEaSGAP/U+N5cyc+ 4cLRgVCp9xNlqlriYw6jBoox09IWj043Kak4TimBXeoPtTPceF8uaJFXDkalB+nbstVZ1QxNFdt9jJ AjaN7h6ubhXSZShzzmqzMTKl0Kw6AE0Cx/Q9qunERV8XgBRbwsieOsbVCbFyr3Gf7Q9LnM5k/dCIt9 ptLw7MJhF148+gi9L3l0iten9uINUfYSu8MJnnIG6eOXw= X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_094830_246979_0E582DC4 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tweak the UP stack protector handling code so that the thread info pointer is preserved in R7 until set_current is called. This is needed for a subsequent patch that implements THREAD_INFO_IN_TASK and set_current for UP as well. This also means we will prefer the per-task protector on UP systems that implement the thread ID registers, so tweak the preprocessor conditionals to reflect this. Acked-by: Linus Walleij Acked-by: Nicolas Pitre Signed-off-by: Ard Biesheuvel Tested-by: Marc Zyngier Tested-by: Vladimir Murzin # ARMv7M --- arch/arm/kernel/entry-armv.S | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S index 9d9372781408..5e01a34369a0 100644 --- a/arch/arm/kernel/entry-armv.S +++ b/arch/arm/kernel/entry-armv.S @@ -744,16 +744,16 @@ ENTRY(__switch_to) ldr r6, [r2, #TI_CPU_DOMAIN] #endif switch_tls r1, r4, r5, r3, r7 -#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) - ldr r7, [r2, #TI_TASK] +#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) && \ + !defined(CONFIG_STACKPROTECTOR_PER_TASK) + ldr r9, [r2, #TI_TASK] ldr r8, =__stack_chk_guard .if (TSK_STACK_CANARY > IMM12_MASK) - add r7, r7, #TSK_STACK_CANARY & ~IMM12_MASK + add r9, r9, #TSK_STACK_CANARY & ~IMM12_MASK .endif - ldr r7, [r7, #TSK_STACK_CANARY & IMM12_MASK] -#elif defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) - mov r7, r2 @ Preserve 'next' + ldr r9, [r9, #TSK_STACK_CANARY & IMM12_MASK] #endif + mov r7, r2 @ Preserve 'next' #ifdef CONFIG_CPU_USE_DOMAINS mcr p15, 0, r6, c3, c0, 0 @ Set domain register #endif @@ -762,8 +762,9 @@ ENTRY(__switch_to) ldr r0, =thread_notify_head mov r1, #THREAD_NOTIFY_SWITCH bl atomic_notifier_call_chain -#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) - str r7, [r8] +#if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_SMP) && \ + !defined(CONFIG_STACKPROTECTOR_PER_TASK) + str r9, [r8] #endif THUMB( mov ip, r4 ) mov r0, r5 -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel