All of
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <>
To: John Johansen <>,
	James Morris <>,
	"Serge E. Hallyn" <>
	"Gustavo A. R. Silva" <>,
Subject: [PATCH][next] apparmor: Use struct_size() helper in kmalloc()
Date: Mon, 24 Jan 2022 19:56:06 -0600	[thread overview]
Message-ID: <20220125015606.GA28243@embeddedor> (raw)

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
security/apparmor/lib.c:139:23: warning: using sizeof on a flexible structure

Signed-off-by: Gustavo A. R. Silva <>
 security/apparmor/lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/lib.c b/security/apparmor/lib.c
index fa49b81eb54c..5eda003c0d45 100644
--- a/security/apparmor/lib.c
+++ b/security/apparmor/lib.c
@@ -136,7 +136,7 @@ __counted char *aa_str_alloc(int size, gfp_t gfp)
 	struct counted_str *str;
-	str = kmalloc(sizeof(struct counted_str) + size, gfp);
+	str = kmalloc(struct_size(str, name, size), gfp);
 	if (!str)
 		return NULL;

             reply	other threads:[~2022-01-25  3:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  1:56 Gustavo A. R. Silva [this message]
2022-01-26  9:30 ` [PATCH][next] apparmor: Use struct_size() helper in kmalloc() John Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125015606.GA28243@embeddedor \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.