All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: berrange@redhat.com, ehabkost@redhat.com, konrad.wilk@oracle.com,
	qemu-devel@nongnu.org, pbonzini@redhat.com,
	Ani Sinha <ani@anisinha.ca>,
	imammedo@redhat.com, boris.ostrovsky@oracle.com, rth@twiddle.net
Subject: Re: [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table
Date: Wed, 26 Jan 2022 02:41:34 -0500	[thread overview]
Message-ID: <20220126023940-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <4c680569-bca2-c85b-b0e0-0cfbb5c158fc@oracle.com>

On Tue, Jan 25, 2022 at 10:24:49AM -0600, Eric DeVolder wrote:
> And here is what the main snippet looks like with the above changes (a diff
> is quite messy):
> 
>     /*
>      * Macros for use with construction of the action instructions
>      */
> #define BUILD_READ_VALUE(width_in_bits) \
>     build_serialization_instruction_entry(table_instruction_data, \
>         action, INST_READ_REGISTER, 0, width_in_bits, \
>         bar0 + ERST_VALUE_OFFSET, 0)
> 
> #define BUILD_READ_VALUE_VALUE(width_in_bits, value) \
>     build_serialization_instruction_entry(table_instruction_data, \
>         action, INST_READ_REGISTER_VALUE, 0, width_in_bits, \
>         bar0 + ERST_VALUE_OFFSET, value)
> 
> #define BUILD_WRITE_REGISTER(width_in_bits, reg, value) \
>     build_serialization_instruction_entry(table_instruction_data, \
>         action, INST_WRITE_REGISTER, 0, width_in_bits, \
>         bar0 + reg, value)
> 
> #define BUILD_WRITE_REGISTER_VALUE(width_in_bits, reg, value) \
>     build_serialization_instruction_entry(table_instruction_data, \
>         action, INST_WRITE_REGISTER_VALUE, 0, width_in_bits, \
>         bar0 + reg, value)

Please, don't hide variable accesses in macros like that.
whatever is accessed should be part of a parameter.

-- 
MST



  parent reply	other threads:[~2022-01-26  7:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 17:16 [PATCH v13 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2 Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 02/10] ACPI ERST: specification for ERST support Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 03/10] ACPI ERST: PCI device_id for ERST Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 04/10] ACPI ERST: header file " Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 05/10] ACPI ERST: support for ACPI ERST feature Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 06/10] ACPI ERST: build the ACPI ERST table Eric DeVolder
2022-01-25 10:53   ` Ani Sinha
2022-01-25 12:05     ` Michael S. Tsirkin
2022-01-25 12:21       ` Ani Sinha
2022-01-25 16:32       ` Eric DeVolder
2022-01-25 17:29         ` Michael S. Tsirkin
2022-01-25 16:24     ` Eric DeVolder
2022-01-25 17:58       ` Michael S. Tsirkin
2022-01-26  7:05       ` Ani Sinha
2022-01-26 16:23         ` Eric DeVolder
2022-01-26  7:41       ` Michael S. Tsirkin [this message]
2022-01-24 17:16 ` [PATCH v13 07/10] ACPI ERST: create ACPI ERST table for pc/x86 machines Eric DeVolder
2022-01-24 17:16 ` [PATCH v13 08/10] ACPI ERST: qtest for ERST Eric DeVolder
2022-01-24 17:17 ` [PATCH v13 09/10] ACPI ERST: bios-tables-test testcase Eric DeVolder
2022-01-24 17:17 ` [PATCH v13 10/10] ACPI ERST: step 6 of bios-tables-test.c Eric DeVolder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220126023940-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=berrange@redhat.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ehabkost@redhat.com \
    --cc=eric.devolder@oracle.com \
    --cc=imammedo@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.