From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7024711110502383033==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Wed, 26 Jan 2022 20:42:42 +0800 Message-ID: <20220126124242.GA843@bed3719421c5> In-Reply-To: <202201262026.Pkq71lt4-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============7024711110502383033== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Alessandro Zummo CC: Alexandre Belloni CC: linux-rtc(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/rtc/rtc-lp8788.c:277:8-33: WARNING: Threaded IRQ with no primary ha= ndler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 18 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! rtc-lp8788.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/rtc/rtc-lp8788.c +++ b/drivers/rtc/rtc-lp8788.c @@ -276,7 +276,7 @@ static int lp8788_alarm_irq_register(str = return devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, lp8788_alarm_irq_handler, - 0, LP8788_ALM_IRQ, rtc); + IRQF_ONESHOT, LP8788_ALM_IRQ, rtc); } = static int lp8788_rtc_probe(struct platform_device *pdev) --===============7024711110502383033==--