From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Only include i915_reg.h from .c files
Date: Wed, 26 Jan 2022 14:35:19 -0800 [thread overview]
Message-ID: <20220126223519.q4oii4mdvwhpfiue@ldmartin-desk2> (raw)
In-Reply-To: <20220125020826.2693097-7-matthew.d.roper@intel.com>
On Mon, Jan 24, 2022 at 06:08:26PM -0800, Matt Roper wrote:
>Several of our i915 header files, have been including i915_reg.h. This
>means that any change to i915_reg.h will trigger a full rebuild of
>pretty much every file of the driver, even those that don't have any
>kind of register access. Let's delete the i915_reg.h include from all
>headers and include an explicit include from the .c files that truly
if you're going to respin this or while applying, it may be good to
reword this sentence as we have too many "include".
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
next prev parent reply other threads:[~2022-01-26 22:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 2:08 [Intel-gfx] [PATCH v2 0/6] Second round of i915_reg.h splitting Matt Roper
2022-01-25 2:08 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/perf: Move OA regs to their own header Matt Roper
2022-01-26 22:08 ` Lucas De Marchi
2022-01-25 2:08 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/perf: Express OA register ranges with i915_range Matt Roper
2022-01-26 22:19 ` Lucas De Marchi
2022-01-27 21:28 ` Umesh Nerlige Ramappa
2022-01-25 2:08 ` [Intel-gfx] [PATCH v2 3/6] drm/i915: Parameterize R_PWR_CLK_STATE register definition Matt Roper
2022-01-26 22:19 ` Lucas De Marchi
2022-01-25 2:08 ` [Intel-gfx] [PATCH v2 4/6] drm/i915: Parameterize MI_PREDICATE registers Matt Roper
2022-01-26 22:23 ` Lucas De Marchi
2022-01-25 2:08 ` [Intel-gfx] [PATCH v2 5/6] drm/i915: Move GT registers to their own header file Matt Roper
2022-01-26 22:31 ` Lucas De Marchi
2022-01-25 2:08 ` [Intel-gfx] [PATCH v2 6/6] drm/i915: Only include i915_reg.h from .c files Matt Roper
2022-01-26 22:35 ` Lucas De Marchi [this message]
2022-01-25 2:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Second round of i915_reg.h splitting (rev2) Patchwork
2022-01-25 2:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-25 3:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-25 8:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126223519.q4oii4mdvwhpfiue@ldmartin-desk2 \
--to=lucas.demarchi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.