All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <robert.hancock@calian.com>
To: linux-usb@vger.kernel.org
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
	michal.simek@xilinx.com, manish.narani@xilinx.com,
	sean.anderson@seco.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org, piyush.mehta@xilinx.com,
	Robert Hancock <robert.hancock@calian.com>
Subject: [PATCH v8 1/3] usb: dwc3: xilinx: fix uninitialized return value
Date: Wed, 26 Jan 2022 17:40:15 -0600	[thread overview]
Message-ID: <20220126234017.3619108-2-robert.hancock@calian.com> (raw)
In-Reply-To: <20220126234017.3619108-1-robert.hancock@calian.com>

A previous patch to skip part of the initialization when a USB3 PHY was
not present could result in the return value being uninitialized in that
case, causing spurious probe failures. Initialize ret to 0 to avoid this.

Fixes: 9678f3361afc ("usb: dwc3: xilinx: Skip resets and USB3 register settings for USB2.0 mode")
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
---
 drivers/usb/dwc3/dwc3-xilinx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index e14ac15e24c3..a6f3a9b38789 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -99,7 +99,7 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv_data)
 	struct device		*dev = priv_data->dev;
 	struct reset_control	*crst, *hibrst, *apbrst;
 	struct phy		*usb3_phy;
-	int			ret;
+	int			ret = 0;
 	u32			reg;
 
 	usb3_phy = devm_phy_optional_get(dev, "usb3-phy");
-- 
2.31.1


  reply	other threads:[~2022-01-26 23:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 23:40 [PATCH v8 0/3] Xilinx ZynqMP USB fixes Robert Hancock
2022-01-26 23:40 ` Robert Hancock [this message]
2022-01-26 23:40 ` [PATCH v8 2/3] dt-bindings: usb: dwc3-xilinx: Added reset-gpios Robert Hancock
2022-02-02  0:58   ` Rob Herring
2022-01-26 23:40 ` [PATCH v8 3/3] usb: dwc3: xilinx: Add ULPI PHY reset handling Robert Hancock
2022-01-27 20:10   ` Sean Anderson
2022-01-27 21:45     ` Robert Hancock
2022-02-09 16:56   ` Piyush Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220126234017.3619108-2-robert.hancock@calian.com \
    --to=robert.hancock@calian.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=michal.simek@xilinx.com \
    --cc=piyush.mehta@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.anderson@seco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.