All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support
Date: Thu, 27 Jan 2022 09:52:00 +0800	[thread overview]
Message-ID: <202201270923.FG90uMou-lkp@intel.com> (raw)
In-Reply-To: <20220126233454.3362047-4-eranian@google.com>

[-- Attachment #1: Type: text/plain, Size: 2481 bytes --]

Hi Stephane,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20220125]
[cannot apply to tip/x86/core rafael-pm/linux-next tip/perf/core v5.17-rc1 v5.16 v5.16-rc8 v5.17-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stephane-Eranian/perf-core-add-perf_clear_branch_entry_bitfields-helper/20220127-083516
base:    d25ee88530253138d0b20d43511ca5acbda4e9f7
config: i386-buildonly-randconfig-r002-20220124 (https://download.01.org/0day-ci/archive/20220127/202201270923.FG90uMou-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/933d072f6e0c0409115a8038a89a56979a042d30
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stephane-Eranian/perf-core-add-perf_clear_branch_entry_bitfields-helper/20220127-083516
        git checkout 933d072f6e0c0409115a8038a89a56979a042d30
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/events/amd/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/x86/events/amd/core.c: In function 'amd_pmu_enable_all':
>> arch/x86/events/amd/core.c:676:24: warning: variable 'hwc' set but not used [-Wunused-but-set-variable]
     676 |  struct hw_perf_event *hwc;
         |                        ^~~


vim +/hwc +676 arch/x86/events/amd/core.c

   672	
   673	static void amd_pmu_enable_all(int added)
   674	{
   675		struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
 > 676		struct hw_perf_event *hwc;
   677		int idx;
   678	
   679		amd_brs_enable_all();
   680	
   681		for (idx = 0; idx < x86_pmu.num_counters; idx++) {
   682			hwc = &cpuc->events[idx]->hw;
   683	
   684			/* only activate events which are marked as active */
   685			if (!test_bit(idx, cpuc->active_mask))
   686				continue;
   687	
   688			amd_pmu_enable_event(cpuc->events[idx]);
   689		}
   690	}
   691	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

  reply	other threads:[~2022-01-27  1:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 23:34 [PATCH v5 00/14] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-27  1:52   ` kernel test robot [this message]
2022-01-27  6:09   ` kernel test robot
2022-01-27  6:09     ` kernel test robot
2022-01-26 23:34 ` [PATCH v5 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-01-27 12:51   ` Peter Zijlstra
2022-02-01  7:28     ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 08/13] ACPI: add perf low power callback Stephane Eranian
2022-01-27  4:58   ` kernel test robot
2022-01-27  7:41   ` kernel test robot
2022-01-27  7:41     ` kernel test robot
2022-01-27 13:06   ` Peter Zijlstra
2022-02-01  7:33     ` Stephane Eranian
2022-02-01 10:20       ` Peter Zijlstra
2022-01-26 23:34 ` [PATCH v5 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-01-27 13:07   ` Peter Zijlstra
2022-02-01  7:34     ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 10/13] perf evsel: Make evsel__env always return a valid env Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
2022-01-28  8:35 [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support kernel test robot
2022-01-30  2:33 ` kernel test robot
2022-01-30  2:33   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202201270923.FG90uMou-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.