From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3F8C433F5 for ; Thu, 27 Jan 2022 09:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238832AbiA0Jp3 (ORCPT ); Thu, 27 Jan 2022 04:45:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41742 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234378AbiA0Jp1 (ORCPT ); Thu, 27 Jan 2022 04:45:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643276726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TgdNOmxVZp1dDFXB5FAwhB64SXYVLfcMpBsoeczfvek=; b=JHG4TTYKs93m9D0x5kd7DdNE0/d0XDfRZxp+w7nDsSRoHsRdTNqy7fyrd5eYDD2NqvxJc3 x+mhkdQSDn4jW3AGiSnDzcO10Trmqfi9ozDYDwUr9bNZ+Vqt0UK0t6uSVb6HMD8guiVzaX 9LVNq280akDYR6WLMSJXS3QUgPtvCIA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-130-1dA_-dmbMEiTj6c0TdnXSA-1; Thu, 27 Jan 2022 04:45:22 -0500 X-MC-Unique: 1dA_-dmbMEiTj6c0TdnXSA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0788883DD26; Thu, 27 Jan 2022 09:45:21 +0000 (UTC) Received: from localhost (ovpn-13-51.pek2.redhat.com [10.72.13.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 816896C1A7; Thu, 27 Jan 2022 09:44:59 +0000 (UTC) Date: Thu, 27 Jan 2022 17:44:56 +0800 From: Baoquan He To: Al Viro Cc: "Matthew Wilcox (Oracle)" , Vivek Goyal , Dave Young , kexec@lists.infradead.org, Tiezhu Yang , linux-kernel@vger.kernel.org, Amit Daniel Kachhap , Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 0/3] Convert vmcore to use an iov_iter Message-ID: <20220127094456.GD13508@MiWiFi-R3L-srv> References: <20211213143927.3069508-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/01/22 at 12:36am, Al Viro wrote: > On Mon, Dec 13, 2021 at 02:39:24PM +0000, Matthew Wilcox (Oracle) wrote: > > For some reason several people have been sending bad patches to fix > > compiler warnings in vmcore recently. Here's how it should be done. > > Compile-tested only on x86. As noted in the first patch, s390 should > > take this conversion a bit further, but I'm not inclined to do that > > work myself. > > A couple of notes: please, use iov_iter_count(i) instead of open-coding > i->count. And there's a preexisting nastiness in read_vmcore() - > generally, a fault halfway through the read() is treated as a short read, > rather than -EFAULT... Willy must be busy with those tons of folio patches, since I have acked this patchset, I will update them as per your comment and repost them with v4. Thanks for checking. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Date: Thu, 27 Jan 2022 17:44:56 +0800 Subject: [PATCH v3 0/3] Convert vmcore to use an iov_iter In-Reply-To: References: <20211213143927.3069508-1-willy@infradead.org> Message-ID: <20220127094456.GD13508@MiWiFi-R3L-srv> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org Hi, On 01/01/22 at 12:36am, Al Viro wrote: > On Mon, Dec 13, 2021 at 02:39:24PM +0000, Matthew Wilcox (Oracle) wrote: > > For some reason several people have been sending bad patches to fix > > compiler warnings in vmcore recently. Here's how it should be done. > > Compile-tested only on x86. As noted in the first patch, s390 should > > take this conversion a bit further, but I'm not inclined to do that > > work myself. > > A couple of notes: please, use iov_iter_count(i) instead of open-coding > i->count. And there's a preexisting nastiness in read_vmcore() - > generally, a fault halfway through the read() is treated as a short read, > rather than -EFAULT... Willy must be busy with those tons of folio patches, since I have acked this patchset, I will update them as per your comment and repost them with v4. Thanks for checking.