Re: [PATCH net-next 3/7] net: lan966x: Add support for ptp clocks

From: Richard Cochran <richardcochran@gmail.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	kuba@kernel.org, robh+dt@kernel.org,
	UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
	f.fainelli@gmail.com, vivien.didelot@gmail.com,
	vladimir.oltean@nxp.com, andrew@lunn.ch
Subject: Re: [PATCH net-next 3/7] net: lan966x: Add support for ptp clocks
Date: Thu, 27 Jan 2022 07:28:41 -0800	[thread overview]
Message-ID: <20220127152841.GC20642@hoboy.vegasvil.org> (raw)
In-Reply-To: <20220127102333.987195-4-horatiu.vultur@microchip.com>

On Thu, Jan 27, 2022 at 11:23:29AM +0100, Horatiu Vultur wrote:

> +static int lan966x_ptp_phc_init(struct lan966x *lan966x,
> +				int index,
> +				struct ptp_clock_info *clock_info)
> +{
> +	struct lan966x_phc *phc = &lan966x->phc[index];
> +
> +	phc->info = *clock_info;
> +	phc->clock = ptp_clock_register(&phc->info, lan966x->dev);
> +	if (IS_ERR(phc->clock))
> +		return PTR_ERR(phc->clock);
> +
> +	phc->index = index;
> +	phc->lan966x = lan966x;
> +
> +	/* PTP Rx stamping is always enabled.  */
> +	phc->hwtstamp_config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;

Not true -- you allow it to be disabled in the next patch!

Thanks,
Richard

> +
> +	return 0;
> +}