From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20E5C433EF for ; Thu, 27 Jan 2022 09:54:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F3D36B0072; Thu, 27 Jan 2022 04:54:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3316B0073; Thu, 27 Jan 2022 04:54:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B8406B0075; Thu, 27 Jan 2022 04:54:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 5D5AC6B0072 for ; Thu, 27 Jan 2022 04:54:59 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 218C68630E for ; Thu, 27 Jan 2022 09:54:59 +0000 (UTC) X-FDA: 79075608318.06.A977647 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf30.hostedemail.com (Postfix) with ESMTP id 0247480011 for ; Thu, 27 Jan 2022 09:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643277298; x=1674813298; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mUY78+Eoa38zAFeVr8PNqStJRJq0V6SkwXkKXKkWQiU=; b=FRqpUZzJmWTWzPsNHcKjzLja+UOESvJhOVCIphjxy3IM8kIcPio9pr5t tkyGKwGfn/fk4LcbKaRV6rKHtlaG08NQzmI+3iPPn/pOBggacsE2HW9jb Pz6FB2kkV337lXKb97qsh4BP6cDA62pfyMMpgAdy4GZ/mlAnwQvTw9T3Q S4QK5BV0+aJxwasbqCgkv7KzuX2cWjLMMUnAMq1Qw/7ez+PXavNpLycKb IQLJjBoddXU9x/odLvIy/rHlp64ozJkVKLjQfZOpSOlNKUf7OXh19yoem Y2OaPf4ccFyA7q+54dH90bRtr67t59cJFloz3eteKCx1gBIB+dCsvkfFX Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="333158970" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="333158970" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 01:54:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="495673913" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 27 Jan 2022 01:54:52 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nD1UR-000MRf-HX; Thu, 27 Jan 2022 09:54:51 +0000 Date: Thu, 27 Jan 2022 17:54:47 +0800 From: kernel test robot To: NeilBrown , Andrew Morton , Jaegeuk Kim , Chao Yu , Chao Yu , Jeff Layton , Ilya Dryomov , Miklos Szeredi , Trond Myklebust , Anna Schumaker , Ryusuke Konishi Cc: kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions Message-ID: <202201271751.kYuN2eRv-lkp@intel.com> References: <164325158955.29787.4769373293473421057.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164325158955.29787.4769373293473421057.stgit@noble.brown> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0247480011 X-Stat-Signature: 6hejwa3b6w4aa56a75kh78zo6e4qmtzk Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FRqpUZzJ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf30.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=lkp@intel.com X-Rspam-User: nil X-HE-Tag: 1643277297-990190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi NeilBrown, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on jaegeuk-f2fs/dev-test] [also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/master v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220127/202201271751.kYuN2eRv-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051 git checkout 4e63f49027815bc4037227b6d091210c86009e7a # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ext2/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/ext2/ialloc.c: In function 'ext2_preread_inode': >> fs/ext2/ialloc.c:173:27: warning: variable 'bdi' set but not used [-Wunused-but-set-variable] 173 | struct backing_dev_info *bdi; | ^~~ vim +/bdi +173 fs/ext2/ialloc.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 154 ^1da177e4c3f41 Linus Torvalds 2005-04-16 155 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 156 * We perform asynchronous prereading of the new inode's inode block when ^1da177e4c3f41 Linus Torvalds 2005-04-16 157 * we create the inode, in the expectation that the inode will be written ^1da177e4c3f41 Linus Torvalds 2005-04-16 158 * back soon. There are two reasons: ^1da177e4c3f41 Linus Torvalds 2005-04-16 159 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 160 * - When creating a large number of files, the async prereads will be ^1da177e4c3f41 Linus Torvalds 2005-04-16 161 * nicely merged into large reads ^1da177e4c3f41 Linus Torvalds 2005-04-16 162 * - When writing out a large number of inodes, we don't need to keep on ^1da177e4c3f41 Linus Torvalds 2005-04-16 163 * stalling the writes while we read the inode block. ^1da177e4c3f41 Linus Torvalds 2005-04-16 164 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 165 * FIXME: ext2_get_group_desc() needs to be simplified. ^1da177e4c3f41 Linus Torvalds 2005-04-16 166 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 167 static void ext2_preread_inode(struct inode *inode) ^1da177e4c3f41 Linus Torvalds 2005-04-16 168 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 169 unsigned long block_group; ^1da177e4c3f41 Linus Torvalds 2005-04-16 170 unsigned long offset; ^1da177e4c3f41 Linus Torvalds 2005-04-16 171 unsigned long block; ^1da177e4c3f41 Linus Torvalds 2005-04-16 172 struct ext2_group_desc * gdp; ^1da177e4c3f41 Linus Torvalds 2005-04-16 @173 struct backing_dev_info *bdi; ^1da177e4c3f41 Linus Torvalds 2005-04-16 174 de1414a654e66b Christoph Hellwig 2015-01-14 175 bdi = inode_to_bdi(inode); ^1da177e4c3f41 Linus Torvalds 2005-04-16 176 ^1da177e4c3f41 Linus Torvalds 2005-04-16 177 block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb); ef2fb67989d30f Eric Sandeen 2007-10-16 178 gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL); ^1da177e4c3f41 Linus Torvalds 2005-04-16 179 if (gdp == NULL) ^1da177e4c3f41 Linus Torvalds 2005-04-16 180 return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 181 ^1da177e4c3f41 Linus Torvalds 2005-04-16 182 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 183 * Figure out the offset within the block group inode table ^1da177e4c3f41 Linus Torvalds 2005-04-16 184 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 185 offset = ((inode->i_ino - 1) % EXT2_INODES_PER_GROUP(inode->i_sb)) * ^1da177e4c3f41 Linus Torvalds 2005-04-16 186 EXT2_INODE_SIZE(inode->i_sb); ^1da177e4c3f41 Linus Torvalds 2005-04-16 187 block = le32_to_cpu(gdp->bg_inode_table) + ^1da177e4c3f41 Linus Torvalds 2005-04-16 188 (offset >> EXT2_BLOCK_SIZE_BITS(inode->i_sb)); ^1da177e4c3f41 Linus Torvalds 2005-04-16 189 sb_breadahead(inode->i_sb, block); ^1da177e4c3f41 Linus Torvalds 2005-04-16 190 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 191 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============9064866756516493122==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions Date: Thu, 27 Jan 2022 17:54:47 +0800 Message-ID: <202201271751.kYuN2eRv-lkp@intel.com> In-Reply-To: <164325158955.29787.4769373293473421057.stgit@noble.brown> List-Id: --===============9064866756516493122== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi NeilBrown, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on jaegeuk-f2fs/dev-test] [also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/mas= ter v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining= -parts-of-congestions-tracking-code/20220127-105051 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git de= v-test config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202201= 27/202201271751.kYuN2eRv-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d= 091210c86009e7a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-o= f-congestions-tracking-code/20220127-105051 git checkout 4e63f49027815bc4037227b6d091210c86009e7a # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash fs/ext2/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/ext2/ialloc.c: In function 'ext2_preread_inode': >> fs/ext2/ialloc.c:173:27: warning: variable 'bdi' set but not used [-Wunu= sed-but-set-variable] 173 | struct backing_dev_info *bdi; | ^~~ vim +/bdi +173 fs/ext2/ialloc.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 154 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 155 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 156 * We perform asynchronou= s prereading of the new inode's inode block when ^1da177e4c3f41 Linus Torvalds 2005-04-16 157 * we create the inode, i= n the expectation that the inode will be written ^1da177e4c3f41 Linus Torvalds 2005-04-16 158 * back soon. There are = two reasons: ^1da177e4c3f41 Linus Torvalds 2005-04-16 159 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 160 * - When creating a larg= e number of files, the async prereads will be ^1da177e4c3f41 Linus Torvalds 2005-04-16 161 * nicely merged into l= arge reads ^1da177e4c3f41 Linus Torvalds 2005-04-16 162 * - When writing out a l= arge number of inodes, we don't need to keep on ^1da177e4c3f41 Linus Torvalds 2005-04-16 163 * stalling the writes = while we read the inode block. ^1da177e4c3f41 Linus Torvalds 2005-04-16 164 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 165 * FIXME: ext2_get_group_= desc() needs to be simplified. ^1da177e4c3f41 Linus Torvalds 2005-04-16 166 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 167 static void ext2_preread_= inode(struct inode *inode) ^1da177e4c3f41 Linus Torvalds 2005-04-16 168 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 169 unsigned long block_grou= p; ^1da177e4c3f41 Linus Torvalds 2005-04-16 170 unsigned long offset; ^1da177e4c3f41 Linus Torvalds 2005-04-16 171 unsigned long block; ^1da177e4c3f41 Linus Torvalds 2005-04-16 172 struct ext2_group_desc *= gdp; ^1da177e4c3f41 Linus Torvalds 2005-04-16 @173 struct backing_dev_info = *bdi; ^1da177e4c3f41 Linus Torvalds 2005-04-16 174 = de1414a654e66b Christoph Hellwig 2015-01-14 175 bdi =3D inode_to_bdi(ino= de); ^1da177e4c3f41 Linus Torvalds 2005-04-16 176 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 177 block_group =3D (inode->= i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb); ef2fb67989d30f Eric Sandeen 2007-10-16 178 gdp =3D ext2_get_group_d= esc(inode->i_sb, block_group, NULL); ^1da177e4c3f41 Linus Torvalds 2005-04-16 179 if (gdp =3D=3D NULL) ^1da177e4c3f41 Linus Torvalds 2005-04-16 180 return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 181 = ^1da177e4c3f41 Linus Torvalds 2005-04-16 182 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 183 * Figure out the offset= within the block group inode table ^1da177e4c3f41 Linus Torvalds 2005-04-16 184 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 185 offset =3D ((inode->i_in= o - 1) % EXT2_INODES_PER_GROUP(inode->i_sb)) * ^1da177e4c3f41 Linus Torvalds 2005-04-16 186 EXT2_INODE_SIZE(inode= ->i_sb); ^1da177e4c3f41 Linus Torvalds 2005-04-16 187 block =3D le32_to_cpu(gd= p->bg_inode_table) + ^1da177e4c3f41 Linus Torvalds 2005-04-16 188 (offset >> EXT2_BLOCK= _SIZE_BITS(inode->i_sb)); ^1da177e4c3f41 Linus Torvalds 2005-04-16 189 sb_breadahead(inode->i_s= b, block); ^1da177e4c3f41 Linus Torvalds 2005-04-16 190 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 191 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============9064866756516493122==--