Hi Pratyush, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on robh/for-next linus/master v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pratyush-Yadav/CSI2RX-support-on-J721E/20220121-223208 base: git://linuxtv.org/media_tree.git master config: xtensa-randconfig-r002-20220127 (https://download.01.org/0day-ci/archive/20220128/202201281220.ldWeraZ1-lkp(a)intel.com/config) compiler: xtensa-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/749d01c4ff1afb97105a68c3724681d50dfec64f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pratyush-Yadav/CSI2RX-support-on-J721E/20220121-223208 git checkout 749d01c4ff1afb97105a68c3724681d50dfec64f # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): xtensa-linux-ld: drivers/media/platform/cadence/cdns-csi2rx.o: in function `csi2rx_remove': >> cdns-csi2rx.c:(.text+0x80): undefined reference to `phy_mipi_dphy_get_default_config' xtensa-linux-ld: drivers/media/platform/cadence/cdns-csi2rx.o: in function `csi2rx_configure_external_dphy': cdns-csi2rx.c:(.text+0x10c): undefined reference to `phy_mipi_dphy_get_default_config' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org