From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4268CC433EF for ; Fri, 28 Jan 2022 18:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350544AbiA1S0l convert rfc822-to-8bit (ORCPT ); Fri, 28 Jan 2022 13:26:41 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4556 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350527AbiA1S0l (ORCPT ); Fri, 28 Jan 2022 13:26:41 -0500 Received: from fraeml745-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jlm6J6hpHz67b4M; Sat, 29 Jan 2022 02:23:04 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml745-chm.china.huawei.com (10.206.15.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 19:26:39 +0100 Received: from localhost (10.122.247.231) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 18:26:38 +0000 Date: Fri, 28 Jan 2022 18:26:37 +0000 From: Jonathan Cameron To: Alex =?ISO-8859-1?Q?Benn=E9e?= CC: , Marcel Apfelbaum , "Michael S . Tsirkin" , Igor Mammedov , , Ben Widawsky , "Peter Maydell" , , "Shameerali Kolothum Thodi" , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Saransh Gupta1 , Shreyas Shah , Chris Browy , Samarth Saxena , "Dan Williams" Subject: Re: [PATCH v4 14/42] tests/acpi: allow DSDT.viot table changes. Message-ID: <20220128182637.0000188a@huawei.com> In-Reply-To: <87a6fh9sry.fsf@linaro.org> References: <20220124171705.10432-1-Jonathan.Cameron@huawei.com> <20220124171705.10432-15-Jonathan.Cameron@huawei.com> <87a6fh9sry.fsf@linaro.org> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhreml740-chm.china.huawei.com (10.201.108.190) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, 27 Jan 2022 14:06:42 +0000 Alex Bennée wrote: > Jonathan Cameron writes: > > > From: Jonathan Cameron > > > > The next patch unifies some of the PCI host bridge DSDT > > generation code and results in some minor changes to this file. > > I'd just squash this in with the patch that makes the change... > otherwise you risk breaking bisectablility. Hi Alex, This sequence of 3 patches is as described in tests/qtest/bios-tables-test.c According to description there the point is to allow whoever picks these patches up to just change the 3rd patch if the tables need updating to reflect some other change. It would be a lot easier obviously to just squash it, but given the process is laid out in that file, I'd rather leave it like this. Or am I missing a reason this particular one is better squashed? Thanks, Jonathan > > > > > Signed-off-by: Jonathan Cameron > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > > index dfb8523c8b..08a8095432 100644 > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > @@ -1 +1,2 @@ > > /* List of comma-separated changed AML files to ignore */ > > +"tests/data/acpi/q35/DSDT.viot", > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 821CEC433EF for ; Fri, 28 Jan 2022 18:31:38 +0000 (UTC) Received: from localhost ([::1]:35872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDW25-0001tK-FY for qemu-devel@archiver.kernel.org; Fri, 28 Jan 2022 13:31:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDVxe-00061I-Ha for qemu-devel@nongnu.org; Fri, 28 Jan 2022 13:27:07 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDVxY-0008Ne-N9 for qemu-devel@nongnu.org; Fri, 28 Jan 2022 13:27:01 -0500 Received: from fraeml745-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jlm6J6hpHz67b4M; Sat, 29 Jan 2022 02:23:04 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml745-chm.china.huawei.com (10.206.15.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 19:26:39 +0100 Received: from localhost (10.122.247.231) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 18:26:38 +0000 Date: Fri, 28 Jan 2022 18:26:37 +0000 To: Alex =?ISO-8859-1?Q?Benn=E9e?= CC: , Marcel Apfelbaum , "Michael S . Tsirkin" , Igor Mammedov , , Ben Widawsky , "Peter Maydell" , , "Shameerali Kolothum Thodi" , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Saransh Gupta1 , Shreyas Shah , Chris Browy , Samarth Saxena , "Dan Williams" Subject: Re: [PATCH v4 14/42] tests/acpi: allow DSDT.viot table changes. Message-ID: <20220128182637.0000188a@huawei.com> In-Reply-To: <87a6fh9sry.fsf@linaro.org> References: <20220124171705.10432-1-Jonathan.Cameron@huawei.com> <20220124171705.10432-15-Jonathan.Cameron@huawei.com> <87a6fh9sry.fsf@linaro.org> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhreml740-chm.china.huawei.com (10.201.108.190) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Jonathan Cameron From: Jonathan Cameron via On Thu, 27 Jan 2022 14:06:42 +0000 Alex Benn=E9e wrote: > Jonathan Cameron writes: >=20 > > From: Jonathan Cameron > > > > The next patch unifies some of the PCI host bridge DSDT > > generation code and results in some minor changes to this file. =20 >=20 > I'd just squash this in with the patch that makes the change... > otherwise you risk breaking bisectablility. Hi Alex, This sequence of 3 patches is as described in tests/qtest/bios-tables-test.c According to description there the point is to allow whoever picks these patches up to just change the 3rd patch if the tables need updating to reflect some other change. It would be a lot easier obviously to just squash it, but given the process is laid out in that file, I'd rather leave it like this. Or am I missing a reason this particular one is better squashed?=20 Thanks, Jonathan >=20 > > > > Signed-off-by: Jonathan Cameron > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/= bios-tables-test-allowed-diff.h > > index dfb8523c8b..08a8095432 100644 > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > @@ -1 +1,2 @@ > > /* List of comma-separated changed AML files to ignore */ > > +"tests/data/acpi/q35/DSDT.viot", =20 >=20 >=20