From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3557466438243249513==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 29 Jan 2022 03:28:40 +0800 Message-ID: <20220128192840.GA1720@6caf23feb5e9> In-Reply-To: <202201290335.68sRjdlN-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============3557466438243249513== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Alessandro Zummo CC: Alexandre Belloni CC: linux-rtc(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/rtc/rtc-max8998.c:283:7-32: WARNING: Threaded IRQ with no primary h= andler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 145d9b498fc827b79c1260b4caa29a8e59d4c2b9 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 10 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! rtc-max8998.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/rtc/rtc-max8998.c +++ b/drivers/rtc/rtc-max8998.c @@ -281,7 +281,8 @@ static int max8998_rtc_probe(struct plat } = ret =3D devm_request_threaded_irq(&pdev->dev, info->irq, NULL, - max8998_rtc_alarm_irq, 0, "rtc-alarm0", info); + max8998_rtc_alarm_irq, IRQF_ONESHOT, + "rtc-alarm0", info); = if (ret < 0) dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", --===============3557466438243249513==--