From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] qapi/block: Cosmetic change in BlockExportType schema
Date: Fri, 28 Jan 2022 14:54:30 -0600 [thread overview]
Message-ID: <20220128205430.ispmytuw2vrpar4g@redhat.com> (raw)
In-Reply-To: <20220119121439.214821-1-f4bug@amsat.org>
On Wed, Jan 19, 2022 at 01:14:39PM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daude <f4bug@amsat.org>
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
The doubled From: looks odd here. I'll double-check that git doesn't
mess up the actual commit once I apply the patch.
>
> Fix long line introduced in commit bb01ea73110 ("qapi/block:
> Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER").
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Acked-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> qapi/block-export.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-export.json b/qapi/block-export.json
> index f9ce79a974b..f183522d0d2 100644
> --- a/qapi/block-export.json
> +++ b/qapi/block-export.json
> @@ -278,7 +278,8 @@
> ##
> { 'enum': 'BlockExportType',
> 'data': [ 'nbd',
> - { 'name': 'vhost-user-blk', 'if': 'CONFIG_VHOST_USER_BLK_SERVER' },
> + { 'name': 'vhost-user-blk',
> + 'if': 'CONFIG_VHOST_USER_BLK_SERVER' },
> { 'name': 'fuse', 'if': 'CONFIG_FUSE' } ] }
Reviewed-by: Eric Blake <eblake@redhat.com>
Happy to queue this through my NBD tree (as it is tangentially related...)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-01-28 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 12:14 [PATCH] qapi/block: Cosmetic change in BlockExportType schema Philippe Mathieu-Daudé via
2022-01-28 20:54 ` Eric Blake [this message]
2022-01-30 18:50 ` Philippe Mathieu-Daudé via
2022-01-31 21:37 ` Eric Blake
2022-01-31 23:19 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128205430.ispmytuw2vrpar4g@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.