From: Eric Blake <eblake@redhat.com>
To: Hanna Reitz <hreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [PATCH v2 2/2] iotests/block-status-cache: New test
Date: Fri, 28 Jan 2022 16:55:19 -0600 [thread overview]
Message-ID: <20220128225519.jd2yqojnkgvimbgg@redhat.com> (raw)
In-Reply-To: <20220128205051.aqbqkfkavlb6ycci@redhat.com>
On Fri, Jan 28, 2022 at 02:50:51PM -0600, Eric Blake wrote:
> On Tue, Jan 18, 2022 at 06:00:00PM +0100, Hanna Reitz wrote:
> > Add a new test to verify that want_zero=false block-status calls do not
> > pollute the block-status cache for want_zero=true calls.
> >
> > We check want_zero=true calls and their results using `qemu-img map`
> > (over NBD), and want_zero=false calls also using `qemu-img map` over
> > NBD, but using the qemu:allocation-depth context.
> >
> > (This test case cannot be integrated into nbd-qemu-allocation, because
> > that is a qcow2 test, and this is a raw test.)
> >
> > Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> > ---
> > tests/qemu-iotests/tests/block-status-cache | 139 ++++++++++++++++++
> > .../qemu-iotests/tests/block-status-cache.out | 5 +
> > 2 files changed, 144 insertions(+)
> > create mode 100755 tests/qemu-iotests/tests/block-status-cache
> > create mode 100644 tests/qemu-iotests/tests/block-status-cache.out
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
I also tested that applying this patch but not 1/2 reproduces the
failure for me, so I'm adding:
Tested-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2022-01-28 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 16:59 [PATCH v2 0/2] block/io: Update BSC only if want_zero is true Hanna Reitz
2022-01-18 16:59 ` [PATCH v2 1/2] " Hanna Reitz
2022-01-28 20:46 ` Eric Blake
2022-01-18 17:00 ` [PATCH v2 2/2] iotests/block-status-cache: New test Hanna Reitz
2022-01-18 18:02 ` Nir Soffer
2022-01-28 20:50 ` Eric Blake
2022-01-28 22:55 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128225519.jd2yqojnkgvimbgg@redhat.com \
--to=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.