From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E87DC433EF for ; Sat, 29 Jan 2022 02:40:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6FF781112; Sat, 29 Jan 2022 03:40:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 3A1B283672; Sat, 29 Jan 2022 03:40:54 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 4F4C781112 for ; Sat, 29 Jan 2022 03:40:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91BA7D6E; Fri, 28 Jan 2022 18:40:50 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA15A3F7D7; Fri, 28 Jan 2022 18:40:47 -0800 (PST) Date: Sat, 29 Jan 2022 02:40:34 +0000 From: Andre Przywara To: Jesse Taube Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com Subject: Re: [PATCH v2 00/12] Add support for SUNIV and F1C100s. Message-ID: <20220129024034.78c2f30a@slackpad.fritz.box> In-Reply-To: <20220126135329.2997430-1-Mr.Bossman075@gmail.com> References: <20220126135329.2997430-1-Mr.Bossman075@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 26 Jan 2022 08:53:17 -0500 Jesse Taube wrote: Hi Jesse, > This patch set aims to add support for the SUNIV and F1C100s. > Support has been in linux for a while now, but not in u-boot. > > This patchset contains: > - CPU specific initialization code > - SUNIV dram driver > - SUNIV clock driver adaption > - SUNIV gpio driver adaption > - SUNIV uart driver adaption > - F1C100s basic support > > The SUNIV seems to be similar to sun6i and sun4i, so we use code from > both platforms. We also add suniv to the cpu dircetory as it uses arm926ejs. > > NOTE: To work this will need patchset "sunxi: remove lowlevel_init". So I think I am done with reviewing this version. Please send an updated version. If there are smaller issues left, I will probably just fix them up while committing. Thanks for your good and prompt work on this! Cheers, Andre > > Icenowy Zheng (11): > arm: arm926ej-s: start.S: port save_boot_params support from armv7 > code > arm: arm926ej-s: Add sunxi code > dt-bindings: clock: Add initial suniv headers > dt-bindings: reset: Add initial suniv headers > ARM: sunxi: Add clock and uart to sunxi headers > sunxi: Add F1C100s DRAM initial support > sunxi: board: Add support for SUNIV > configs: sunxi: Add common SUNIV header > mach-sunxi: Add support for SUNIV architecture > ARM: dts: suniv: Add device tree files for F1C100s > configs: sunxi: Add support for Lichee Pi Nano > > Jesse Taube (1): > mach-sunxi: Move timer code to mach folder > > arch/arm/cpu/arm926ejs/Makefile | 1 + > arch/arm/cpu/arm926ejs/start.S | 19 + > arch/arm/cpu/arm926ejs/sunxi/Makefile | 5 + > arch/arm/cpu/arm926ejs/sunxi/config.mk | 6 + > arch/arm/cpu/arm926ejs/sunxi/fel_utils.S | 33 ++ > arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds | 48 ++ > arch/arm/dts/Makefile | 2 + > arch/arm/dts/suniv-f1c100s-licheepi-nano.dts | 29 ++ > arch/arm/dts/suniv-f1c100s.dtsi | 6 + > arch/arm/dts/suniv.dtsi | 160 +++++++ > arch/arm/include/asm/arch-sunxi/clock.h | 2 +- > arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 13 + > arch/arm/include/asm/arch-sunxi/cpu_sun4i.h | 6 + > arch/arm/include/asm/arch-sunxi/dram.h | 2 + > arch/arm/include/asm/arch-sunxi/dram_suniv.h | 46 ++ > arch/arm/include/asm/arch-sunxi/gpio.h | 1 + > arch/arm/mach-sunxi/Kconfig | 16 +- > arch/arm/mach-sunxi/Makefile | 5 + > arch/arm/mach-sunxi/board.c | 28 +- > arch/arm/mach-sunxi/clock.c | 3 +- > arch/arm/mach-sunxi/clock_sun6i.c | 46 +- > arch/arm/mach-sunxi/cpu_info.c | 2 + > arch/arm/mach-sunxi/dram_helpers.c | 4 + > arch/arm/mach-sunxi/dram_suniv.c | 420 ++++++++++++++++++ > .../{cpu/armv7/sunxi => mach-sunxi}/timer.c | 7 +- > board/sunxi/board.c | 4 +- > configs/licheepi_nano_defconfig | 15 + > include/configs/suniv.h | 14 + > include/configs/sunxi-common.h | 59 ++- > include/dt-bindings/clock/suniv-ccu.h | 69 +++ > include/dt-bindings/reset/suniv-ccu.h | 37 ++ > 31 files changed, 1080 insertions(+), 28 deletions(-) > create mode 100644 arch/arm/cpu/arm926ejs/sunxi/Makefile > create mode 100644 arch/arm/cpu/arm926ejs/sunxi/config.mk > create mode 100644 arch/arm/cpu/arm926ejs/sunxi/fel_utils.S > create mode 100644 arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds > create mode 100644 arch/arm/dts/suniv-f1c100s-licheepi-nano.dts > create mode 100644 arch/arm/dts/suniv-f1c100s.dtsi > create mode 100644 arch/arm/dts/suniv.dtsi > create mode 100644 arch/arm/include/asm/arch-sunxi/dram_suniv.h > create mode 100644 arch/arm/mach-sunxi/dram_suniv.c > rename arch/arm/{cpu/armv7/sunxi => mach-sunxi}/timer.c (97%) > create mode 100644 configs/licheepi_nano_defconfig > create mode 100644 include/configs/suniv.h > create mode 100644 include/dt-bindings/clock/suniv-ccu.h > create mode 100644 include/dt-bindings/reset/suniv-ccu.h >