From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F12C433FE for ; Sun, 30 Jan 2022 12:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354770AbiA3MZi (ORCPT ); Sun, 30 Jan 2022 07:25:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354760AbiA3MZi (ORCPT ); Sun, 30 Jan 2022 07:25:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBEB1C061714; Sun, 30 Jan 2022 04:25:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8851BB82920; Sun, 30 Jan 2022 12:25:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C620C340E4; Sun, 30 Jan 2022 12:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643545535; bh=qQp9Ydhf25VS6D6MpriuZZ0bGWeVhYXJp4Y6EavVOsc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QtfUmzPkUvpp4y4hfqnbeAackZ4U+DnUuzmbHoIZ+4dig3kYJy18rBSZ2of+jOVE0 VeuQB/eZ/2cw0DQ2g+VD7CfflBUnJe1IHelkj1X8cmvVc5v5hTf+/3VfsoRGtynkmW Kx3N2OzmER+O8hnmfL6+84gk4Tv7l5l6u8fVMxu4ewFtztW9HNR/09O6dK2cHCz4UX XftS4kMyd8O6wP02qhlEdRydL3eIkzhPvEeWfD2r8Cz1QuI/YfAkjlByEkDyaBwrfC 1Wn9AClpAOsPjVJzD/x9PqK88d+WIlbNrbLygT7Yqz8d6srAlXjs15sAg8KD+TMgdq LmEa+U9RARNjw== Date: Sun, 30 Jan 2022 12:31:57 +0000 From: Jonathan Cameron To: Michael Tretter Cc: Robert Hancock , "lars@metafoo.de" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "michal.simek@xilinx.com" , "linux-iio@vger.kernel.org" , "manish.narani@xilinx.com" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "anand.ashok.dumbre@xilinx.com" Subject: Re: [PATCH 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Message-ID: <20220130123157.0d98f968@jic23-huawei> In-Reply-To: <20220126091250.GC2550@pengutronix.de> References: <20220120010246.3794962-1-robert.hancock@calian.com> <20220120010246.3794962-4-robert.hancock@calian.com> <20220125082108.GE25856@pengutronix.de> <4c5fb3899a8aafa34106a668bcb2807b6f073036.camel@calian.com> <20220126091250.GC2550@pengutronix.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 26 Jan 2022 10:12:50 +0100 Michael Tretter wrote: > On Tue, 25 Jan 2022 16:15:05 +0000, Robert Hancock wrote: > > On Tue, 2022-01-25 at 09:21 +0100, Michael Tretter wrote: > > > On Wed, 19 Jan 2022 19:02:45 -0600, Robert Hancock wrote: > > > > Register settings used for the sequencer configuration register > > > > were incorrect, causing some inputs to not be read properly. > > > > > > > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > > > > Signed-off-by: Robert Hancock > > > > --- > > > > drivers/iio/adc/xilinx-ams.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > > > index b93864362dac..199027c93cdc 100644 > > > > --- a/drivers/iio/adc/xilinx-ams.c > > > > +++ b/drivers/iio/adc/xilinx-ams.c > > > > @@ -91,8 +91,8 @@ > > > > > > > > #define AMS_CONF1_SEQ_MASK GENMASK(15, 12) > > > > #define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > > 0) > > > > -#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1) > > > > -#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > > 2) > > > > +#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) > > > > +#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > > 3) > > > > > > The TRM states that Continuous Loop Mode is 2, but Single Pass Sequence Mode > > > is 1, not 3. Is there a reason, why you need to set both bits? > > > > Single pass sequence mode (1) just runs the same sequence only once. To read > > these values it needs to switch to single channel mode (3). > > > > The register bits are defined in Table 3-8 of > > https://www.xilinx.com/support/documentation/user_guides/ug580-ultrascale-sysmon.pdf > > . > > Thanks for the clarification. > > Reviewed-by: Michael Tretter Applied to the fixes-togreg branch of iio.git Thanks, Jonathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3A72C433F5 for ; Sun, 30 Jan 2022 12:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jgFk5JCSjyaqdTjD4I+GdIb88eTDtPb4d/KR1k/mssI=; b=Bgij7TnjPoIYXc QizlhkAf3B1heYg5N/HUHnWHVslY0QZGjNd9DsEwAZdeFFtb5nTOXmfmrceEXy4p6+zbNQV26TCGt bWWFTdmRaw4DS1br+/k1MI0bekrO96s2q9elFitoSj/m+oFfro9nA9/vtJh65oeYfnIbZj+aZ1tzN ZyzUDbTuwxT6s6T4z/xn81RQ0lE2DsFjNO9TYZQasKUU5RT9Zo6DaCpOP9iZuMh7EVmAcMnnoiDtu TpILMOLqfQMDkLNdR5bMhwqNFL1eG+hxqjQ6BD3faubECKTHpMr8PinLJ701cBr6ncINjIIt4bYNE RfPj/9XWShRQa/+0wVTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nE9H3-006UJG-VA; Sun, 30 Jan 2022 12:25:42 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nE9Gz-006UI0-UE for linux-arm-kernel@lists.infradead.org; Sun, 30 Jan 2022 12:25:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F217B80DEF; Sun, 30 Jan 2022 12:25:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C620C340E4; Sun, 30 Jan 2022 12:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643545535; bh=qQp9Ydhf25VS6D6MpriuZZ0bGWeVhYXJp4Y6EavVOsc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QtfUmzPkUvpp4y4hfqnbeAackZ4U+DnUuzmbHoIZ+4dig3kYJy18rBSZ2of+jOVE0 VeuQB/eZ/2cw0DQ2g+VD7CfflBUnJe1IHelkj1X8cmvVc5v5hTf+/3VfsoRGtynkmW Kx3N2OzmER+O8hnmfL6+84gk4Tv7l5l6u8fVMxu4ewFtztW9HNR/09O6dK2cHCz4UX XftS4kMyd8O6wP02qhlEdRydL3eIkzhPvEeWfD2r8Cz1QuI/YfAkjlByEkDyaBwrfC 1Wn9AClpAOsPjVJzD/x9PqK88d+WIlbNrbLygT7Yqz8d6srAlXjs15sAg8KD+TMgdq LmEa+U9RARNjw== Date: Sun, 30 Jan 2022 12:31:57 +0000 From: Jonathan Cameron To: Michael Tretter Cc: Robert Hancock , "lars@metafoo.de" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "michal.simek@xilinx.com" , "linux-iio@vger.kernel.org" , "manish.narani@xilinx.com" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "anand.ashok.dumbre@xilinx.com" Subject: Re: [PATCH 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Message-ID: <20220130123157.0d98f968@jic23-huawei> In-Reply-To: <20220126091250.GC2550@pengutronix.de> References: <20220120010246.3794962-1-robert.hancock@calian.com> <20220120010246.3794962-4-robert.hancock@calian.com> <20220125082108.GE25856@pengutronix.de> <4c5fb3899a8aafa34106a668bcb2807b6f073036.camel@calian.com> <20220126091250.GC2550@pengutronix.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220130_042538_287207_8130BE13 X-CRM114-Status: GOOD ( 24.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 26 Jan 2022 10:12:50 +0100 Michael Tretter wrote: > On Tue, 25 Jan 2022 16:15:05 +0000, Robert Hancock wrote: > > On Tue, 2022-01-25 at 09:21 +0100, Michael Tretter wrote: > > > On Wed, 19 Jan 2022 19:02:45 -0600, Robert Hancock wrote: > > > > Register settings used for the sequencer configuration register > > > > were incorrect, causing some inputs to not be read properly. > > > > > > > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > > > > Signed-off-by: Robert Hancock > > > > --- > > > > drivers/iio/adc/xilinx-ams.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > > > index b93864362dac..199027c93cdc 100644 > > > > --- a/drivers/iio/adc/xilinx-ams.c > > > > +++ b/drivers/iio/adc/xilinx-ams.c > > > > @@ -91,8 +91,8 @@ > > > > > > > > #define AMS_CONF1_SEQ_MASK GENMASK(15, 12) > > > > #define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > > 0) > > > > -#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1) > > > > -#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > > 2) > > > > +#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) > > > > +#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > > > 3) > > > > > > The TRM states that Continuous Loop Mode is 2, but Single Pass Sequence Mode > > > is 1, not 3. Is there a reason, why you need to set both bits? > > > > Single pass sequence mode (1) just runs the same sequence only once. To read > > these values it needs to switch to single channel mode (3). > > > > The register bits are defined in Table 3-8 of > > https://www.xilinx.com/support/documentation/user_guides/ug580-ultrascale-sysmon.pdf > > . > > Thanks for the clarification. > > Reviewed-by: Michael Tretter Applied to the fixes-togreg branch of iio.git Thanks, Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel