Hi Aaron, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on a97ac8cb24a3c3ad74794adb83717ef1605d1b47] url: https://github.com/0day-ci/linux/commits/Aaron-Tomlin/module-core-code-clean-up/20220131-053513 base: a97ac8cb24a3c3ad74794adb83717ef1605d1b47 config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20220131/202201310726.qpjGLaWZ-lkp(a)intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/38d747112088f74defae83400e30abdcaa3b1595 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Aaron-Tomlin/module-core-code-clean-up/20220131-053513 git checkout 38d747112088f74defae83400e30abdcaa3b1595 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash kernel/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from kernel/fork.c:30: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/fork.c: At top level: kernel/fork.c:161:13: warning: no previous prototype for 'arch_release_task_struct' [-Wmissing-prototypes] 161 | void __weak arch_release_task_struct(struct task_struct *tsk) | ^~~~~~~~~~~~~~~~~~~~~~~~ kernel/fork.c:763:20: warning: no previous prototype for 'arch_task_cache_init' [-Wmissing-prototypes] 763 | void __init __weak arch_task_cache_init(void) { } | ^~~~~~~~~~~~~~~~~~~~ kernel/fork.c:858:12: warning: no previous prototype for 'arch_dup_task_struct' [-Wmissing-prototypes] 858 | int __weak arch_dup_task_struct(struct task_struct *dst, | ^~~~~~~~~~~~~~~~~~~~ -- In file included from kernel/exec_domain.c:14: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp -- In file included from include/linux/kallsyms.h:14, from include/linux/ftrace.h:12, from include/linux/kprobes.h:28, from include/linux/kgdb.h:19, from kernel/panic.c:15: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/panic.c: In function '__warn': kernel/panic.c:588:17: warning: function '__warn' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 588 | vprintk(args->fmt, args->args); | ^~~~~~~ -- In file included from kernel/exit.c:17: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/exit.c: At top level: kernel/exit.c:1817:13: warning: no previous prototype for 'abort' [-Wmissing-prototypes] 1817 | __weak void abort(void) | ^~~~~ -- In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/node.h:18, from include/linux/cpu.h:17, from kernel/smp.c:20: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/smp.c: At top level: kernel/smp.c:684:6: warning: no previous prototype for 'flush_smp_call_function_from_idle' [-Wmissing-prototypes] 684 | void flush_smp_call_function_from_idle(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/kallsyms.h:14, from kernel/kallsyms.c:15: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/kallsyms.c: At top level: kernel/kallsyms.c:586:12: warning: no previous prototype for 'arch_get_kallsym' [-Wmissing-prototypes] 586 | int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value, | ^~~~~~~~~~~~~~~~ -- In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/node.h:18, from include/linux/cpu.h:17, from include/linux/static_call.h:135, from include/linux/tracepoint.h:22, from include/trace/syscall.h:5, from include/linux/syscalls.h:88, from kernel/audit.c:44: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/audit.c: In function 'audit_log_vformat': kernel/audit.c:1941:9: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 1941 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args); | ^~~ kernel/audit.c:1950:17: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 1950 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2); | ^~~ -- In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/node.h:18, from include/linux/cpu.h:17, from kernel/irq_work.c:18: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/irq_work.c: At top level: kernel/irq_work.c:70:13: warning: no previous prototype for 'arch_irq_work_raise' [-Wmissing-prototypes] 70 | void __weak arch_irq_work_raise(void) | ^~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from kernel/iomem.c:2: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/iomem.c: At top level: kernel/iomem.c:9:22: warning: no previous prototype for 'ioremap_cache' [-Wmissing-prototypes] 9 | __weak void __iomem *ioremap_cache(resource_size_t offset, unsigned long size) | ^~~~~~~~~~~~~ -- In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/node.h:18, from include/linux/cpu.h:17, from include/linux/static_call.h:135, from include/linux/tracepoint.h:22, from include/trace/events/sched.h:10, from kernel/sched/core.c:10: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/sched/core.c: At top level: kernel/sched/core.c:3453:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes] 3453 | void sched_set_stop_task(int cpu, struct task_struct *stop) | ^~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/node.h:18, from include/linux/cpu.h:17, from include/linux/cpufreq.h:12, from kernel/sched/sched.h:42, from kernel/sched/rt.c:6: include/linux/module.h: In function 'is_livepatch_module': >> include/linux/module.h:669:26: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 669 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:678:22: error: 'struct module' has no member named 'klp'; did you mean 'kp'? 678 | mod->klp = true; | ^~~ | kp kernel/sched/rt.c: At top level: kernel/sched/rt.c:680:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes] 680 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ .. vim +669 include/linux/module.h 665 666 static inline bool is_livepatch_module(struct module *mod) 667 { 668 if (IS_ENABLED(CONFIG_LIVEPATCH)) { > 669 if (mod->klp) 670 return true; 671 } 672 return false; 673 } 674 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org